login
Login
/
Register
Search
Search this site:
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2007
»
October
»
4
Re: [PATCH] PM_QOS 1 of 2
view
thread
Previous message: [
thread
] [
date
] [
author
]
Next message: [thread] [
date
] [
author
]
[view in full thread]
From: Mark Gross
Subject:
Re: [PATCH] PM_QOS 1 of 2
Date: Thursday, October 4, 2007 - 1:39 pm
On Thu, Oct 04, 2007 at 12:53:56PM -0700, Andrew Morton wrote:
quoted text
> On Mon, 1 Oct 2007 16:45:28 -0700 > Mark Gross <mgross@linux.intel.com> wrote: > > > The following is the cleaned up patch implementing the power management > > quality of service infrastructure discussed at the pm summit last June. > > > > It is a genralization of the latency code put into the kernel last year > > by Arjan. > > > > I would like to get this code included in the MM tree and to get some > > milage on it. > > > > One thing to note about this implementation is that it exposes an > > interface to user space for registering pm_qos constraints in addition > > to the kernel exports. Its a file based interface where a module can > > register a constraint and the constraint is valid only as long as the > > device node is held open. Upon closing of the device node that > > constraint is cleaned up. > > > > The patch set is in two postings. > > 1) the base parameter code (this email) > > 2) replacing of latency.c/latenc.h with pm_qos_params.c/pm_qos_params.h > > I wouldn't really view this as an adequate changelog. > > - The Subject:s are pretty pathetic (please see my suggesed replacements)
uhg. Your right.
quoted text
> > - There is no description of the proposed new kernel<->userspace > interfaces. >
the above description is light on specific details.
quoted text
> As you are proposing new and permanent enhancements to the Linux API, > this is something which should be spelled out in some detail. Because we > can change the implementation, but we can not ever change your interface. > > It would be nice to get that interface described in Documentation/ > somewhere, but it is *critical* that the design be fully revealed right > now, during review.
I'll provide this.
quoted text
> > > Anyway, I am not a suitable person to review this submission. > > I'll put the patches in -mm for a bit of eyeball-and-test (not that anyone > will know how to test it, due to the secret interfaces) but I do not want > to move this code into mainline until someone who is familiar with the PM > code has performed a detailed review of both the implementation and the > design (whatever that is!). > > Please send new, complete descriptions of these patches. I don't think > they can be effectively reviewed without that information. Except perhaps > by someone who was at the PM summit, but that's cheating. >
I will do this. --mgross -
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [thread] [
date
] [
author
]
Messages in current thread:
[PATCH] PM_QOS 1 of 2
, Mark Gross
, (Mon Oct 1, 4:45 pm)
Re: [linux-pm] [PATCH] PM_QOS 2 of 2
, Mark Gross
, (Wed Oct 3, 10:59 am)
Re: [PATCH] PM_QOS 1 of 2
, Andrew Morton
, (Thu Oct 4, 12:53 pm)
Re: [PATCH] PM_QOS 1 of 2
, Mark Gross
, (Thu Oct 4, 1:39 pm)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Frederic Weisbecker
[PATCH v2] struct sort_entry has a callback named snprintf that turns an entry int...
FUJITA Tomonori
Re: [Scst-devel] Integration of SCST in the mainstream Linux kernel
Andrew Morton
Re: [PATCH v3 0/4] Introduce hardware spinlock framework
Ingo Molnar
Re: [GIT PULL] time.c - respin
Alexander van Heukelum
Re: [PATCH] bitops: simplify generic bit finding functions
git
:
Mark Junker
git on MacOSX and files with decomposed utf-8 file names
Junio C Hamano
Re: git-svnimport
Johannes Schindelin
Re: [PATCH] Fix approxidate("never") to always return 0
A Large Angry SCM
Re: [RFC] origin link for cherry-pick and revert
Michal Sojka
[PATCHv5 1/2] filter-branch: Fix to allow replacing submodules with another content
git-commits-head
:
Linux Kernel Mailing List
ath9k_htc: Allocate URBs properly
Linux Kernel Mailing List
sata_mv: drop unncessary EH callback resetting
Linux Kernel Mailing List
timer: Try to survive timer callback preempt_count leak
Linux Kernel Mailing List
powerpc/kexec: Add support for FSL-BookE
Linux Kernel Mailing List
ARM: 5670/1: bcmring: add default configuration for bcmring arch
linux-netdev
:
Arnaldo Carvalho de Melo
Re: [PATCH 06/37] dccp: Limit feature negotiation to connection setup phase
Gerrit Renker
[PATCH 1/5] dccp: Initialisation framework for feature negotiation
Daniel Lezcano
getsockopt(TCP_DEFER_ACCEPT) value change
David Miller
Re: 2.6.27.18: bnx2/tg3: BUG: "scheduling while atomic" trying to ifenslave a seco...
Gerrit Renker
[PATCH 37/37] dccp: Debugging functions for feature negotiation
openbsd-misc
:
Stephen J. Bevan
GRE over IPsec
Rene Maroufi
smtpd: Aliases only work with for local alias aliases
Christophe Rioux
Implementation example of snmp
Darrin Chandler
Re: strange output on openbsd C code
Nick Holland
Re: booting openbsd on eee without cd-rom
Colocation donated by:
Syndicate