login
Login
/
Register
Search
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2007
»
October
»
4
Re: -rt scheduling: wakeup bug?
view
thread
!MAILaRCHIVE_VOTE_RePLACE
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From:
Ingo Molnar <mingo@...>
To: Mike Kravetz <kravetz@...>
Cc: Linux Kernel Mailing List <linux-kernel@...>, Thomas Gleixner <tglx@...>, Steven Rostedt <rostedt@...>, Clark Williams <williams@...>
Subject:
Re: -rt scheduling: wakeup bug?
Date: Thursday, October 4, 2007 - 4:02 am
* Mike Kravetz <kravetz@us.ibm.com> wrote:
quoted text
> > if (rq->curr && p && rq && _need_resched()) > > trace_special_pid(p->pid, PRIO(p), PRIO(rq->curr)); > > Not an issue with the patch, just that last bit of code pulled in for > context. I don't think it is a bug, but the checking of 'rq' after > checking 'rq->curr' just doesn't look right (or necessary). Could it > just be an artifact from earlier versions of the code?
yeah, you are right - and rq shouldnt ever be NULL there anyway. Ingo -
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
RT scheduling: wakeup bug?
, Mike Kravetz
, (Mon Oct 1, 6:15 pm)
Re: -rt scheduling: wakeup bug?
, Ingo Molnar
, (Tue Oct 2, 1:06 am)
Re: -rt scheduling: wakeup bug?
, Mike Kravetz
, (Wed Oct 3, 1:37 pm)
Re: -rt scheduling: wakeup bug?
, Ingo Molnar
, (Thu Oct 4, 4:02 am)
Re: -rt scheduling: wakeup bug?
, Mike Kravetz
, (Tue Oct 2, 3:30 pm)
Re: -rt scheduling: wakeup bug?
, Steven Rostedt
, (Tue Oct 2, 3:37 pm)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Greg Kroah-Hartman
[PATCH 005/196] Chinese: add translation of SubmittingDrivers
david
Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
Andrew Morton
Re: PROBLEM: high load average when idle
Karl Meyer
PROBLEM: 2.6.23-rc "NETDEV WATCHDOG: eth0: transmit timed out"
git
:
linux-netdev
:
Evgeniy Polyakov
Mark IPW2100 as BROKEN: Fatal interrupt. Scheduling firmware restart.
Jarek Poplawski
Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Gerrit Renker
[PATCH 28/37] dccp: Integration of dynamic feature activation - part 3 (client side)
David Miller
[GIT]: Networking
openbsd-misc
:
Colocation donated by:
Who's online
There are currently
8 users
and
872 guests
online.
Online users
kabeermasterso
howtomakeameri
lizbennet
cityescort
ComanVasile
eisogeraciul
hairsalonjacks
pimerchant
Syndicate