Re: "Fix ATAPI transfer lengths" causes CD writing regression

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Jens Axboe <jens.axboe@...>
Cc: Alan Cox <alan@...>, Daniel Drake <dsd@...>, linux list <linux-kernel@...>, <linux-ide@...>
Date: Wednesday, October 31, 2007 - 12:05 pm

Jens Axboe wrote:

You cannot hope to handle all possible effects arising from an app 
providing an invalid sg header / cdb.

Once you start talking "recovery" you are already screwed:  we are 
talking about low-level hardware commands that are passed straight to 
the hardware.  It is trivial to lock up hardware, brick hardware, and 
corrupt data at that level.


If this is NOT a privileged app, we must update the command validation 
to ensure that invalid commands are not transported to the hardware.

If this is a privileged app, our work is done.  Fix the app.  We gave 
root rope, and he took it.


I even venture to say that "accept anything, clean up afterwards" is 
/impossible/ to implement, in addition to being dangerous.

	Jeff


-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
"Fix ATAPI transfer lengths" causes CD writing regression, Daniel Drake, (Tue Oct 30, 11:14 am)
Re: "Fix ATAPI transfer lengths" causes CD writing regression, Jeff Garzik, (Wed Oct 31, 12:05 pm)