Re: [PATCH] sysfs: add filter function to groups

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

To: Cornelia Huck <cornelia.huck@...>

Cc: Greg KH <greg@...>, James Bottomley <James.Bottomley@...>, Kay Sievers <kay.sievers@...>, linux-scsi <linux-scsi@...>, linux-kernel <linux-kernel@...>

Subject: Re: [PATCH] sysfs: add filter function to groups

Date: Wednesday, October 31, 2007 - 5:52 am

Cornelia Huck wrote:
quoted text> Greg KH <greg@kroah.com> wrote:
>> On Tue, Oct 30, 2007 at 01:25:43PM -0500, James Bottomley wrote:
>>> +	for (i = 0, attr = grp->attrs; *attr; i++, attr++)
>>> +		if (grp->is_visible &&
>>> +		    grp->is_visible(kobj, *attr, i))
>>> +			sysfs_hash_and_remove(dir_sd, (*attr)->name);
>> Hm, doesn't this break for the zillions of attribute groups that do not
>> have the is_visible function set?
...
quoted text> Would it make more sense then to turn the meaning of the callback
> around?
> 
> for (...) {
> 	if (grp->mask_out && grp->mask_out(kobj, *attr, i))
> 		continue;
> 	error |= sysfs_add_file(...);
> }

		if (!grp->is_visible ||
		    grp->is_visible(kobj, *attr, i))
			add or remove();

-- 
Stefan Richter
-=====-=-=== =-=- =====
http://arcgraph.de/sr/
-
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH] sysfs: add filter function to groups, James Bottomley, (Mon Oct 29, 11:16 am)

Re: [PATCH] sysfs: add filter function to groups, Kay Sievers, (Mon Oct 29, 12:54 pm)

Re: [PATCH] sysfs: add filter function to groups, James Bottomley, (Mon Oct 29, 12:57 pm)

Re: [PATCH] sysfs: add filter function to groups, Stefan Richter, (Mon Oct 29, 1:58 pm)

Re: [PATCH] sysfs: add filter function to groups, James Bottomley, (Tue Oct 30, 2:25 pm)

Re: [PATCH] sysfs: add filter function to groups, Greg KH, (Tue Oct 30, 11:55 pm)

Re: [PATCH] sysfs: add filter function to groups, James Bottomley, (Wed Oct 31, 10:38 am)

Re: [PATCH] sysfs: add filter function to groups, Greg KH, (Wed Oct 31, 1:29 pm)

Re: [PATCH] sysfs: add filter function to groups, James Bottomley, (Sun Nov 4, 10:12 am)

Re: [PATCH] sysfs: add filter function to groups, Greg KH, (Sun Nov 4, 3:06 pm)

Re: [PATCH] sysfs: add filter function to groups, Cornelia Huck, (Wed Oct 31, 5:41 am)

Re: [PATCH] sysfs: add filter function to groups, Stefan Richter, (Wed Oct 31, 5:52 am)

Re: [PATCH] sysfs: add filter function to groups, Cornelia Huck, (Wed Oct 31, 6:20 am)

Re: [PATCH] sysfs: add filter function to groups, Stefan Richter, (Wed Oct 31, 6:37 am)

Re: [PATCH] sysfs: add filter function to groups, Cornelia Huck, (Wed Oct 31, 8:19 am)

Re: [PATCH] sysfs: add filter function to groups, Mark M. Hoffman, (Tue Oct 30, 8:40 pm)

Re: [PATCH] sysfs: add filter function to groups, Kay Sievers, (Tue Oct 30, 10:01 pm)

Re: [PATCH] sysfs: add filter function to groups, Mark M. Hoffman, (Wed Oct 31, 7:28 am)

Re: [PATCH] sysfs: add filter function to groups, Kay Sievers, (Tue Oct 30, 3:47 pm)

Re: [PATCH] sysfs: add filter function to groups, Stefan Richter, (Tue Oct 30, 3:31 pm)

Re: [PATCH] sysfs: add filter function to groups, James Bottomley, (Mon Oct 29, 2:12 pm)

Re: [PATCH] sysfs: add filter function to groups, Kay Sievers, (Mon Oct 29, 1:27 pm)

Re: [PATCH] sysfs: add filter function to groups, James Bottomley, (Mon Oct 29, 1:28 pm)

Re: [PATCH] sysfs: add filter function to groups, Kay Sievers, (Mon Oct 29, 1:43 pm)

Re: [PATCH] sysfs: add filter function to groups, Cornelia Huck, (Mon Oct 29, 1:18 pm)

Re: [PATCH] sysfs: add filter function to groups, James Bottomley, (Mon Oct 29, 1:24 pm)

Re: [PATCH] sysfs: add filter function to groups, Cornelia Huck, (Tue Oct 30, 4:55 am)

Re: [PATCH] sysfs: add filter function to groups, Jeff Garzik, (Mon Oct 29, 1:27 pm)

Re: [PATCH] sysfs: add filter function to groups, James Bottomley, (Mon Oct 29, 1:29 pm)

Re: [PATCH] sysfs: add filter function to groups, Cornelia Huck, (Tue Oct 30, 5:00 am)


linux-kernel:
Greg Kroah-Hartman	[PATCH 004/196] Chinese: add translation of SubmittingPatches
David Chinner	Re: [RFD] BIO_RW_BARRIER - what it means for devices, filesystems, and dm/md.
Andrew Morton	-mm merge plans for 2.6.23
Trent Piepho	Re: [PATCH] [POWERPC] Improve (in\|out)_beXX() asm code
git:

linux-netdev:
David Miller	Re: iptables very slow after commit784544739a25c30637397ace5489eeb6e15d7d49
Jarek Poplawski	[PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Gerrit Renker	[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
David Miller	[GIT]: Networking
openbsd-misc:

Re: [PATCH] sysfs: add filter function to groups

Online users