Re: [patch] sched: schedstat needs a diet

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Ken Chen <kenchen@...>
Cc: Mathieu Desnoyers <mathieu.desnoyers@...>, Peter Zijlstra <peterz@...>, Ingo Molnar <mingo@...>, Linux Kernel Mailing List <linux-kernel@...>
Date: Wednesday, October 31, 2007 - 5:06 am

On 10/18/07, Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca> wrote:
    > Good question indeed. How large is this memory footprint exactly ? If it
    > is as small as you say, I suspect that the real issue could be that
    > these variable are accessed by the scheduler critical paths and
    > therefore trash the caches.
    
    Maybe my wording was ambiguous, I meant to reduce cache line pollution
    when accessing these schedstat fields.

As the original author, it was always my intention that schedstats be low
enough impact that it could be turned on all the time, if need be.  That's
why, for the most part, it does increments and decrements of counters and
leaves the actual math to apps that might gather the data.  Initial
measurements showed that it was having no measurable impact on performance.

Of course, that was years ago too.  Systems (and hardware) have changed
considerably in that time.  Are we talking theoretical cache pollution
or measured?  And if measured, what effect is it having?

(sorry for the late followup; was on vacation ...)

Rick
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[patch] sched: schedstat needs a diet, Ken Chen, (Tue Oct 16, 4:37 pm)
Re: [patch] sched: schedstat needs a diet, Ingo Molnar, (Wed Oct 17, 3:23 am)
Re: [patch] sched: schedstat needs a diet, Peter Zijlstra, (Wed Oct 17, 5:29 am)
Re: [patch] sched: schedstat needs a diet, Mathieu Desnoyers, (Thu Oct 18, 6:19 pm)
Re: [patch] sched: schedstat needs a diet, Ken Chen, (Thu Oct 18, 6:57 pm)
Re: [patch] sched: schedstat needs a diet , Rick Lindsley, (Wed Oct 31, 5:06 am)
Re: [patch] sched: schedstat needs a diet, Mathieu Desnoyers, (Thu Oct 18, 7:13 pm)