Home » Mailing list archives » linux-kernel » 2007 » October » 31

Re: dev_ifname32() fails on 32->64bit calls in copy_in_user().

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Benjamin Herrenschmidt <benh@...>
To: Joel Becker <Joel.Becker@...>
Cc: Linux Netdev <netdev@...>, Linux Kernel Mailing List <Linux-Kernel@...>, Eric W. Biederman <ebiederm@...>, David S. Miller <davem@...>
Subject: Re: dev_ifname32() fails on 32-&gt;64bit calls in copy_in_user().
Date: Tuesday, October 30, 2007 - 10:35 pm

Bug is in the new dev_ifname32:

	uifr = compat_alloc_user_space(sizeof(struct ifreq));
	if (copy_in_user(uifr, compat_ptr(arg), sizeof(struct ifreq32)));
		return -EFAULT;

There's a stray ";" after the if statement, that was obviously not
tested :-)

This fixes it here (tested):
----------------------------------------------------------------------------
[PATCH] Fix new dev_ifname32 returning -EFAULT

A stray semicolon slipped in the patch that updated dev_ifname32 to
not be inline, causing it to always return -EFAULT. This fixes it.

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
---

Index: linux-work/fs/compat_ioctl.c
===================================================================
--- linux-work.orig/fs/compat_ioctl.c	2007-10-31 13:30:42.000000000 +1100
+++ linux-work/fs/compat_ioctl.c	2007-10-31 13:30:46.000000000 +1100
@@ -322,7 +322,7 @@ static int dev_ifname32(unsigned int fd,
 	int err;
 
 	uifr = compat_alloc_user_space(sizeof(struct ifreq));
-	if (copy_in_user(uifr, compat_ptr(arg), sizeof(struct ifreq32)));
+	if (copy_in_user(uifr, compat_ptr(arg), sizeof(struct ifreq32)))
 		return -EFAULT;
 
 	err = sys_ioctl(fd, SIOCGIFNAME, (unsigned long)uifr);


-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
dev_ifname32() fails on 32-&gt;64bit calls in copy_in_user()., Joel Becker, (Tue Oct 30, 8:38 pm)
Re: dev_ifname32() fails on 32->64bit calls in copy_in_user()., Benjamin Herrenschmidt, (Tue Oct 30, 10:35 pm)
Re: dev_ifname32() fails on 32-&gt;64bit calls in copy_in_user()., Eric W. Biederman, (Wed Oct 31, 4:03 am)
Re: dev_ifname32() fails on 32-&gt;64bit calls in copy_in_user()., David Miller, (Tue Oct 30, 11:41 pm)
Re: dev_ifname32() fails on 32-&gt;64bit calls in copy_in_user()., Arnd Bergmann, (Tue Oct 30, 9:12 pm)
Re: dev_ifname32() fails on 32-&gt;64bit calls in copy_in_user()., Benjamin Herrenschmidt, (Tue Oct 30, 9:06 pm)