Home » Mailing list archives » linux-kernel » 2007 » October » 30

[PATCH -rt] remove in_interrupt() BUG_ON in exit path

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Daniel Walker <dwalker@...>
To: <mingo@...>
Cc: <linux-kernel@...>, <linux-rt-users@...>, <rostedt@...>, <kraj@...>
Subject: [PATCH -rt] remove in_interrupt() BUG_ON in exit path
Date: Tuesday, October 30, 2007 - 6:40 pm

As you can see from the patch there is already a case to catch this type
of problem. This BUG_ON() adds a resursive OOPS , since BUG() causes an OOPS 
and the OOPS just calls do_exit() , and do_exit() just causes another OOPS with
this BUG_ON().. If we call panic() here then it's clear what the problem was,
instead of causing an endless recursive crash.

Signed-off-by: Daniel Walker <dwalker@mvista.com>

---
 kernel/exit.c |    1 -
 1 file changed, 1 deletion(-)

Index: linux-2.6.23.1/kernel/exit.c
===================================================================
--- linux-2.6.23.1.orig/kernel/exit.c
+++ linux-2.6.23.1/kernel/exit.c
@@ -895,7 +895,6 @@ fastcall NORET_TYPE void do_exit(long co
 
 	WARN_ON(atomic_read(&tsk->fs_excl));
 
-	BUG_ON(in_interrupt());
 	if (unlikely(in_interrupt()))
 		panic("Aiee, killing interrupt handler!");
 	if (unlikely(!tsk->pid))
-- 

-- 
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH -rt] remove in_interrupt() BUG_ON in exit path, Daniel Walker, (Tue Oct 30, 6:40 pm)
Re: [PATCH -rt] remove in_interrupt() BUG_ON in exit path, Steven Rostedt, (Tue Oct 30, 7:44 pm)
Re: [PATCH -rt] remove in_interrupt() BUG_ON in exit path, Daniel Walker, (Tue Oct 30, 7:43 pm)
Re: [PATCH -rt] remove in_interrupt() BUG_ON in exit path, Steven Rostedt, (Tue Oct 30, 7:53 pm)