login
Login
/
Register
Search
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2007
»
October
»
30
Re: [2.6 patch] fix drivers/net/wan/lmc/ compilation
view
thread
!MAILaRCHIVE_VOTE_RePLACE
Previous message: [
thread
] [
date
] [
author
]
Next message: [thread] [
date
] [
author
]
[view in full thread]
From:
Roel Kluin <12o3l@...>
To: Adrian Bunk <bunk@...>
Cc: Andrew Morton <akpm@...>, David S. Miller <davem@...>, <netdev@...>, <jgarzik@...>, <linux-kernel@...>
Subject:
Re: [2.6 patch] fix drivers/net/wan/lmc/ compilation
Date: Tuesday, October 30, 2007 - 4:45 pm
Adrian Bunk wrote:
quoted text
> Documentation/SubmitChecklist, point 1: > > <-- snip --> > > ... > CC drivers/net/wan/lmc/lmc_main.o > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/net/wan/lmc/lmc_main.c: In function ‘lmc_ioctl’: > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/net/wan/lmc/lmc_main.c:239: error: expected expression before ‘else’ > ... > make[5]: *** [drivers/net/wan/lmc/lmc_main.o] Error 1 > > <-- snip --> > > Signed-off-by: Adrian Bunk <bunk@kernel.org> > > --- > d5e92a30491abf073e0a7f4d46b466c7c97f0f61 > diff --git a/drivers/net/wan/lmc/lmc_main.c b/drivers/net/wan/lmc/lmc_main.c > index 64eb578..37c52e1 100644 > --- a/drivers/net/wan/lmc/lmc_main.c > +++ b/drivers/net/wan/lmc/lmc_main.c > @@ -234,7 +234,7 @@ int lmc_ioctl (struct net_device *dev, struct ifreq *ifr, int cmd) /*fold00*/ > sc->lmc_xinfo.Magic1 = 0xDEADBEEF; > > if (copy_to_user(ifr->ifr_data, &sc->lmc_xinfo, > - sizeof(struct lmc_xinfo))) { > + sizeof(struct lmc_xinfo))) > ret = -EFAULT; > else > ret = 0; >
I am sorry, my patch broke this and Kristov Provost also noticed this. See
http://lkml.org/lkml/2007/10/30/355
-
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [thread] [
date
] [
author
]
Messages in current thread:
[2.6 patch] fix drivers/net/wan/lmc/ compilation
, Adrian Bunk
, (Tue Oct 30, 4:31 pm)
Re: [2.6 patch] fix drivers/net/wan/lmc/ compilation
, Roel Kluin
, (Tue Oct 30, 4:45 pm)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Greg KH
[GIT PATCH] driver core patches against 2.6.24
Tarkan Erimer
Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
Hiten Pandya
Re: up? (emacs docbook xml ide)
Martin Michlmayr
Network slowdown due to CFS
git
:
linux-netdev
:
Gerrit Renker
[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
David Miller
[GIT]: Networking
Jarek Poplawski
[PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Natalie Protasevich
[BUG] New Kernel Bugs
dragonflybsd-user
:
Yaroslav Tarasenko
Re: PC-BSD
Ben Cadieux
DragonFly MBR
justin
Re: dragonfly pdf documentation
dark0s Optik
DragonFly over Sony Vaio
Colocation donated by:
Who's online
There are currently
1 user
and
938 guests
online.
Online users
cbelgrnc87x
Syndicate