Home » Mailing list archives » linux-kernel » 2007 » October » 30

checkpatch bug: space between left parenthesis and asterisk

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Timur Tabi <timur@...>
To: <apw@...>, <linux-kernel@...>
Subject: checkpatch bug: space between left parenthesis and asterisk
Date: Tuesday, October 30, 2007 - 3:27 pm

I'm running checkpatch.pl (dated 10/17), and it complains about this line:

crc = __be32_to_cpu(* ((__be32 *) ((void *) firmware + calc_size)));

the message I get is:

ERROR: need space before that '*' (ctx:BxW)
#721: FILE: arch/powerpc/sysdev/qe_lib/qe.c:527:
+       crc = __be32_to_cpu(* ((__be32 *) ((void *) firmware + calc_size)));
                             ^

so I add a space, and now I get this:

ERROR: no space after that open parenthesis '('
#721: FILE: arch/powerpc/sysdev/qe_lib/qe.c:527:
+       crc = __be32_to_cpu( * ((__be32 *) ((void *) firmware + calc_size)));

-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
checkpatch bug: space between left parenthesis and asterisk, Timur Tabi, (Tue Oct 30, 3:27 pm)
Re: checkpatch bug: space between left parenthesis and aster..., Andy Whitcroft, (Tue Oct 30, 5:46 pm)
Re: checkpatch bug: space between left parenthesis and aster..., Zach Brown, (Tue Oct 30, 3:54 pm)
Re: checkpatch bug: space between left parenthesis and aster..., Timur Tabi, (Tue Oct 30, 4:02 pm)