Re: [RFC] Create kinst/ or ki/ directory ?

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Mathieu Desnoyers <mathieu.desnoyers@...>
Cc: Jeff Garzik <jeff@...>, Randy Dunlap <rdunlap@...>, <hch@...>, <linux-kernel@...>, Sam Ravnborg <sam@...>, Jens Axboe <jens.axboe@...>, Prasanna S Panchamukhi <prasanna@...>, Ananth N Mavinakayanahalli <ananth@...>, Anil S Keshavamurthy <anil.s.keshavamurthy@...>, David S. Miller <davem@...>, Ingo Molnar <mingo@...>, Peter Zijlstra <pzijlstr@...>, Philippe Elie <phil.el@...>, William L. Irwin <wli@...>, Arjan van de Ven <arjan@...>, Christoph Lameter <christoph@...>, <Valdis.Kletnieks@...>
Date: Tuesday, October 30, 2007 - 1:50 pm

On Tue, 30 Oct 2007, Mathieu Desnoyers wrote:

No, that's horrible.

Also, in general, why do people want to have an "instrumentation" thing? 
Yes, you can put random things into the same box, but that doesn't make 
them be the same thing. Personally, I don't think "instrumentation" is 
very useful at all. I consider "profiling" and "markers" to be two 
fundamentally different things, and putting them both in the same box does 
not make them any more similar. 

Yes, technically they are both "instrumentation", but hey, technically the 
VM and the VFS layer are both "infrastructure", but we don't put *those* 
in a "infrastructure" subdirectory.

In other words, the fact that two different things share some attribute 
does not mean that they should be collapsed together by that attribute, 
does it?

I think "instrumentation" was/is a particularly bad thing to group things 
by. It doesn't actually tell you anything about the thing, and it's not 
even true that some people are interested in "instrumentation"  and others 
aren't. 

For example: I think profiling support is something REALLY FUNDAMENTAL. 
It's something each and every developer should generally care about, and 
OProfile should be considered an indispensable tool for any developer, on 
par with something like gdb.

In contrast, we should *not* expect most people to do any kernel markers 
etc. That's a very esoteric thing.

So I actually think that the current Kconfig.instrumentation should be 
*removed*. Rather than adding more groupings based on that fundamentally 
flawed premise of false commonality.

		Linus
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[RFC] Create instrumentation directory (git repository), Mathieu Desnoyers, (Mon Oct 29, 5:51 pm)
Re: [RFC] Create instrumentation directory (git repository), Christoph Lameter, (Mon Oct 29, 7:20 pm)
Re: [RFC] Create instrumentation directory (git repository), Mathieu Desnoyers, (Mon Oct 29, 7:40 pm)
Re: [RFC] Create instrumentation directory (git repository), Christoph Lameter, (Mon Oct 29, 7:45 pm)
Re: [RFC] Create instrumentation directory (git repository), Mathieu Desnoyers, (Mon Oct 29, 7:04 pm)
Re: [RFC] Create kinst/ or ki/ directory ?, Mathieu Desnoyers, (Tue Oct 30, 1:24 pm)
Re: [RFC] Create kinst/ or ki/ directory ?, Linus Torvalds, (Tue Oct 30, 1:50 pm)
Re: [RFC] Create kinst/ or ki/ directory ?, Mathieu Desnoyers, (Tue Oct 30, 2:56 pm)
Re: [RFC] Create kinst/ or ki/ directory ?, Sam Ravnborg, (Tue Oct 30, 5:46 pm)
Re: [RFC] Create kinst/ or ki/ directory ?, Linus Torvalds, (Tue Oct 30, 3:25 pm)
Re: [RFC] Create kinst/ or ki/ directory ?, Mathieu Desnoyers, (Tue Oct 30, 4:40 pm)
Re: [RFC] Create kinst/ or ki/ directory ?, Frank Ch. Eigler, (Wed Oct 31, 11:48 am)
Re: [RFC] Create kinst/ or ki/ directory ?, Mathieu Desnoyers, (Wed Oct 31, 12:36 pm)
Re: [RFC] Create kinst/ or ki/ directory ?, Frank Ch. Eigler, (Wed Oct 31, 3:29 pm)
Re: [RFC] Create kinst/ or ki/ directory ?, Arjan van de Ven, (Wed Oct 31, 12:29 pm)
Re: [RFC] Create kinst/ or ki/ directory ?, Frank Ch. Eigler, (Wed Oct 31, 3:05 pm)
Re: [RFC] Create kinst/ or ki/ directory ?, Arjan van de Ven, (Wed Oct 31, 3:49 pm)
Re: [RFC] Create kinst/ or ki/ directory ?, Christoph Hellwig, (Tue Oct 30, 1:58 pm)
Re: [RFC] Create kinst/ or ki/ directory ?, Peter Zijlstra, (Tue Oct 30, 1:49 pm)
Re: [RFC] Create instrumentation directory (git repository), Mathieu Desnoyers, (Mon Oct 29, 7:35 pm)
Re: [RFC] Create instrumentation directory (git repository), Mathieu Desnoyers, (Mon Oct 29, 9:38 pm)
Re: [RFC] Create instrumentation directory (git repository), Arnaldo Carvalho de Melo, (Tue Oct 30, 5:13 am)