[PATCH] drivers/scsi/lpfc/lpfc_hw.h: Some minor cleanup.

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Richard Knutsson
Date: Tuesday, October 30, 2007 - 3:54 am

Signed-off-by: Richard Knutsson <ricknu-0@student.ltu.se>
---
Diffed against linus-git
Checked with script/checkpatch.pl


diff --git a/drivers/scsi/lpfc/lpfc_hw.h b/drivers/scsi/lpfc/lpfc_hw.h
index 451accd..6f56528 100644
--- a/drivers/scsi/lpfc/lpfc_hw.h
+++ b/drivers/scsi/lpfc/lpfc_hw.h
@@ -3158,31 +3158,30 @@ struct lpfc_sli2_slim {
  *
  * Parameters:
  * device : struct pci_dev 's device field
- *
- * return 1 => TRUE
- *        0 => FALSE
  */
-static inline int
+static inline bool
 lpfc_is_LC_HBA(unsigned short device)
 {
-	if ((device == PCI_DEVICE_ID_TFLY) ||
-	    (device == PCI_DEVICE_ID_PFLY) ||
-	    (device == PCI_DEVICE_ID_LP101) ||
-	    (device == PCI_DEVICE_ID_BMID) ||
-	    (device == PCI_DEVICE_ID_BSMB) ||
-	    (device == PCI_DEVICE_ID_ZMID) ||
-	    (device == PCI_DEVICE_ID_ZSMB) ||
-	    (device == PCI_DEVICE_ID_RFLY))
-		return 1;
-	else
-		return 0;
+	switch (device) {
+	case PCI_DEVICE_ID_TFLY:
+	case PCI_DEVICE_ID_PFLY:
+	case PCI_DEVICE_ID_LP101:
+	case PCI_DEVICE_ID_BMID:
+	case PCI_DEVICE_ID_BSMB:
+	case PCI_DEVICE_ID_ZMID:
+	case PCI_DEVICE_ID_ZSMB:
+	case PCI_DEVICE_ID_RFLY:
+		return true;
+	}
+
+	return false;
 }
 
 /*
  * Determine if an IOCB failed because of a link event or firmware reset.
  */
 
-static inline int
+static inline bool
 lpfc_error_lost_link(IOCB_t *iocbp)
 {
 	return (iocbp->ulpStatus == IOSTAT_LOCAL_REJECT &&
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] drivers/scsi/lpfc/lpfc_hw.h: Some minor cleanup., Richard Knutsson, (Tue Oct 30, 3:54 am)
Re: [PATCH] drivers/scsi/lpfc/lpfc_hw.h: Some minor cleanup., Richard Knutsson, (Tue Oct 30, 9:41 am)