login
Login
/
Register
Search
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2007
»
October
»
3
Re: [PATCH] net: fix race in process_backlog
view
thread
!MAILaRCHIVE_VOTE_RePLACE
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From:
David Miller <davem@...>
To: <a.p.zijlstra@...>
Cc: <linux-kernel@...>, <netdev@...>, <shemminger@...>, <jdike@...>
Subject:
Re: [PATCH] net: fix race in process_backlog
Date: Wednesday, October 3, 2007 - 5:58 pm
From: Peter Zijlstra <a.p.zijlstra@chello.nl> Date: Wed, 03 Oct 2007 17:44:53 +0200
quoted text
> Index: linux-2.6/net/core/dev.c > =================================================================== > --- linux-2.6.orig/net/core/dev.c > +++ linux-2.6/net/core/dev.c > @@ -2095,11 +2095,11 @@ static int process_backlog(struct napi_s > > local_irq_disable(); > skb = __skb_dequeue(&queue->input_pkt_queue); > - local_irq_enable(); > if (!skb) { > - napi_complete(napi); > + __napi_complete(napi); > break; > } > + local_irq_enable();
What re-enables interrupts in the !skb path? -
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
[PATCH] net: fix race in process_backlog
, Peter Zijlstra
, (Wed Oct 3, 11:44 am)
Re: [PATCH] net: fix race in process_backlog
, David Miller
, (Wed Oct 3, 5:58 pm)
Re: [PATCH] net: fix race in process_backlog
, Stephen Hemminger
, (Wed Oct 3, 6:05 pm)
Re: [PATCH] net: fix race in process_backlog
, David Miller
, (Wed Oct 3, 7:39 pm)
Re: [PATCH] net: fix race in process_backlog
, Stephen Hemminger
, (Wed Oct 3, 12:15 pm)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Sunil Naidu
Re: Linux 2.6.20-rc6
Alan Cox
Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
Chris Snook
Re: init's children list is long and slows reaping children.
Greg Kroah-Hartman
[PATCH 001/196] Chinese: Add the known_regression URI to the HOWTO
git
:
openbsd-misc
:
linux-netdev
:
Jarek Poplawski
[PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
David Miller
[GIT]: Networking
Gerrit Renker
[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
Eric W. Biederman
Re: [PATCH 10/11] avoid kobject name conflict with different namespaces
Colocation donated by:
Who's online
There are currently
1 user
and
888 guests
online.
Online users
strcmp
Syndicate