Home » Mailing list archives » linux-kernel » 2007 » October » 3

Re: MSI: Use correct data offset for 32-bit MSI in read_msi_msg()

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Roland Dreier <rdreier@...>
To: Eric W. Biederman <ebiederm@...>
Cc: Roland Dreier <roland@...>, Greg KH <greg@...>, <linux-pci@...>, <linux-kernel@...>
Subject: Re: MSI: Use correct data offset for 32-bit MSI in read_msi_msg()
Date: Wednesday, October 3, 2007 - 4:03 pm

> Well it is a bug worth fixing.  Who knows it may have something
 > to do with the disable_irq problems the forcedeth driver was seeing.

I agree completely, the fix looks obvious and there's no point in
leaving the bug there.  I just don't have a test case that I can point
to as being fixed by this, since I don't have a working 32-bit MSI
device...

Do you know whether the forcedeth devices have a 32-bit MSI address?

 - R.
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
Re: MSI: Use correct data offset for 32-bit MSI in read_msi_..., Eric W. Biederman, (Wed Oct 3, 2:25 pm)
Re: MSI: Use correct data offset for 32-bit MSI in read_msi_..., Roland Dreier, (Wed Oct 3, 3:13 pm)
Re: MSI: Use correct data offset for 32-bit MSI in read_msi_..., Eric W. Biederman, (Wed Oct 3, 3:55 pm)
Re: MSI: Use correct data offset for 32-bit MSI in read_msi_..., Roland Dreier, (Wed Oct 3, 4:03 pm)
Re: MSI: Use correct data offset for 32-bit MSI in read_msi_..., Eric W. Biederman, (Wed Oct 3, 4:34 pm)