Re: [PATCH 5/5] lguest: loading bzImage directly

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Chris Malley
Date: Wednesday, October 3, 2007 - 2:37 am

Hi guys

Would it not be clearer to #include <asm/bootparam.h> and use 
the relevant named members of struct setup_header / struct boot_params
rather than the hard-coded values 0x202, 0x1F1, 0x214 ?

--
Chris


On Wed, 2007-10-03 at 09:40 +1000, Rusty Russell wrote:
[snip]


-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 0/5] Boot protocol changes, Rusty Russell, (Tue Oct 2, 4:34 pm)
[PATCH 1/5] update boot spec to 2.07, Rusty Russell, (Tue Oct 2, 4:35 pm)
[PATCH 2/5] add WEAK() for creating weak asm labels, Rusty Russell, (Tue Oct 2, 4:35 pm)
[PATCH 3/5] i386: paravirt boot sequence, Rusty Russell, (Tue Oct 2, 4:36 pm)
[PATCH 4/5] Revert lguest magic and use hook in head.S, Rusty Russell, (Tue Oct 2, 4:39 pm)
[PATCH 5/5] lguest: loading bzImage directly, Rusty Russell, (Tue Oct 2, 4:40 pm)
Re: [PATCH 0/5] Boot protocol changes, H. Peter Anvin, (Tue Oct 2, 4:44 pm)
Re: [PATCH 0/5] Boot protocol changes, Jeremy Fitzhardinge, (Tue Oct 2, 4:46 pm)
Re: [PATCH 0/5] Boot protocol changes, H. Peter Anvin, (Tue Oct 2, 4:53 pm)
Re: [PATCH 0/5] Boot protocol changes, Jeremy Fitzhardinge, (Tue Oct 2, 4:56 pm)
Re: [PATCH 0/5] Boot protocol changes, H. Peter Anvin, (Tue Oct 2, 5:43 pm)
Re: [PATCH 0/5] Boot protocol changes, H. Peter Anvin, (Tue Oct 2, 5:46 pm)
Re: [PATCH 0/5] Boot protocol changes, Jeremy Fitzhardinge, (Tue Oct 2, 5:58 pm)
Re: [PATCH 0/5] Boot protocol changes, H. Peter Anvin, (Tue Oct 2, 6:03 pm)
Re: [PATCH 5/5] lguest: loading bzImage directly, Chris Malley, (Wed Oct 3, 2:37 am)
Re: [PATCH 5/5] lguest: loading bzImage directly, H. Peter Anvin, (Wed Oct 3, 10:12 am)
Re: [PATCH 5/5] lguest: loading bzImage directly, Rusty Russell, (Wed Oct 3, 5:02 pm)
Re: [PATCH 5/5] lguest: loading bzImage directly, H. Peter Anvin, (Wed Oct 3, 5:26 pm)
Re: [PATCH 1/5] update boot spec to 2.07, rae l, (Mon Oct 29, 11:38 pm)
Re: [PATCH 5/5] lguest: loading bzImage directly, Kjartan Maraas, (Sat Nov 24, 2:54 pm)
Re: [PATCH 5/5] lguest: loading bzImage directly, H. Peter Anvin, (Sat Nov 24, 3:14 pm)
Re: [PATCH 5/5] lguest: loading bzImage directly, Kjartan Maraas, (Sun Nov 25, 5:32 am)