login
Login
/
Register
Search
Search this site:
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2007
»
October
»
3
Re: [PATCH] sky2: jumbo frame regression fix
view
thread
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From: Stephen Hemminger
Subject:
Re: [PATCH] sky2: jumbo frame regression fix
Date: Tuesday, October 2, 2007 - 9:53 pm
On Tue, 02 Oct 2007 21:07:22 -0400 Jeff Garzik <jgarzik@pobox.com> wrote:
quoted text
> Stephen Hemminger wrote: > > Remove unneeded check that caused problems with jumbo frame sizes. > > The check was recently added and is wrong. > > When using jumbo frames the sky2 driver does fragmentation, so > > rx_data_size is less than mtu. > > > > Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org> > > > > --- a/drivers/net/sky2.c 2007-10-02 17:56:31.000000000 -0700 > > +++ b/drivers/net/sky2.c 2007-10-02 17:58:56.000000000 -0700 > > @@ -2163,9 +2163,6 @@ static struct sk_buff *sky2_receive(stru > > sky2->rx_next = (sky2->rx_next + 1) % sky2->rx_pending; > > prefetch(sky2->rx_ring + sky2->rx_next); > > > > - if (length < ETH_ZLEN || length > sky2->rx_data_size) > > - goto len_error; > > - > > 2.6.23? 2.6.24? enquiring minds want to know...
2.6.23, since it is a regression -- Stephen Hemminger <shemminger@linux-foundation.org> -
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
[BUG] sky2 errors in 2.6.23-rc9-git1
, Ian Kumlien
, (Tue Oct 2, 5:42 pm)
[PATCH] sky2: jumbo frame regression fix
, Stephen Hemminger
, (Tue Oct 2, 6:02 pm)
Re: [PATCH] sky2: jumbo frame regression fix
, Jeff Garzik
, (Tue Oct 2, 6:07 pm)
Re: [PATCH] sky2: jumbo frame regression fix
, Ian Kumlien
, (Tue Oct 2, 6:34 pm)
Re: [PATCH] sky2: jumbo frame regression fix
, Stephen Hemminger
, (Tue Oct 2, 9:53 pm)
Re: [PATCH] sky2: jumbo frame regression fix
, Jeff Garzik
, (Tue Oct 2, 9:58 pm)
Re: [PATCH] sky2: jumbo frame regression fix
, Stephen Hemminger
, (Tue Oct 2, 9:59 pm)
Re: [PATCH] sky2: jumbo frame regression fix
, Ian Kumlien
, (Wed Oct 3, 12:37 am)
Re: [PATCH] sky2: jumbo frame regression fix
, iank
, (Wed Oct 3, 1:29 am)
Re: [PATCH] sky2: jumbo frame regression fix
, Jeff Garzik
, (Wed Oct 3, 10:39 am)
Re: [PATCH] sky2: jumbo frame regression fix
, Bill Davidsen
, (Wed Oct 3, 11:04 am)
Re: [PATCH] sky2: jumbo frame regression fix
, Ian Kumlien
, (Wed Oct 3, 11:28 am)
[SKY2] Problems (2.6.24-rc3-git1)
, Ian Kumlien
, (Tue Nov 27, 3:40 pm)
Re: [SKY2] Problems (2.6.24-rc3-git1)
, Stephen Hemminger
, (Tue Nov 27, 3:57 pm)
[SKY2] Problems (2.6.24-rc3-git1)
, Ian Kumlien
, (Tue Nov 27, 4:07 pm)
Navigation
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Fortier,Vincent [Montreal]
2.6.21.5 june 30th to july 1st date hang?
Jeff Dike
[ PATCH 2/6 ] UML - Formatting fixes around os_{read_write}_file callers
Liam Girdwood
[PATCH 07/13] regulator: regulator test harness
Oleg Nesterov
Re: Getting the new RxRPC patches upstream
Stefan Seyfried
Re: 2.6.19-rc5: grub is much slower resuming from suspend-to-disk than in 2.6.18
linux-netdev
:
Arnaud Ebalard
Re: [REGRESSION,BISECTED] MIPv6 support broken by f4f914b58019f0
Jan Engelhardt
Re: [PATCH iptables] extension: add xt_cpu match
Jarek Poplawski
Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Sebastian Andrzej Siewior
[PATCH 8/8] net/emergency: remove locking from reycling pool if emergncy pools are...
David Miller
Re: [PATCH] qlcnic: dont assume NET_IP_ALIGN is 2
git
:
Jakub Narebski
Re: git on MacOSX and files with decomposed utf-8 file names
Brandon Casey
Re: Thunderbird and patches (was Re: [PATCH v2] Enable setting attach as the def...
Christian Couder
[PATCH 1/3] rev-parse: add test script for "--verify"
Ramkumar Ramachandra
Re: [GSoC update] git-remote-svn: The final one
Junio C Hamano
Re: git-rm isn't the inverse action of git-add
openbsd-misc
:
Joachim Schipper
Re: UVC Webcams
Florin Andrei
SOLVED [was: firewall is very slow, something's wrong]
Todd Alan Smith
Re: Microsoft gets the Most Secure Operating Systems award
Neal Hogan
Re: Need Advice: Thinkpad T60 or T61?
Sam Fourman Jr.
Re: Real men don't attack straw men
git-commits-head
:
Linux Kernel Mailing List
ACPI: Disable ARB_DISABLE on platforms where it is not needed
Linux Kernel Mailing List
m68knommu: add read_barrier_depends() and irqs_disabled_flags()
Linux Kernel Mailing List
[MTD] Add mtd panic_write function pointer
Linux Kernel Mailing List
[ARM] pxa: remove duplicate select statements from Kconfig
Linux Kernel Mailing List
mlx4_core: Don't read reserved fields in mlx4_QUERY_ADAPTER()
Colocation donated by:
Syndicate