login
Login
/
Register
Search
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2007
»
October
»
3
Re: [PATCH] sky2: jumbo frame regression fix
view
thread
!MAILaRCHIVE_VOTE_RePLACE
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From:
Stephen Hemminger <shemminger@...>
To: Jeff Garzik <jgarzik@...>
Cc: <pomac@...>, <Linux-kernel@...>, <netdev@...>
Subject:
Re: [PATCH] sky2: jumbo frame regression fix
Date: Wednesday, October 3, 2007 - 12:53 am
On Tue, 02 Oct 2007 21:07:22 -0400 Jeff Garzik <jgarzik@pobox.com> wrote:
quoted text
> Stephen Hemminger wrote: > > Remove unneeded check that caused problems with jumbo frame sizes. > > The check was recently added and is wrong. > > When using jumbo frames the sky2 driver does fragmentation, so > > rx_data_size is less than mtu. > > > > Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org> > > > > --- a/drivers/net/sky2.c 2007-10-02 17:56:31.000000000 -0700 > > +++ b/drivers/net/sky2.c 2007-10-02 17:58:56.000000000 -0700 > > @@ -2163,9 +2163,6 @@ static struct sk_buff *sky2_receive(stru > > sky2->rx_next = (sky2->rx_next + 1) % sky2->rx_pending; > > prefetch(sky2->rx_ring + sky2->rx_next); > > > > - if (length < ETH_ZLEN || length > sky2->rx_data_size) > > - goto len_error; > > - > > 2.6.23? 2.6.24? enquiring minds want to know...
2.6.23, since it is a regression -- Stephen Hemminger <shemminger@linux-foundation.org> -
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
[BUG] sky2 errors in 2.6.23-rc9-git1
, Ian Kumlien
, (Tue Oct 2, 8:42 pm)
[PATCH] sky2: jumbo frame regression fix
, Stephen Hemminger
, (Tue Oct 2, 9:02 pm)
Re: [PATCH] sky2: jumbo frame regression fix
, Jeff Garzik
, (Wed Oct 3, 1:39 pm)
Re: [PATCH] sky2: jumbo frame regression fix
, Ian Kumlien
, (Tue Oct 2, 9:34 pm)
Re: [PATCH] sky2: jumbo frame regression fix
, Bill Davidsen
, (Wed Oct 3, 2:04 pm)
Re: [PATCH] sky2: jumbo frame regression fix
, Ian Kumlien
, (Wed Oct 3, 2:28 pm)
Re: [PATCH] sky2: jumbo frame regression fix
, Stephen Hemminger
, (Wed Oct 3, 12:59 am)
[SKY2] Problems (2.6.24-rc3-git1)
, Ian Kumlien
, (Tue Nov 27, 7:07 pm)
[SKY2] Problems (2.6.24-rc3-git1)
, Ian Kumlien
, (Tue Nov 27, 6:40 pm)
Re: [SKY2] Problems (2.6.24-rc3-git1)
, Stephen Hemminger
, (Tue Nov 27, 6:57 pm)
Re: [PATCH] sky2: jumbo frame regression fix
,
, (Wed Oct 3, 4:29 am)
Re: [PATCH] sky2: jumbo frame regression fix
, Ian Kumlien
, (Wed Oct 3, 3:37 am)
Re: [PATCH] sky2: jumbo frame regression fix
, Jeff Garzik
, (Tue Oct 2, 9:07 pm)
Re: [PATCH] sky2: jumbo frame regression fix
, Stephen Hemminger
, (Wed Oct 3, 12:53 am)
Re: [PATCH] sky2: jumbo frame regression fix
, Jeff Garzik
, (Wed Oct 3, 12:58 am)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Ingo Molnar
[announce] "kill the Big Kernel Lock (BKL)" tree
Greg KH
[GIT PATCH] driver core patches against 2.6.24
Emmanuel Florac
RAID-1 performance under 2.4 and 2.6
Con Kolivas
Re: -mm merge plans for 2.6.23
git
:
openbsd-misc
:
linux-netdev
:
Gerrit Renker
[PATCH 0/37] dccp: Feature negotiation - last call for comments
David Miller
[GIT]: Networking
Eric W. Biederman
Re: 2.6.24-rc3: find complains about /proc/net
David Miller
Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Colocation donated by:
Who's online
There are currently
2 users
and
1188 guests
online.
Online users
sandywhite
gustavo.serra
Syndicate