linux-kernel mailing list

FromSubjectsort iconDate
Jan Blunck
[PATCH 3/7] d_path: Use struct path in struct avc_audit_data
audit_log_d_path() is a d_path() wrapper that is used by the audit code. To use a struct path in audit_log_d_path() I need to embed it into struct avc_audit_data. Signed-off-by: Jan Blunck <jblunck@suse.de> --- include/linux/audit.h | 5 ++--- kernel/audit.c | 12 ++++++------ kernel/auditsc.c | 28 +++++++++++----------------- security/selinux/avc.c | 13 ++++++++----- security/selinux/hooks.c | 28 ++++++++++++---------------...
Oct 29, 8:41 am 2007
Jan Blunck
[PATCH 7/7] Use struct path in struct svc_export
I'm embedding struct path into struct svc_export. Signed-off-by: Jan Blunck <jblunck@suse.de> --- fs/nfsd/export.c | 69 +++++++++++++++++++++----------------------- fs/nfsd/nfs3proc.c | 2 - fs/nfsd/nfs3xdr.c | 4 +- fs/nfsd/nfs4proc.c | 4 +- fs/nfsd/nfs4xdr.c | 12 +++---- fs/nfsd/nfsfh.c | 26 ++++++++-------- fs/nfsd/nfsproc.c | 6 +-- fs/nfsd/nfsxdr.c | 2 - fs/nfsd/vfs.c ...
Oct 29, 8:41 am 2007
Jan Blunck
[PATCH 4/7] d_path: Make proc_get_link() use a struct path a...
proc_get_link() is always called with a dentry and a vfsmount from a struct path. Make proc_get_link() take it directly as an argument. Signed-off-by: Jan Blunck <jblunck@suse.de> --- fs/proc/base.c | 60 ++++++++++++++++++++---------------------------- fs/proc/internal.h | 2 - fs/proc/task_mmu.c | 6 ++-- fs/proc/task_nommu.c | 6 ++-- include/linux/proc_fs.h | 2 - 5 files changed, 34 insertions(+), 42 deletions(-) Index: b/fs/proc/base.c ========...
Oct 29, 8:41 am 2007
Jan Blunck
[PATCH 5/7] d_path: Make get_dcookie() use a struct path arg...
get_dcookie() is always called with a dentry and a vfsmount from a struct path. Make get_dcookie() take it directly as an argument. Signed-off-by: Jan Blunck <jblunck@suse.de> --- arch/powerpc/oprofile/cell/spu_task_sync.c | 15 +++++--------- drivers/oprofile/buffer_sync.c | 21 ++++++++----------- fs/dcookies.c | 31 ++++++++++++----------------- include/linux/dcookies.h | 15 ++++++-------- 4 files changed, 35 insertions(...
Oct 29, 8:41 am 2007
Jan Blunck
[PATCH 6/7] d_path: Make d_path() use a struct path
d_path() is used on a <dentry,vfsmount> pair. Lets use a struct path to reflect this. Signed-off-by: Jan Blunck <jblunck@suse.de> --- drivers/md/bitmap.c | 8 +------- drivers/usb/gadget/file_storage.c | 3 +-- fs/compat_ioctl.c | 2 +- fs/dcache.c | 12 +++++------- fs/dcookies.c | 2 +- fs/ecryptfs/super.c | 5 ++--- fs/nfsd/export.c | 3 ++- fs/proc/base.c ...
Oct 29, 8:41 am 2007
Jan Blunck
[PATCH 0/7] struct path related cleanups of d_path() code
Here are some more struct path cleanups. This patch series changes d_path() to take a struct path argument. The existing users are changed to give struct path more deeply into the call chain. In some structures I need to replace existing <dentry,vfsmount> pairs and embed a struct path instead. Andreas, since JJ just posted the AppArmor related d_path() patches I don't include them here too. Comments? Use struct path in struct svc_export -- -
Oct 29, 8:41 am 2007
Jan Blunck
[PATCH 1/7] One less parameter to __d_path
All callers to __d_path pass the dentry and vfsmount of a struct path to __d_path. Pass the struct path directly, instead. Signed-off-by: Andreas Gruenbacher <agruen@suse.de> Signed-off-by: Jan Blunck <jblunck@suse.de> --- fs/dcache.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) Index: b/fs/dcache.c =================================================================== --- a/fs/dcache.c +++ b/fs/dcache.c @@ -1778,9 +1778,8 @@ shouldnt_be_hashed: * * "bu...
Oct 29, 8:41 am 2007
Jan Blunck
[PATCH 2/7] d_path: kerneldoc cleanup
Move and update d_path() kernel API documentation. Signed-off-by: Jan Blunck <jblunck@suse.de> --- fs/dcache.c | 35 ++++++++++++++++------------------- 1 file changed, 16 insertions(+), 19 deletions(-) Index: b/fs/dcache.c =================================================================== --- a/fs/dcache.c +++ b/fs/dcache.c @@ -1762,22 +1762,6 @@ shouldnt_be_hashed: goto shouldnt_be_hashed; } -/** - * d_path - return the path of a dentry - * @dentry: dentry to report - * ...
Oct 29, 8:41 am 2007
Thomas Gleixner
[Git pull] x86 update
Linus, please pull from: ssh://master.kernel.org/pub/scm/linux/kernel/git/x86/linux-2.6-x86.git a couple of cleanups and bugfixes along with a compile/runtime irrelevant doc change. The iommu.h -> gart.h rename needs to go in before we have the namespace polution all over the place. Thanks, tglx Adrian Bunk (4): x86: kernel/setup_32.c: unexport machine_id x86: mm/discontig_32.c: make code static x86: merge EARLY_PRINTK options remove the dead X86_REMO...
Oct 29, 7:48 pm 2007
Dave Jones
32bit builds on x86-64 host.
Before the arch merge, I frequently would test 32bit compiles by doing make ARCH=i386 {bzImage/modules/file.o} Since commit 47572387d58a9584c60ebbbdee56fc92c627f16f how does one do this? Dave -- http://www.codemonkey.org.uk -
Oct 29, 7:32 pm 2007
Randy Dunlap
[PATCH] bttv: uses input functions, should depend on INPUT
From: Randy Dunlap <randy.dunlap@oracle.com> Several media drivers use input_(*) functions so they need to depend on the INPUT config symbol. drivers/built-in.o: In function `bttv_input_fini': linux-2.6.24-rc1-git4/drivers/media/video/bt8xx/bttv-input.c:346: undefined reference to `input_unregister_device' drivers/built-in.o: In function `bttv_input_init': linux-2.6.24-rc1-git4/drivers/media/video/bt8xx/bttv-input.c:204: undefined reference to `input_allocate_device' linux-2.6.24-rc1-git4/d...
Oct 29, 2:19 pm 2007
Emil Medve
[PATCH resend] Make the dev_*() family of macros in device.h...
Removed duplicates defined elsewhere Signed-off-by: Emil Medve <Emilian.Medve@Freescale.com> --- Reseding the patch to a larger audience The macros are defined in the relative order KERN_* are defined in kernel.h linux-2.6> scripts/checkpatch.pl 0001-Make-the-dev_-family-of-macros-in-device.h-comple.patch Your patch has no obvious style problems and is ready for submission. drivers/i2c/chips/isp1301_omap.c | 6 ------ drivers/isdn/gigaset/gigaset.h | 6 ------ include/l...
Oct 29, 6:43 pm 2007
Tilman Schmidt
Re: [PATCH resend] Make the dev_*() family of macros in devi...
Acked-by: Tilman Schmidt <tilman@imap.cc> utters --=20 Tilman Schmidt E-Mail: tilman@imap.cc Bonn, Germany Diese Nachricht besteht zu 100% aus wiederverwerteten Bits. Unge=F6ffnet mindestens haltbar bis: (siehe R=FCckseite)
Oct 29, 7:08 pm 2007
Dave Jones
Remove more bogus filenames in comments.
Signed-off-by: Dave Jones <davej@redhat.com> diff --git a/include/asm-x86/acpi_32.h b/include/asm-x86/acpi_32.h index 723493e..4f8730e 100644 --- a/include/asm-x86/acpi_32.h +++ b/include/asm-x86/acpi_32.h @@ -1,9 +1,7 @@ /* - * asm-i386/acpi.h - * * Copyright (C) 2001 Paul Diefenbaugh <paul.s.diefenbaugh@intel.com> * Copyright (C) 2001 Patrick Mochel <mochel@osdl.org> - * + * * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ * * ...
Oct 29, 6:49 pm 2007
Thomas Gleixner Oct 29, 7:03 pm 2007
Dave Jones
FEC kconfig warnings.
make defconfig on x86-64 prints this for me .. drivers/net/Kconfig:1887:warning: 'select' used by config symbol 'FEC_MPC52xx' refers to undefined symbol 'PPC_BESTCOMM' drivers/net/Kconfig:1888:warning: 'select' used by config symbol 'FEC_MPC52xx' refers to undefined symbol 'PPC_BESTCOMM_FEC' I'm not sure why those selects are even being evaluated, as both those options have 'depends on PPC_MPC52xx' Dave -- http://www.codemonkey.org.uk -
Oct 29, 6:44 pm 2007
CIJOML
Re: Phis in /proc/bus/input/devices same for all devices?
Hi Dmitri, I watched at 2.6.23 and this is still not done yet. Are there any patches available to use??? Thanks a lot for reply Michal -
Oct 29, 6:29 pm 2007
Marcin Ślusarz
usbserial.ko/option.ko on 2.6.23: Unable to handle kernel pa...
Hi While fighting with Option Globesurfer ICON USB modem I got oops and lockdep warning: (on rmmod option usbserial, not reproducible) usbcore: deregistering interface driver option drivers/usb/serial/usb-serial.c: USB Serial deregistering driver GSM modem (1-port) option1 ttyUSB3: GSM modem (1-port) converter now disconnected from ttyUSB3 option1 ttyUSB2: GSM modem (1-port) converter now disconnected from ttyUSB2 option1 ttyUSB1: GSM modem (1-port) converter now disconnected from ttyUSB1 opti...
Oct 29, 6:26 pm 2007
Randy Dunlap
[PATCH] watchdog: fix iTCO section warning
From: Randy Dunlap <randy.dunlap@oracle.com> Make iTCO_wdt_probe() be __devinit. Fixes these section warnings: WARNING: vmlinux.o(.text+0x17d8a8): Section mismatch: reference to .init.data: (between 'iTCO_wdt_probe' and 'supermicro_new_unlock_watchdog') WARNING: vmlinux.o(.text+0x17d97e): Section mismatch: reference to .init.data: (between 'iTCO_wdt_probe' and 'supermicro_new_unlock_watchdog') WARNING: vmlinux.o(.text+0x17d989): Section mismatch: reference to .init.data:iTCO_chipset_info (bet...
Oct 29, 2:19 pm 2007
Glauber de Oliveira ...
[PATCH] raise tsc clocksource rating
From: Glauber de Oliveira Costa <glauber@t60.localdomain> tsc is very good time source (when it does not have drifts, does not change it's frequency, i.e. when it works), so it should have its rating raised to a value greater than, or equal 400. Since it's being a tendency among paravirt clocksources to use values around 400, we should declare tsc as even better: So we use 500. This patch also touches the comments on clocksource.h, which suggests that 499 would be a limit on the rating va...
Oct 29, 7:10 pm 2007
Zachary Amsden
Re: [PATCH] raise tsc clocksource rating
Why is the TSC better than a paravirt clocksource? In our case this is definitely inaccurate. Paravirt clocksources should be preferred to TSC, and both must be made available in hardware for platforms which do not support paravirt. Also, please cc all the paravirt developers on things related to paravirt, especially things with such broad effect. I think 400 is a good value for a perfect native clocksource. >400 should be reserved for super-real (i.e. paravirt) sources that should always ...
Oct 29, 6:42 pm 2007
Ingo Molnar
Re: [PATCH] raise tsc clocksource rating
if it's inaccurate why are you exposing it to the guest then? Native only uses the TSC if it's safe and accurate to do so. Ingo -
Oct 29, 6:48 pm 2007
Zachary Amsden
Re: [PATCH] raise tsc clocksource rating
Not every guest support paravirt, but for correctness, all guests require TSC, which must be exposed all the way up to userspace, no matter what the efficiency or accuracy may be. Zach -
Oct 29, 6:55 pm 2007
Ingo Molnar
Re: [PATCH] raise tsc clocksource rating
but if there's a perfect TSC available (there is such hardware) then the TSC _is_ the best clocksource. Paravirt now turns it off unconditionally in essence. anyway, that's at most an optimization issue. No strong feelings here, and we can certainly delay this patch until this gets all sorted out. Ingo -
Oct 29, 7:02 pm 2007
Dan Hecht
Re: [PATCH] raise tsc clocksource rating
Not really. In the case hardware TSC is perfect, the paravirt time counter can be implemented directly in terms of hardware TSC; there is no loss in optimization. This is done transparently. And virtual TSC can be implemented this way too. The real improvement that a paravirt clocksource offers over the TSC clocksource is that the guest does not need to measure the TSC frequency itself against some other constant frequency source (which is problematic on a virtual machine). Instead, the...
Oct 29, 7:24 pm 2007
Zachary Amsden
Re: [PATCH] raise tsc clocksource rating
No, if no paravirt clocksource is detected, nothing can override the perfect TSC hardware clocksource rating of 400. And if a paravirt This patch should be nacked, since it is just wrong. This is not an optimization issue. It is an accuracy issue for all virtualization environments that affects long term kernel clock stability, which is important to fix, and the best way to do that is to use a paravirt clocksource. Zach -
Oct 29, 7:13 pm 2007
Ingo Molnar
Re: [PATCH] raise tsc clocksource rating
i know it's not an optimization issue. Your current pessimisation of even perfect TSCs _is_ an optimization issue. (and note that if the TSC is unstable the guest will/should notice it and will fall back to the hyper clocksource) Ingo -
Oct 29, 7:17 pm 2007
Jeremy Fitzhardinge
Re: [PATCH] raise tsc clocksource rating
It is used as part of the Xen clocksource as a short term extrapolator, with correction parameters supplied by the hypervisor. It should never be used directly. J -
Oct 29, 6:52 pm 2007
Ingo Molnar
Re: [PATCH] raise tsc clocksource rating
that's totally broken then. You cannot create an SMP-safe monotonic clocksource via interpolation - native does not do it either. Good thing this problem got exposed, it needs to be fixed. Ingo -
Oct 29, 6:55 pm 2007
Jeremy Fitzhardinge
Re: [PATCH] raise tsc clocksource rating
Sigh, I don't really want to have this fight again. I don't really see what point there is in raising the tsc's rating (why is 300 insufficient again?), but regardless of the value, the Xen clocksource rating needs to be higher. J -
Oct 29, 7:17 pm 2007
Ingo Molnar
Re: [PATCH] raise tsc clocksource rating
i dont remember us having discussed this before, ever. If there's any "fight" about monotonicity and SMP then it would be a pretty onesided anyway, i agree that this patch cannot go in in its current form. Ingo -
Oct 29, 7:21 pm 2007
Jeremy Fitzhardinge Oct 29, 7:33 pm 2007
Jeremy Fitzhardinge
Re: [PATCH] raise tsc clocksource rating
Yes, agreed. The tsc is never the right thing to use if there's a paravirt clocksource available. What's wrong with rating it 300? What inferior clocksource does it lose out to? Shouldn't that clocksource be lowered? (Why don't we just use 1 to 10?) J -
Oct 29, 6:45 pm 2007
Thomas Gleixner
Re: [PATCH] raise tsc clocksource rating
On Mon, 29 Oct 2007, Glauber de Oliveira Costa wrote: -
Oct 29, 6:17 pm 2007
Ingo Molnar
Re: [PATCH] raise tsc clocksource rating
Acked-by: Ingo Molnar <mingo@elte.hu> Ingo -
Oct 29, 6:36 pm 2007
Auke Kok
[PATCH] quirk_vialatency: Omit reading pci revision ID
Don't read the revision ID unnecessary since the PCI subsystem fills this field in already. Updated to fix a thinko bug in a previously sent patch. Signed-off-by: Auke Kok <auke-jan.h.kok@intel.com> Cc: alan@lxorguk.ukuu.org.uk --- drivers/pci/quirks.c | 7 ++----- 1 files changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c index d0bb5b9..92dc513 100644 --- a/drivers/pci/quirks.c +++ b/drivers/pci/quirks.c @@ -139,25 +139,22 @@ DECL...
Oct 29, 5:55 pm 2007
Mathieu Desnoyers
[RFC] Create instrumentation directory (git repository)
Hi, Since we already have the Instrumentation menu in kernel/Kconfig.instrumentation and instrumentation code all over the kernel tree: arch/*/oprofile/*.c kernel/kprobes.c arch/*/kernel/kprobes.c kernel/marker.c kernel/profile.c kernel/lockdep.c vm/vmstat.c block/blktrace.c drivers/base/power/trace.c We could move them to instrumentation/ arch/*/instrumentation/ Therefore, we could also move the kprobes and marker samples under instrumentation/samples/ Here is a link to a gi...
Oct 29, 5:51 pm 2007
Christoph Lameter
Re: [RFC] Create instrumentation directory (git repository)
The vm statistics are important for the operation of the VM. They are not optional. So I do not think that they fall under the category of instrumentation. -
Oct 29, 7:20 pm 2007
Mathieu Desnoyers
Re: [RFC] Create instrumentation directory (git repository)
But I guess vm stats can be useful to others; a kernel tracer for instance ? Putting stuff in instrumentation/ by no way means that it becomes optional for a subsystem, but merely that it could either export information useful for kernel instrumentation or have some infrastructure parts merged with others. Mathieu -- Mathieu Desnoyers Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68 -
Oct 29, 7:40 pm 2007
Christoph Lameter
Re: [RFC] Create instrumentation directory (git repository)
The vm statistics are intricately connected with other mm code. Best leave it where it is. The other instrumentation is something that is put in particularly for gaining statistics. -
Oct 29, 7:45 pm 2007
Randy Dunlap
Re: [RFC] Create instrumentation directory (git repository)
Two more added. Jeff Garzik and Christoph H. sometimes have some comments about this. It would be helpful if we could get comments on this in the next day or two [instead of in 1-2 weeks]. Thanks, --- ~Randy -
Oct 29, 6:47 pm 2007
Jeff Garzik
Re: [RFC] Create instrumentation directory (git repository)
"instrumentation" is long, and painful to the fingers :) Jeff -
Oct 29, 6:54 pm 2007
Mathieu Desnoyers
Re: [RFC] Create instrumentation directory (git repository)
And quoting the answer from Valdis.Kletnieks@vt.edu : How so? i n s esc. 4 keystrokes (and still 2 more than D<ESC> ;) Better suggestions are wery welcome. However, in modern shells, auto-completion is cheap nowadays. Mathieu -- Mathieu Desnoyers Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68 -
Oct 29, 7:04 pm 2007
Jeff Garzik
Re: [RFC] Create instrumentation directory (git repository)
That is no excuse for extreme verbosity. It makes ls(1) displays ugly, it makes diffstat ugly, it causes long pathnames to be truncated in various display-oriented programs. Pick a shorter word like probes or profile or what... or better yet... just leave most things in their current directories. Shuffling files around just to put them into directories with extra-long names is highly undesirable. Jeff -
Oct 29, 7:08 pm 2007
Mathieu Desnoyers
Re: [RFC] Create instrumentation directory (git repository)
I'll keep the probes and profile directory name ideas in mind, thanks. This patchset does more than moving things around : its purpose is to gather various kernel files that have similar purpose (instrumentation) into a single directory so that it becomes easier to work on these without duplicating the effort. I see no good reason to have so many different adhoc instrumentation mechanisms for profiling (sched, vm, oprofile) and tracing (blktrace, suspend/resume tracing) all over the place. Merg...
Oct 29, 7:35 pm 2007
Thomas Bächler
2.6.24-rc1-82798a1 compile failure (x86_64)
x86_64 fails to compile for me with this error: CC arch/x86/kernel/vsyscall_64.o {standard input}: Assembler messages: {standard input}:434: Error: symbol `vsysc2' is already defined make[1]: *** [arch/x86/kernel/vsyscall_64.o] Error 1 make: *** [arch/x86/kernel] Error 2 The .config is attached. What's wrong?
Oct 29, 5:46 pm 2007
Thomas Gleixner
Re: 2.6.24-rc1-82798a1 compile failure (x86_64)
Thomas, On Mon, 29 Oct 2007, Thomas B
Oct 29, 6:12 pm 2007
Andrew Morton
Re: [PATCH] dcdbas: add DMI-based module autloading
On Mon, 29 Oct 2007 16:25:15 -0500 fyi, I added this to the 2.6.25 queue. If you think a patch should go into 2.6.24 then it is best to explicitly say that and to explain why. -
Oct 29, 5:34 pm 2007
Jeff Garzik
[PATCH v5 0/2] SCSI asynchronous event notification API
This is the next revision of the SCSI event notification infrastructure patchset, enabling SATA Asynchronous Notification ("AN") for CD/DVD devices that support it. For devices that support SATA AN (only very recent ones do), this means that HAL and other userspace utilities no longer need to repeatedly poll the CD/DVD device to determine if the user has changed the media. This revision takes into account James' comments from earlier today, up to patchset revision #4 (this one is revision 5). ...
Oct 29, 5:31 pm 2007
Jeff Garzik
[PATCH v5 2/2] libata: Utilize new SCSI event infrastructure
An end to CD-ROM polling (if you have a device that supports AN)... hooray! Signed-off-by: Jeff Garzik <jgarzik@redhat.com> --- drivers/ata/libata-scsi.c | 8 +++++--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c index 93bd36c..3cbee22 100644 --- a/drivers/ata/libata-scsi.c +++ b/drivers/ata/libata-scsi.c @@ -841,6 +841,9 @@ static void ata_scsi_dev_config(struct scsi_device *sdev, blk_queue_max_hw_segments(q,...
Oct 29, 5:31 pm 2007
previous daytodaynext day
October 28, 2007October 29, 2007October 30, 2007