Re: [PATCH] proc_fs.h redux

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Joe Perches <joe@...>
Cc: Alexey Dobriyan <adobriyan@...>, <akpm@...>, <torvalds@...>, <viro@...>, <linux-kernel@...>, <netdev@...>, <linux-arch@...>
Date: Sunday, October 28, 2007 - 4:44 am

> 

Quite the opposite - at least in the kernel source.
The general rule is that a .h file shall include the
.h files which contain declarations used by said .h files.
But naked declarations as above is preferred over including
a full header file.

We see the full header dependency thing to blow off when
inline function are used - which is more and more the case.
In several cases we have converted inline functions to macros
just to simplify the nightmare of header dependencies we have.

Arnaldo have a nice script that generate a .ps file
showing all the dependencies.
He lately posted this URL: http://oops.ghostprotocols.net:81/acme/tcp.h.ps

	Sam
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] proc_fs.h redux, Alexey Dobriyan, (Sat Oct 27, 3:47 pm)
Re: [PATCH] proc_fs.h redux, Joe Perches, (Sat Oct 27, 6:40 pm)
Re: [PATCH] proc_fs.h redux, Russell King, (Sun Oct 28, 6:34 am)
Re: [PATCH] proc_fs.h redux, Roman Zippel, (Sun Oct 28, 1:58 pm)
Re: [PATCH] proc_fs.h redux, Bernhard Walle, (Sun Oct 28, 7:59 am)
Re: [PATCH] proc_fs.h redux, Russell King, (Sun Oct 28, 9:04 am)
Re: [PATCH] proc_fs.h redux, Bernhard Walle, (Sun Oct 28, 9:25 am)
Re: [PATCH] proc_fs.h redux, Jan Engelhardt, (Sun Oct 28, 6:43 am)
Re: [PATCH] proc_fs.h redux, Sam Ravnborg, (Sun Oct 28, 4:44 am)
Re: [PATCH] proc_fs.h redux, Arnaldo Carvalho de Melo, (Mon Oct 29, 9:03 am)
Re: [PATCH] proc_fs.h redux, Alexey Dobriyan, (Sun Oct 28, 3:02 am)