struct user . u_ar0

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <linux-arch@...>
Cc: Linux Kernel Mailing List <linux-kernel@...>
Date: Saturday, October 27, 2007 - 8:54 pm

I recently noticed that all architectures appear to have an entry n 
struct user called u_ar0:

   struct user_pt_regs * u_ar0;  /* Used by gdb to help find the values 
for */
                                 /* the registers. */

In all cases, u_ar0 is a pointer type, although the type of pointer 
varies with the architecture.

However, under no conditions does this field ever contain a pointer 
value!  It is set by the a.out code and its derivatives as an offset, 
not a pointer value (there are a total of four references in the kernel, 
in arch/{m68k,blackfin}/kernel/process.c, arch/x86/ia32/ia32_aout.c and 
fs/binfmt_aout.c -- they are all functionally identical and write-only):

dump.u_ar0 = (void *)(((unsigned long)(&dump.regs)) - ((unsigned 
long)(&dump)));

Any reason to *NOT* change this field to "unsigned long"?  <asm/user.h>, 
where struct user is defined, is not exported to userspace in any 
architecture as far as I can tell, although <linux/user.h>, which just 
contains #include <asm/user.h>, *is* exported (clearly a bug.)

	-hpa


-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
struct user . u_ar0, H. Peter Anvin, (Sat Oct 27, 8:54 pm)
Re: struct user . u_ar0, Mike Frysinger, (Sun Oct 28, 4:04 am)
Re: struct user . u_ar0, H. Peter Anvin, (Sun Oct 28, 2:27 pm)