Rename old vfs_ioctl to do_ioctl, because the comment above it clearly indicates that it is an internal function not to be exported to modules; therefore it should have a more traditional do_XXX name. The new do_ioctl is exported in fs.h but not to modules. Rename the old do_ioctl to vfs_ioctl because the names vfs_XXX should preferably be reserved to callable VFS functions which modules may call, as many other vfs_XXX functions already do. Export the new vfs_ioctl to modules so others can use it...

Signed-off-by: Erez Zadok <ezk@cs.sunysb.edu> --- fs/unionfs/commonfops.c | 32 ++++++-------------------------- 1 files changed, 6 insertions(+), 26 deletions(-) diff --git a/fs/unionfs/commonfops.c b/fs/unionfs/commonfops.c index 50e5775..c99b519 100644 --- a/fs/unionfs/commonfops.c +++ b/fs/unionfs/commonfops.c @@ -661,31 +661,6 @@ out: return err; } -/* pass the ioctl to the lower fs */ -static long do_ioctl(struct file *file, unsigned int cmd, unsigned long arg) -{ - stru...

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> --- diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index d9f78c8..1c50278 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -9299,7 +9299,6 @@ static struct alc_config_preset alc268_presets[] = { .num_channel_mode = ARRAY_SIZE(alc268_modes), .channel_mode = alc268_modes, .input_mux = &alc268_capture_source, - .input_mux = &alc268_capture_source, .unsol_event = ...

Remove proc_fs.h from headers that doesn't really need it. Typical overkill is including full header when one can get away with just forward declaration of "struct proc_dir_entry". Number of files that are recompiled after touching proc_fs.h drops from 1100 to 513(!) on x86_64 allmodconfig. Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com> --- arch/powerpc/kernel/process.c | 1 + arch/powerpc/kernel/prom.c | 1 + arch/powerpc/mm/init_32.c ...

This eliminated the warning. Thanks. -

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> --- diff --git a/drivers/scsi/arm/scsi.h b/drivers/scsi/arm/scsi.h index 21ba571..2d09fef 100644 --- a/drivers/scsi/arm/scsi.h +++ b/drivers/scsi/arm/scsi.h @@ -39,7 +39,7 @@ static inline int next_SCp(struct scsi_pointer *SCp) SCp->buffer++; SCp->buffers_residual--; SCp->ptr = (char *) - (page_address(SCp->buffer->page) + + (page_address(sg_page(SCp->buffer)) + SCp->buffer->offset); SCp-&gt...

Already have this one queued for Linus in my tree. -- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: -

struct device doesn't have ->dma; it's in struct expansion_card where that struct device is embedded into. Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> --- diff --git a/drivers/ide/arm/icside.c b/drivers/ide/arm/icside.c index 410a0d1..93f71fc 100644 --- a/drivers/ide/arm/icside.c +++ b/drivers/ide/arm/icside.c @@ -316,13 +316,13 @@ static int icside_dma_end(ide_drive_t *drive) drive->waiting_for_dma = 0; - disable_dma(state->dev->dma); + disable_dma(ECARD_DEV(stat...

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> --- diff --git a/arch/frv/mb93090-mb00/pci-dma.c b/arch/frv/mb93090-mb00/pci-dma.c index 671ce1e..662f7b1 100644 --- a/arch/frv/mb93090-mb00/pci-dma.c +++ b/arch/frv/mb93090-mb00/pci-dma.c @@ -15,6 +15,7 @@ #include <linux/list.h> #include <linux/pci.h> #include <linux/highmem.h> +#include <linux/scatterlist.h> #include <asm/io.h> void *dma_alloc_coherent(struct device *hwdev, size_t size, dma_addr_t *...

[PATCH] powerpc: fix sysctl whining re kernel.powersave-nap kernel was marked with 0755. Everywhere else it's 0555. Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com> --- arch/powerpc/kernel/idle.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/arch/powerpc/kernel/idle.c +++ b/arch/powerpc/kernel/idle.c @@ -122,7 +122,7 @@ static ctl_table powersave_nap_sysctl_root[] = { { .ctl_name = CTL_KERN, .procname = "kernel", - .mode = 0755, + .mode = 0555, ...

This patch defines names for numeric constants that used in scatter list for more convenient code reading. Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com> --- I'm not sure if it really needed but who knows ;) Any comments are welcome. include/linux/scatterlist.h | 21 ++++++++++++--------- 1 files changed, 12 insertions(+), 9 deletions(-) diff --git a/include/linux/scatterlist.h b/include/linux/scatterlist.h index 4571231..fcc05a5 100644 --- a/include/linux/scatterlist.h ...

[Robert P. J. Day - Sat, Oct 27, 2007 at 01:14:22PM -0400] | On Sat, 27 Oct 2007, Cyrill Gorcunov wrote: | | > | > This patch defines names for numeric constants that | > used in scatter list for more convenient code reading. | > | > Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com> | ... | > @@ -73,7 +76,7 @@ static inline void sg_set_page(struct scatterlist *sg, struct page *page, | > sg->length = len; | > } | > | > -#define sg_page(sg) ((struct pa...

Well, PROP_PRESENT wasn't my idea, currently it's used by pmu and olpc drivers becuase it's not trivial to register/unregister their batteries on physical insertion/removal. I have some plans to teach at least pmu batteries to not use PROP_PRESENT. I don't have any OLPC, thus I can't convert it. To sum this: the good way to handle "missing" batteries is to unregister them, so they'll not show up in the /sys/class/power_supply. Is that possible with the ACPI? The good example is ds2760 batterie...

I didn't say it's hard. But we don't have any interrupts for the Oh. Userspace tried to do something weird then, I think. Generally it's just sane to unregister absent hardware. -- Anton Vorontsov email: cbou@mail.ru backup email: ya-cbou@yandex.ru irc://irc.freenode.net/bd2 -

Do they have different set of properties depending on underlying hardware t= hat=20 you can't query unless hardware is present? I'd rather avoid adding fake=20 Neither does your code (nor kpowersave :) ) Remove battery and set of=20 attributes is "stuck" instead of being reset to only fixed set of power=20 device attributes (basically "info"). The only call to power_supply_registe= r=20 is in acpi_battery_add and as far as I can tell this is executed on adding= =20 *slot* not when content of ...

Now that commit 3794ade5b286cbd4551009dd341dbe9aeead2bc3 removed incorrect dependency on CONFIG_IDE we can fix the driver to not include <linux/ide.h>: * add ATA_REG_{ERROR,LCYL,HCYL,STATUS}_OFFSET defines and use them instead of IDE_{ERROR,LCYL,HCYL,STATUS}_OFFSET from <linux/ide.h> * remove no longer needed <linux/ide.h> include * remove incorrect comment added by the last commit: - isd200.c is not the only user of struct hd_driveid besides IDE (see drivers/block/...

Hi, I'm using rtc-class driver(s) on this system ( current git head ). Modprobing snd-rtctimer results in the following : .. sudo modprobe snd-rtctimer WARNING: Error inserting rtc (/lib/modules/2.6.24-rc1-gec3b67c1/kernel/drivers/char/rtc.ko): Input/output error FATAL: Error inserting snd_rtctimer (/lib/modules/2.6.24-rc1-gec3b67c1/kernel/sound/core/snd-rtctimer.ko): Unknown symbol in module, or unknown parameter (see dmesg) ...

Fix two 'and' typos Signed-off-by: Roel Kluin <12o3l@tiscali.nl> --- diff --git a/drivers/block/pktcdvd.c b/drivers/block/pktcdvd.c index a8130a4..9cd6ba2 100644 --- a/drivers/block/pktcdvd.c +++ b/drivers/block/pktcdvd.c @@ -2202,11 +2202,11 @@ static int pkt_media_speed(struct pktcdvd_device *pd, unsigned *speed) return ret; } - if (!buf[6] & 0x40) { + if (!(buf[6] & 0x40)) { printk(DRIVER_NAME": Disc type is not CD-RW\n"); return 1; } - if (!buf[6] & 0x4...

This patch fixes array overflows in the OSS msnd driver spotted by the Coverity checker. Signed-off-by: Adrian Bunk <bunk@kernel.org> --- 97463a59dfb9ccb915d3b615225c98cb3e310c0a diff --git a/sound/oss/msnd.h b/sound/oss/msnd.h index 05cf786..d0ca582 100644 --- a/sound/oss/msnd.h +++ b/sound/oss/msnd.h @@ -233,8 +233,8 @@ typedef struct multisound_dev { spinlock_t lock; int nresets; unsigned long recsrc; - int left_levels[16]; - int right_levels[16]; + int left_levels[32]; ...

Yes, this is because rtc keeps a char_lock mutex locked as long as the device is open, to avoid concurrent accessess. It could be easily substituted by some counting -- setting and clearing bit in struct rtc_device instead of using char_lock, but doing this just to shut the lockdep off is questionable imho. Peter, what is the preferred way to annotate these kinds of locking for lockdep to express that it is intended? -- Jiri Kosina -

Right, the fd could be transferred using unix sockets or fork(). That would indeed seriously break a mutex. -

Not sure, I'd not thought that anyone would actually want to do this. I'm also not sure how I stand on this, I'd prefer to say: don't do this! I think, in this case, the lock is associated with a kernel object that is properly cleaned up if the holding tasks gets a SIGKILL. But in general I'd like to see this kind of thing go away. Now I could probably come up with an annotation to hide it, but what do other people think, Ingo, Linus, Andrew, do we want to keep kernel locks held over userspac...

Definitely not a sane thing to do. It should use ref-counting and/or a single bit to say "busy". Linus -

This patch fixes the possible usage of a negative value as an array index spotted by the Coverity checker. Signed-off-by: Adrian Bunk <bunk@kernel.org> --- drivers/video/sis/sis_main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) 9f63bf8c543710521e885b09d88271d1a308b158 diff --git a/drivers/video/sis/sis_main.c b/drivers/video/sis/sis_main.c index bc7d236..37bd24b 100644 --- a/drivers/video/sis/sis_main.c +++ b/drivers/video/sis/sis_main.c @@ -1245,24 +1245,25 @@ si...

This patch fixes a memory leak spotted by the Coverity checker. Signed-off-by: Adrian Bunk <bunk@kernel.org> --- drivers/lguest/lguest_user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-2.6/drivers/lguest/lguest_user.c.old 2007-10-27 04:48:14.000000000 +0200 +++ linux-2.6/drivers/lguest/lguest_user.c 2007-10-27 04:48:49.000000000 +0200 @@ -127,121 +127,121 @@ static int initialize(struct file *file, lg = kzalloc(sizeof(*lg), GFP_KERNEL); if (!lg) { err ...