login
Header Space

 
 

Re: [patch 0/6][RFC] Cleanup FIBMAP

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Mike Waychison <mikew@...>
Cc: <linux-fsdevel@...>, <linux-kernel@...>
Date: Saturday, October 27, 2007 - 1:57 pm

Hi,

->bmap is ugly and horrible!  If you have to do this at the very least  
please cause ->bmap64 to be able to return error values in case the  
file system failed to get the information or indeed such information  
does not exist as is the case for compressed and encrypted files for  
example and also for small files that are inside the on-disk inode  
(NTFS resident files and reiserfs packed tails are examples of this).

And another of my pet peeves with ->bmap is that it uses 0 to mean  
"sparse" which causes a conflict on NTFS at least as block zero is  
part of the $Boot system file so it is a real, valid block...  NTFS  
uses -1 to denote sparse blocks internally.

Best regards,

	Anton

On 27 Oct 2007, at 00:37, Mike Waychison wrote:



-- 
Anton Altaparmakov <aia21 at cam.ac.uk> (replace at with @)
Unix Support, Computing Service, University of Cambridge, CB2 3QH, UK
Linux NTFS maintainer, http://www.linux-ntfs.org/

-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[patch 0/6][RFC] Cleanup FIBMAP, Mike Waychison, (Fri Oct 26, 7:37 pm)
Re: [patch 0/6][RFC] Cleanup FIBMAP, H. Peter Anvin, (Sat Oct 27, 8:43 pm)
Re: [patch 0/6][RFC] Cleanup FIBMAP, Anton Altaparmakov, (Sat Oct 27, 1:57 pm)
Re: [patch 0/6][RFC] Cleanup FIBMAP, Chris Mason, (Mon Oct 29, 10:10 am)
Re: [patch 0/6][RFC] Cleanup FIBMAP, Mike Waychison, (Mon Oct 29, 3:16 pm)
Re: [patch 0/6][RFC] Cleanup FIBMAP, Andreas Dilger, (Mon Oct 29, 3:47 pm)
Re: [patch 0/6][RFC] Cleanup FIBMAP, Zach Brown, (Mon Oct 29, 12:30 pm)
Re: [patch 0/6][RFC] Cleanup FIBMAP, Mike Waychison, (Mon Oct 29, 3:18 pm)
Re: [patch 0/6][RFC] Cleanup FIBMAP, Zach Brown, (Mon Oct 29, 4:00 pm)
Re: [patch 0/6][RFC] Cleanup FIBMAP, Ric Wheeler, (Wed Oct 31, 7:06 am)
Re: [patch 0/6][RFC] Cleanup FIBMAP, Zach Brown, (Wed Oct 31, 12:16 pm)
Re: [patch 0/6][RFC] Cleanup FIBMAP, Ric Wheeler, (Wed Oct 31, 1:17 pm)
Re: [patch 0/6][RFC] Cleanup FIBMAP, Chris Mason, (Mon Oct 29, 3:46 pm)
Re: [patch 0/6][RFC] Cleanup FIBMAP, Zach Brown, (Mon Oct 29, 4:01 pm)
Re: [patch 0/6][RFC] Cleanup FIBMAP, Szabolcs Szakacsits, (Sat Oct 27, 5:45 pm)
speck-geostationary