On Saturday 27 October 2007, Alexey Starikovskiy wrote:
quoted text
> Andrey Borzenkov wrote:
> > I am not exactly sure about this one ... what other power_supply class
> > drivers do? Should I fix HAL instead (but then, I do not know whether H=
AL
quoted text
> > is the only application that is using this interface).
>
> Hm, do you need separate set of properties for that? You could register
> either of existing two, and read function will not allow read of anything
> but "present". IMHO, this is what other modules do (/drivers/power)

Do they have different set of properties depending on underlying hardware t=
hat=20
you can't query unless hardware is present? I'd rather avoid adding fake=20
attributes; but I do not actually care so which one do you prefer? :)

quoted text
> One remaining trick here, you need to call unregister/register for
> power_supply if you change attributes -- so please check if your patched
> driver survives insertion of the battery.
>


Neither does your code (nor kpowersave :) ) Remove battery and set of=20
attributes is "stuck" instead of being reset to only fixed set of power=20
device attributes (basically "info"). The only call to power_supply_registe=
r=20
is in acpi_battery_add and as far as I can tell this is executed on adding=
=20
*slot* not when content of this slot changes.