Re: [2.624-rc1 regression] lost battery information

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Alexey Starikovskiy <aystarik@...>
Cc: <linux-acpi@...>, <linux-kernel@...>, Frans Pop <elendil@...>
Date: Saturday, October 27, 2007 - 3:22 am

On Friday 26 October 2007, Alexey Starikovskiy wrote:



[ 1191.471572] ACPI: element[12]->type =3D 1, expected string
[ 1196.640065] ACPI: element[12]->type =3D 1, expected string
[ 1199.479773] ACPI: element[12]->type =3D 1, expected string
[ 1199.745435] ACPI: element[12]->type =3D 1, expected string

it is "OEM type". For reference here is _BIF from my DSDT:

             Method (_BIF, 0, NotSerialized)
            {
                Name (BUFF, Package (0x0D) {})
                Store (0x00, Index (BUFF, 0x00))
                Store (\_SB.MEM.BDV2, Local2)
                Multiply (\_SB.MEM.BDC2, Local2, Local0)
                Divide (Local0, 0x03E8, Local1, Local0)
                Store (Local0, Index (BUFF, 0x01))
                Multiply (\_SB.MEM.BLF2, Local2, Local0)
                Divide (Local0, 0x03E8, Local1, Local0)
                Store (Local0, Index (BUFF, 0x02))
                Store (\_SB.MEM.BTC2, Index (BUFF, 0x03))
                Store (\_SB.MEM.BDV2, Index (BUFF, 0x04))
                Multiply (\_SB.MEM.BCW2, Local2, Local0)
                Divide (Local0, 0x03E8, Local1, Local0)
                Store (Local0, Index (BUFF, 0x05))
                Multiply (\_SB.MEM.BCL2, Local2, Local0)
                Divide (Local0, 0x03E8, Local1, Local0)
                Store (Local0, Index (BUFF, 0x06))
                Multiply (\_SB.MEM.BG12, Local2, Local0)
                Divide (Local0, 0x03E8, Local1, Local0)
                Store (Local0, Index (BUFF, 0x07))
                Multiply (\_SB.MEM.BG22, Local2, Local0)
                Divide (Local0, 0x03E8, Local1, Local0)
                Store (Local0, Index (BUFF, 0x08))
                Store (\_SB.MEM.BMN2, Index (BUFF, 0x09))
                Store (\_SB.MEM.BSN2, Index (BUFF, 0x0A))
                Store (\_SB.MEM.BTP2, Index (BUFF, 0x0B))
                Store (\_SB.MEM.BOI2, Index (BUFF, 0x0C))
                Return (BUFF)
            }

This is behaviour change. Previous battery.c used generic acpi_extract_pack=
age=20
which allowed (allows) for object of type integer when string is requested:

                case ACPI_TYPE_INTEGER:
                        switch (format_string[i]) {
                        case 'N':
                                size_required +=3D sizeof(acpi_integer);
                                tail_offset +=3D sizeof(acpi_integer);
                                break;
                        case 'S':
                                size_required +=3D
                                    sizeof(char *) + sizeof(acpi_integer) +
                                    sizeof(char);
                                tail_offset +=3D sizeof(char *);
                                break;

while current battery.c:extract_package fails:

                if (offsets[i].mode) {
                        if (element->type !=3D ACPI_TYPE_STRING &&
                            element->type !=3D ACPI_TYPE_BUFFER) {
printk (KERN_ERR PREFIX "element[%d]->type =3D %x, expected string\n", i,=20
element->type);
                                return -EFAULT;
                        }

well, while it could be BIOS fault this happily worked before ... This is=20
obviously also the reason why I do not have anything in /sys

=46ans, could you check whether you have the same issue using test patch?
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[2.624-rc1 regression] lost battery information, Andrey Borzenkov, (Fri Oct 26, 12:24 pm)
Re: [2.624-rc1 regression] lost battery information, Alexey Starikovskiy, (Fri Oct 26, 12:57 pm)
Re: [2.624-rc1 regression] lost battery information, Andrey Borzenkov, (Fri Oct 26, 1:20 pm)
Re: [2.624-rc1 regression] lost battery information, Alexey Starikovskiy, (Fri Oct 26, 2:12 pm)
Re: [2.624-rc1 regression] lost battery information, Andrey Borzenkov, (Fri Oct 26, 2:15 pm)
Re: [2.624-rc1 regression] lost battery information, Alexey Starikovskiy, (Fri Oct 26, 2:32 pm)
Re: [2.624-rc1 regression] lost battery information, Andrey Borzenkov, (Sat Oct 27, 3:22 am)
Re: [2.624-rc1 regression] lost battery information, Alexey Starikovskiy, (Sat Oct 27, 9:45 am)
Re: [2.624-rc1 regression] lost battery information, Andrey Borzenkov, (Sat Oct 27, 10:55 am)
Re: [2.624-rc1 regression] lost battery information, Alexey Starikovskiy, (Sat Oct 27, 11:20 am)
Re: [2.624-rc1 regression] lost battery information, Andrey Borzenkov, (Sat Oct 27, 12:49 pm)
Re: [2.624-rc1 regression] lost battery information, Alexey Starikovskiy, (Sat Oct 27, 12:59 pm)
Re: [2.624-rc1 regression] lost battery information, Frans Pop, (Sat Oct 27, 12:16 pm)
Re: [2.624-rc1 regression] lost battery information, Frans Pop, (Fri Oct 26, 4:57 pm)
Re: [2.624-rc1 regression] lost battery information, Alexey Starikovskiy, (Fri Oct 26, 5:07 pm)
Re: [2.624-rc1 regression] lost battery information, Frans Pop, (Fri Oct 26, 2:00 pm)
Re: [2.624-rc1 regression] lost battery information, Frans Pop, (Fri Oct 26, 12:44 pm)