From: Tony Jones <tonyj@suse.de> Convert from class_device to device for drivers/dma/dmaengine. This is part of the work to eliminate struct class_device. Signed-off-by: Tony Jones <tonyj@suse.de> Signed-off-by: Dan Williams <dan.j.williams@intel.com> Signed-off-by: Shannon Nelson <shannon.nelson@intel.com> Cc: Kay Sievers <kay.sievers@vrfy.org> --- drivers/dma/dmaengine.c | 46 ++++++++++++++++++++++++--------------------- include/linux/dmaengine.h | 3 ...

When a channel is removed from dmaengine, too many kref_put() calls are made and the device removal happens too soon, usually causing a panic. Cc: Haavard Skinnemoen <hskinnemoen@atmel.com> Cc: Dan Williams <dan.j.williams@intel.com> Signed-off-by: Shannon Nelson <shannon.nelson@intel.com> --- drivers/dma/dmaengine.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/dma/dmaengine.c b/drivers/dma/dmaengine.c index 84257f7..245da53 100644 ---...

Introduce FIBMAP64. This is the same as FIBMAP, but takes a u64. This new routine requires filesystems to implement bmap64 if they want to support > 2^31 blocks in a logical file. We do this to give time for filesystems to be properly audited. Signed-off-by: Mike Waychison <mikew@google.com> fs/compat_ioctl.c | 2 ++ fs/ioctl.c | 34 +++++++++++++++++++++++++++++++++- include/linux/fs.h | 7 +++++++ 3 files changed, 42 insertions(+), 1 deletion(-) Index: linux-2.6...

Remove the need for having CAP_SYS_RAWIO when doing a FIBMAP call on an open file descriptor. It would be nice to allow users to have permission to see where their data is landing on disk, and there really isn't a good reason to keep them from getting at this information. Signed-off-by: Mike Waychison <mikew@google.com> fs/ioctl.c | 3 --- 1 file changed, 3 deletions(-) Index: linux-2.6.23/fs/ioctl.c =================================================================== --- linux-2.6.23....

Return an error if the user requests a negative logical block in a file. Signed-off-by: Mike Waychison <mikew@google.com> fs/ioctl.c | 2 ++ 1 file changed, 2 insertions(+) Index: linux-2.6.23/fs/ioctl.c =================================================================== --- linux-2.6.23.orig/fs/ioctl.c 2007-10-26 15:25:48.000000000 -0700 +++ linux-2.6.23/fs/ioctl.c 2007-10-26 16:16:29.000000000 -0700 @@ -60,6 +60,8 @@ static int file_ioctl(struct file *filp, return -EPERM; ...

The following series is meant to clean up FIBMAP paths with the eventual goal of allowing users to be able to FIBMAP their data. I'm sending this as an RFC as I've only tested this on a x86_64 kernel with a 32bit binary on ext2 and I've noticed a couple ext2_warnings already. I'm unsure of the locking in [4/6] fix_race_with_truncate.patch. Any help here would greatly be appreciated. The last patch, [6/6] drop_cap_sys_rawio_for_fibmap.patch, is of course, not to be applied until any remaining issue...

This patch fixes the following build error with CONFIG_SYSCTL=n: <-- snip --> ... ERROR: "sysctl_rmem_max" [fs/dlm/dlm.ko] undefined! ERROR: "sysctl_wmem_max" [drivers/net/rrunner.ko] undefined! ERROR: "sysctl_rmem_max" [drivers/net/rrunner.ko] undefined! make[2]: *** [__modpost] Error 1 <-- snip --> Signed-off-by: Adrian Bunk <bunk@kernel.org> --- 22ea6cd56e4fa844b0b1bbab2542f09eb6c9a5ab diff --git a/net/core/sock.c b/net/core/sock.c index febbcbc..ee1cc4f 10064...

Although it does rather sound like a driver writer yanking the rope from the hand's of the sysadmin and hanging him with it rather than letting the sysadmin do it himself. I've seen other drivers' README's suggesting larger mem's but not their sources doing it. rick jones -

Drift... Is that something netperf should be using though? Right now it uses the regular SO_[SND|RCV]BUF calls and is at the mercy of sysctls. I wonder if it would be better to have it use their FORCE versions to make life easier on the benchmarker - such as myself - who has an unfortunate habit of forgetting to update sysctl.conf :) rick jones -

The list of options that the fd transport accepts is missing end-of-options marker. This patch adds it. Signed-off-by: Latchesar Ionkov <lucho@ionkov.net> --- commit 70ec0c7936c2516d128fdb1a32d749071b8846ec tree 8de5495f83b94096825f8bfe0767e4fcbaf36ef3 parent 25ed88ed319e40fb6426e2aaefcc5f136aadd4ee author Latchesar Ionkov <lucho@ionkov.net> 1193438452 -0600 committer Latchesar Ionkov <lucho@ionkov.net> 1193438452 -0600 net/9p/trans_fd.c | 3 ++- 1 files changed, 2 inse...

v9fs_parse_options function uses strsep which modifies the value of the v9ses->options field. That modified value is later passed to the function that creates the transport potentially making the transport creation function to fail. This patch creates a copy of v9ses->option field that v9fs_parse_options function uses instead of the original value. Signed-off-by: Latchesar Ionkov <lucho@ionkov.net> --- commit 0c0b7fa3d4e80ab3e4e69b8a55661f649d1b41ff tree eeb4ac6ea85387c153e3f7f6ca...

I'm fairly certain that the signal issue you they are dealing with is how to keep children from killing the init of a pid namespace. At least that is what Suka mentioned when I asked him earlier, and that is the discussion I have at various times on the containers list. This is a totally different issue. This is keeping kill -1 in a child pid namespace from sending a signal to every process in the system. It is a bad bug and this patch is a complete fix for it. I explicitly asked Suka, Pav...

This patch fixes a race between direct IO writes and non-direct IO reads on the same file. The symptom is a stale file page seen by any non-direct-IO reader, which persists until the page is invalidated somehow (e.g. page rewritten again, or memory pressure, or reboot). An improper return test caused direct-IO's after-write page invalidations to be skipped. If we're writing page N, and the reader is reading page N-x for small x, and the read code decides to readahead, it's not too hard to cause a...

Agreed. And it's a really dumb bug. ->direct_io will almost always return -EIOCBQUEUED for aio dio so it won't be invalidating for aio dio writes. (Notice that the testing in that commit mentions two racing processes, I bet U$1M that I only tested sync dio :/) I think that test should be changed to if (retval < 0 && retval != -EIOCBQUEUED) If the invalidation fails then the app is left with stale data in the page cache and current data on disk. The return code corruption y...

I'm reasonably comfortable with that, sure. This second invalidation only catches reads which userspace raced with the write, and that's already racy by definition. I can throw together a patch if you haven't already committed one by the time you read this ;). - z -

Sure thing. It looks like Karl just sent out the patch I had in mind, so I'll run it through the tests on Monday. I assume everyone can It's disappointingly easy to trigger with ext3 and ordered extending writes. The invalidation can race with jbd pinning the bhs while it commits the transaction. It happens that ext3 returns failure from ->releasepage if jbd is committing the transaction. dio will definitely bring the page in with get_user_pages() but I'd like to think that that pinned...

Well, actually, in this case both processes are doing sync IO. It's just that the writer is direct and the reader isn't, with the reader usually behind the writer but close enough that readahead crosses the writer reasonably often. With the if (retval) test, we only invalidate if nothing got written at all! I hadn't even thought of aio directio. Yeah, the invalidate should happen for -EIOCBQUEUED as well, I guess. The disparity in direct-io-ness on the part of the reader vs writer is a user...

Hi; Following trivial patch corrects caglar@zangetsu linux-2.6 $ make CHK include/linux/version.h CHK include/linux/utsrelease.h CALL scripts/checksyscalls.sh CHK include/linux/compile.h LD net/ipv6/built-in.o CC [M] net/ipv6/tcp_ipv6.o net/ipv6/tcp_ipv6.c: In function `tcp_v6_rcv': net/ipv6/tcp_ipv6.c:1736: error: implicit declaration of function `get_softnet_dma' net/ipv6/tcp_ipv6.c:1736: warning: assignment makes pointer from integer without a cast make[2...

Yeah, I think that's the right thing to do. Doesn't have an audit_context anyway. Acked-by: Chris Wright <chrisw@sous-sol.org> -

This is my trivial patch to swat innumerable little bugs with a single blow. After some intensive review (my apologies for not having gotten to this sooner) what we have looks like a good base to build on with the current pid namespace code but it is not complete, and it is still much to simple to find issues where the kernel does the wrong thing outside of the initial pid namespace. Until the dust settles and we are certain we have the ABI and the implementation is as correct as humanly poss...

There has been a long-standing wart in linux/swap.h where it uses page_cache_release and release_pages without declaring them by including linux/pagemap.h. There is this scary comment to warn off anyone foolish enough to try to fix this: /* only sparc can not include linux/pagemap.h in this file * so leave page_cache_release and release_pages undeclared... */ This has caused problems for a number of people including: akpm - [ message continues ]

Not fundamental reasons, but these patches break the ia64 build for most configs with: In file included from kernel/futex.c:59: include/asm/futex.h: In function `futex_atomic_op_inuser': include/asm/futex.h:62: error: implicit declaration of function `pagefault_disable' include/asm/futex.h:86: error: implicit declaration of function `pagefault_enable' make[1]: *** [kernel/futex.o] Error 1 Adding an include of <linux/uaccess.h> to kernel/futex.c is sufficient (but not necessarily right) t...

Include linux/pagemap.h in linux/swap.h and remove the comment saying that it's not possible. --- include/linux/swap.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Index: linux-2.6.17/include/linux/swap.h =================================================================== --- linux-2.6.17.orig/include/linux/swap.h 2007-10-24 10:05:09.000000000 -0400 +++ linux-2.6.17/include/linux/swap.h 2007-10-25 22:59:29.000000000 -0400 @@ -6,6 +6,7 @@ #include <linux/mmzone.h> #inc...

akpm objected to some of the macros, so convert them into functions. Signed-off-by: Darrick J. Wong <djwong@us.ibm.com> --- drivers/hwmon/i5k_amb.c | 65 +++++++++++++++++++++++++++++++---------------- 1 files changed, 43 insertions(+), 22 deletions(-) diff --git a/drivers/hwmon/i5k_amb.c b/drivers/hwmon/i5k_amb.c index 7fdbe81..6ac5c6f 100644 --- a/drivers/hwmon/i5k_amb.c +++ b/drivers/hwmon/i5k_amb.c @@ -47,16 +47,35 @@ #define AMB_CONFIG_SIZE 2048 #define AMB_FUNC_3_OFFSET ...

Linus, please pull x86 bugfixes from ssh://master.kernel.org/pub/scm/linux/kernel/git/x86/linux-2.6-x86.git Thanks tglx Thomas Gleixner (2): Revert "i386: export i386 smp_call_function_mask() to modules" x86: export smp_ops to allow modular build of KVM arch/x86/kernel/smp_32.c | 8 +------- include/asm-x86/smp_32.h | 9 ++++++--- 2 files changed, 7 insertions(+), 10 deletions(-) diff --git a/arch/x86/kernel/smp_32.c b/arch/x86/kernel/smp_32.c index f321153..f...