Home » Mailing list archives » linux-kernel » 2007 » October » 26

Re: [PATCH] Fix bad data from non-direct-io read after direct-io write

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Linus Torvalds <torvalds@...>
To: Zach Brown <zach.brown@...>
Cc: Karl Schendel <kschendel@...>, Benjamin LaHaise <bcrl@...>, Andrew Morton <akpm@...>, Linux Kernel Mailing List <linux-kernel@...>, Nick Piggin <nickpiggin@...>, Leonid Ananiev <leonid.i.ananiev@...>, Chris Mason <chris.mason@...>
Subject: Re: [PATCH] Fix bad data from non-direct-io read after direct-io write
Date: Friday, October 26, 2007 - 6:42 pm

On Fri, 26 Oct 2007, Zach Brown wrote:

How about not testing at all? Which was what the old code did.

Just do the invalidate unconditionally for any writes, and screw the end 
result of the invalidate, since we cannot afford to overwrite the previous 
return value anyway in any realistic scenario?

		Linus
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] Fix bad data from non-direct-io read after direct-io..., Karl Schendel, (Fri Oct 26, 5:12 pm)
Re: [PATCH] Fix bad data from non-direct-io read after direc..., Linus Torvalds, (Fri Oct 26, 5:34 pm)
Re: [PATCH] Fix bad data from non-direct-io read after direc..., Zach Brown, (Fri Oct 26, 6:30 pm)
Re: [PATCH] Fix bad data from non-direct-io read after direc..., Linus Torvalds, (Fri Oct 26, 6:42 pm)
Re: [PATCH] Fix bad data from non-direct-io read after direc..., Zach Brown, (Fri Oct 26, 6:54 pm)
Re: [PATCH] Fix bad data from non-direct-io read after direc..., Linus Torvalds, (Fri Oct 26, 7:14 pm)
Re: [PATCH] Fix bad data from non-direct-io read after direc..., Zach Brown, (Fri Oct 26, 7:38 pm)
Re: [PATCH] Fix bad data from non-direct-io read after direc..., Karl Schendel, (Fri Oct 26, 7:28 pm)
Re: [PATCH] Fix bad data from non-direct-io read after direc..., Zach Brown, (Tue Oct 30, 2:45 pm)
Re: [PATCH] Fix bad data from non-direct-io read after direc..., Linus Torvalds, (Tue Oct 30, 3:11 pm)
Re: [PATCH] Fix bad data from non-direct-io read after direc..., Karl Schendel, (Fri Oct 26, 6:41 pm)
Re: [PATCH] Fix bad data from non-direct-io read after direc..., Karl Schendel, (Fri Oct 26, 6:10 pm)