Home » Mailing list archives » linux-kernel » 2007 » October » 26

Re: [PATCH] proc: Fix proc_kill_inodes to kill dentries on all proc superblocks

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Eric W. Biederman <ebiederm@...>
To: Linus Torvalds <torvalds@...>
Cc: Andrew Morton <akpm@...>, Al Viro <viro@...>, <linux-kernel@...>, Pavel Emelyanov <xemul@...>, Sukadev Bhattiprolu <sukadev@...>, Linux Containers <containers@...>
Subject: Re: [PATCH] proc: Fix proc_kill_inodes to kill dentries on all proc superblocks
Date: Friday, October 26, 2007 - 2:36 pm

Linus Torvalds <torvalds@linux-foundation.org> writes:


Yes.  I've seen those and I do have some patches in my queue
to address those.  Technically none of those causes us to
do the wrong thing in the presence of multiple proc superblocks,
by the usage of proc_mnt.  It still looks worth it to see
if we can kill all of the users of proc_mnt.

proc_flush_task is technically ok in it's usage of proc_mnt.
It is just using it as what appears to be an unnecessary optimization.
However the added complexity is currently hiding another bug.
We call proc_flush_task_mnt with the wrong arguments.
Further I haven't convinced myself the call to pid_ns_release_proc
does not have some strange race in there, although there is
nothing obviously wrong there.

Eric
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] proc: Fix proc_kill_inodes to kill dentries on all p..., Eric W. Biederman, (Fri Oct 26, 1:48 pm)
Re: [PATCH] proc: Fix proc_kill_inodes to kill dentries on a..., Linus Torvalds, (Fri Oct 26, 2:06 pm)
[PATCH] proc: Simplify and correct proc_flush_task, Eric W. Biederman, (Fri Oct 26, 3:43 pm)
[PATCH] pidns: Limit kill -1 and cap_set_all, Eric W. Biederman, (Fri Oct 26, 4:37 pm)
Re: [PATCH] pidns: Limit kill -1 and cap_set_all, Dave Hansen, (Mon Oct 29, 12:02 pm)
Re: [PATCH] pidns: Limit kill -1 and cap_set_all, Eric W. Biederman, (Mon Oct 29, 1:59 pm)
Re: [PATCH] pidns: Limit kill -1 and cap_set_all, Dave Hansen, (Mon Oct 29, 2:07 pm)
Re: [PATCH] pidns: Limit kill -1 and cap_set_all, Kirill Korotaev, (Mon Oct 29, 4:38 am)
Re: [PATCH] pidns: Limit kill -1 and cap_set_all, Eric W. Biederman, (Mon Oct 29, 2:07 pm)
Re: [PATCH] proc: Fix proc_kill_inodes to kill dentries on a..., Eric W. Biederman, (Fri Oct 26, 2:36 pm)