Regression: commit "ide: constify struct ide_port_info" causes breakage

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <linux-ide@...>, Bartlomiej Zolnierkiewicz <bzolnier@...>, Jeff Garzik <jgarzik@...>, Alan Cox <alan@...>
Cc: Linux Kernel List <linux-kernel@...>, Andrew Morton <akpm@...>, Linus Torvalds <torvalds@...>
Date: Friday, October 26, 2007 - 11:56 am

commit 8562043606430185cad26d085d46adcc7ad67fd1 is broken, causing:

  CC      drivers/ide/pci/cmd64x.o
  CC      drivers/ide/pci/hpt366.o
drivers/ide/pci/hpt366.c:1428: error: hpt366_chipsets causes a section type conflict

and therefore should be reverted.

The problem arises because hpt366 has other data marked with __devinitdata,
so the compiler tries to define the initdata section with read-write
attributes at one point, and read-only attributes when encountering the
const-but-devinitdata declaration:

static struct hpt_info hpt36x __devinitdata = {
static struct hpt_info hpt370 __devinitdata = {
static struct hpt_info hpt370a __devinitdata = {
...
static const struct ide_port_info hpt366_chipsets[] __devinitdata = {

If we want ide_port_info to be read-only initdata, then we need
__devroinitdata and __roinitdata tags.

Note: it doesn't show up in cmd64x.c because that file contains no other
data marked as initdata or devinitdata.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Regression: commit "ide: constify struct ide_port_info" caus..., Russell King, (Fri Oct 26, 11:56 am)
Re: Regression: commit "ide: constify struct ide_port_info" ..., Bartlomiej Zolnierkiewicz..., (Fri Oct 26, 2:18 pm)