[patch 2/3] mempolicy: mpol_rebind_policy cleanup

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: David Rientjes
Date: Thursday, October 25, 2007 - 7:14 pm

Set the memory policy nodemask to the new nodemask on rebind only in one
place.  The only memory policy that does not need an associated mpolmask
is MPOL_DEFAULT.

Cc: Andi Kleen <ak@suse.de>
Cc: Christoph Lameter <clameter@sgi.com>
Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
Signed-off-by: Paul Jackson <pj@sgi.com>
Signed-off-by: David Rientjes <rientjes@google.com>
---
 mm/mempolicy.c |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/mm/mempolicy.c b/mm/mempolicy.c
--- a/mm/mempolicy.c
+++ b/mm/mempolicy.c
@@ -1741,14 +1741,12 @@ static void mpol_rebind_policy(struct mempolicy *pol,
 	case MPOL_INTERLEAVE:
 		nodes_remap(tmp, pol->v.nodes, *mpolmask, *newmask);
 		pol->v.nodes = tmp;
-		*mpolmask = *newmask;
 		current->il_next = node_remap(current->il_next,
 						*mpolmask, *newmask);
 		break;
 	case MPOL_PREFERRED:
 		pol->v.preferred_node = node_remap(pol->v.preferred_node,
 						*mpolmask, *newmask);
-		*mpolmask = *newmask;
 		break;
 	case MPOL_BIND: {
 		nodemask_t nodes;
@@ -1773,13 +1771,14 @@ static void mpol_rebind_policy(struct mempolicy *pol,
 			kfree(pol->v.zonelist);
 			pol->v.zonelist = zonelist;
 		}
-		*mpolmask = *newmask;
 		break;
 	}
 	default:
 		BUG();
 		break;
 	}
+	if (pol->policy != MPOL_DEFAULT)
+		*mpolmask = *newmask;
 }
 
 /*
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[patch 2/3] mempolicy: mpol_rebind_policy cleanup, David Rientjes, (Thu Oct 25, 7:14 pm)
[patch 3/3] cpusets: add memory_spread_user option, David Rientjes, (Thu Oct 25, 7:14 pm)
Re: [patch 2/3] mempolicy: mpol_rebind_policy cleanup, Paul Jackson, (Thu Oct 25, 7:46 pm)
Re: [patch 3/3] cpusets: add memory_spread_user option, Paul Jackson, (Thu Oct 25, 11:04 pm)
Re: [patch 3/3] cpusets: add memory_spread_user option, David Rientjes, (Fri Oct 26, 2:23 am)
Re: [patch 3/3] cpusets: add memory_spread_user option, Paul Jackson, (Fri Oct 26, 2:56 am)
Re: [patch 3/3] cpusets: add memory_spread_user option, Paul Jackson, (Fri Oct 26, 10:18 am)
Re: [patch 3/3] cpusets: add memory_spread_user option, Christoph Lameter, (Fri Oct 26, 10:39 am)
Re: [patch 3/3] cpusets: add memory_spread_user option, Paul Jackson, (Fri Oct 26, 10:43 am)
Re: [patch 3/3] cpusets: add memory_spread_user option, Lee Schermerhorn, (Fri Oct 26, 10:43 am)
Re: [patch 3/3] cpusets: add memory_spread_user option, Paul Jackson, (Fri Oct 26, 10:54 am)
Re: [patch 3/3] cpusets: add memory_spread_user option, Christoph Lameter, (Fri Oct 26, 11:00 am)
Re: [patch 3/3] cpusets: add memory_spread_user option, Lee Schermerhorn, (Fri Oct 26, 1:39 pm)
Re: [patch 3/3] cpusets: add memory_spread_user option, David Rientjes, (Fri Oct 26, 1:41 pm)