Re: [PATCH 01/31] Add an ERR_CAST() macro to complement ERR_PTR and co. [try #5]

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Roland Dreier
Date: Thursday, October 25, 2007 - 4:38 pm

> > +static inline void *ERR_CAST(const void *ptr)
 > > +{
 > > +	return (void *) ptr;
 > > +}
 > 
 > Just to nit, surely you don't need the cast inside the function.  The
 > casting happens at the call site between the argument and returned pointer.

The way it's written you kinda do, since it takes a const void * and
returns a plain void *.  But I don't think that's the best way to
write it.
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 00/31] Remove iget() and read_inode() [try #5], David Howells, (Thu Oct 25, 9:33 am)
[PATCH 04/31] IGET: Use iget_failed() in AFS [try #5], David Howells, (Thu Oct 25, 9:34 am)
[PATCH 05/31] IGET: Use iget_failed() in GFS2 [try #5], David Howells, (Thu Oct 25, 9:34 am)
Re: [PATCH 01/31] Add an ERR_CAST() macro to complement ER ..., Roland Dreier, (Thu Oct 25, 4:38 pm)