Uvesafb and token-ring in 2.6.24-rc1 broken

Previous thread: Announce loop-AES-v3.2b file/swap crypto package by Jari Ruusu on Thursday, October 25, 2007 - 2:36 pm. (1 message)

Next thread: [SUPERH / PATA / SCSI] Unable to do start userland after kernel boot by Kristoffer Ericson on Friday, October 26, 2007 - 12:22 am. (4 messages)
To: <linux-kernel@...>
Cc: Jeff Garzik <jeff@...>, Michal Januszewski <spock@...>
Date: Thursday, October 25, 2007 - 2:37 pm

Hi!

Like always, pleas CC me as I'm currently not suscribed, I hope I got the
right persons already in list.

When booting my new shiny 2.6.24-rc1 I get a crash if uvesafb is compiled in.
The trace mentiones something about "platform_match", so I guess this is due
x86 unification.
If helpfull I could try getting something over netconsole, but I think this is
a minor glitch, as vesafb boots fine. :)

Ah, and token ring tells me something like
"/net/token-ring ,3.14 sysctl failed check procname does not match binary path
procname"
But kernel boots otherwise and I got no chance to test tr itself is working.

--
Greetings
Daniel Exner
-

To: <webmaster@...>, akpm <akpm@...>, Eric W. Biederman <ebiederm@...>
Cc: Daniel Exner <dex@...>, <linux-kernel@...>, Jeff Garzik <jeff@...>, Michal Januszewski <spock@...>
Date: Sunday, October 28, 2007 - 6:25 pm

From: Randy Dunlap <randy.dunlap@oracle.com>
cc: Eric W. Biederman <ebiederm@xmission.com>

Correct the token-ring sysctl procname.

Reported by: Daniel Exner <dex@dragonslave.de>:

Ah, and token ring tells me something like
"/net/token-ring ,3.14 sysctl failed check procname does not match binary path
procname"
But kernel boots otherwise and I got no chance to test tr itself is working.

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
kernel/sysctl_check.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-2.6.24-rc1.orig/kernel/sysctl_check.c
+++ linux-2.6.24-rc1/kernel/sysctl_check.c
@@ -738,7 +738,7 @@ static struct trans_ctl_table trans_net_
{ NET_ROSE, "rose", trans_net_rose_table },
{ NET_IPV6, "ipv6", trans_net_ipv6_table },
{ NET_X25, "x25", trans_net_x25_table },
- { NET_TR, "tr", trans_net_tr_table },
+ { NET_TR, "token-ring", trans_net_tr_table },
{ NET_DECNET, "decnet", trans_net_decnet_table },
/* NET_ECONET not used */
{ NET_SCTP, "sctp", trans_net_sctp_table },
-

To: Randy Dunlap <randy.dunlap@...>
Cc: <webmaster@...>, akpm <akpm@...>, Daniel Exner <dex@...>, <linux-kernel@...>, Jeff Garzik <jeff@...>, Michal Januszewski <spock@...>
Date: Sunday, October 28, 2007 - 6:44 pm

Acked-by: "Eric W. Biederman" <ebiederm@xmission.com>

"token-ring" is the historical name we have used in /proc/sys despite it
being abbreviated tr in the kernel. So this fix is definitely
correct.

Sorry about that. Given this bug and the atalk bug it looks like
I failed to QA the number to name mapping properly under net/.
I just looked at those entries again and I don't see any other
entries under net/ that have problems.

Hopefully this is the last of my silly bugs in this table.

-

Previous thread: Announce loop-AES-v3.2b file/swap crypto package by Jari Ruusu on Thursday, October 25, 2007 - 2:36 pm. (1 message)

Next thread: [SUPERH / PATA / SCSI] Unable to do start userland after kernel boot by Kristoffer Ericson on Friday, October 26, 2007 - 12:22 am. (4 messages)