This patch fixes the c_entry_count counter of the mbcache. Currently
it increments the counter first & allocate the cache entry later. In
case of failure to allocate the entry due to insufficient memory this
counter is still left incremented. This patch fixes this anomaly.

Signed-off-by: Ram Gupta <ram.gupta5@gmail.com>
---------------
--- linux-2.6.23.1/fs/mbcache.c.orig    2007-10-25 09:19:28.000000000 -0500
+++ linux-2.6.23.1/fs/mbcache.c 2007-10-25 09:19:59.000000000 -0500
@@ -403,9 +403,9 @@ mb_cache_entry_alloc(struct mb_cache *ca
 {
        struct mb_cache_entry *ce;

-       atomic_inc(&cache->c_entry_count);
        ce = kmem_cache_alloc(cache->c_entry_cache, GFP_KERNEL);
        if (ce) {
+               atomic_inc(&cache->c_entry_count);
                INIT_LIST_HEAD(&ce->e_lru_list);
                INIT_LIST_HEAD(&ce->e_block_list);
                ce->e_cache = cache;

Thanks
Ram Gupta
-
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/