Home » Mailing list archives » linux-kernel » 2007 » October » 25

Re: [2.6 patch] unexport tick_nohz_get_sleep_length

Previous thread: [2.6 patch] #if 0 sctp_update_copy_cksum() by Adrian Bunk on Wednesday, October 24, 2007 - 9:24 am. (3 messages)

Next thread: [2.6 patch] unexport icmpmsg_statistics by Adrian Bunk on Wednesday, October 24, 2007 - 9:24 am. (11 messages)
[view original message]
From: Adrian Bunk
Subject: [2.6 patch] unexport tick_nohz_get_sleep_length
Date: Wednesday, October 24, 2007 - 9:24 am

This patch removes the unused 
EXPORT_SYMBOL_GPL(tick_nohz_get_sleep_length).

Signed-off-by: Adrian Bunk <bunk@kernel.org>

---
f7c83dfe117f4fd072b2506ae090e4145abda362 
diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c
index 10a1347..5997456 100644
--- a/kernel/time/tick-sched.c
+++ b/kernel/time/tick-sched.c
@@ -320,8 +320,6 @@ ktime_t tick_nohz_get_sleep_length(void)
 	return ts->sleep_length;
 }
 
-EXPORT_SYMBOL_GPL(tick_nohz_get_sleep_length);
-
 /**
  * nohz_restart_sched_tick - restart the idle tick from the idle task
  *

-


[ message continues ]
[view original message]
From: Thomas Gleixner
Subject: Re: [2.6 patch] unexport tick_nohz_get_sleep_length
Date: Thursday, October 25, 2007 - 2:28 am

Hmm, this was added to allow the cpuidle governers modular
build. Seems this was changed to compiled in only.

Len, Venki, is this the final decision ?

     tglx
-


[ message continues ]
[view original message]
From: Pallipadi, Venkatesh
Subject: RE: [2.6 patch] unexport tick_nohz_get_sleep_length
Date: Thursday, October 25, 2007 - 9:51 am

Yes. This was done recently for proper fallback to old ACPI policy in
case CPUIDLE is not selected. With that being module, falling back to
ACPI policy at run time makes things ugly.

Thanks,
Venki
-


[ message continues ]
[view original message]
From: Thomas Gleixner
Subject: RE: [2.6 patch] unexport tick_nohz_get_sleep_length
Date: Thursday, October 25, 2007 - 9:56 am

Makes sense. I go ahead and nuke the export.

Thanks,

	tglx
-


[ message continues ]
[view original message]
From: Len Brown
Subject: Re: [2.6 patch] unexport tick_nohz_get_sleep_length
Date: Thursday, October 25, 2007 - 2:40 pm

Applied.

thanks,
-Len

-


[ message continues ]
Previous thread: [2.6 patch] #if 0 sctp_update_copy_cksum() by Adrian Bunk on Wednesday, October 24, 2007 - 9:24 am. (3 messages)

Next thread: [2.6 patch] unexport icmpmsg_statistics by Adrian Bunk on Wednesday, October 24, 2007 - 9:24 am. (11 messages)