Home » Mailing list archives » linux-kernel » 2007 » October » 25

[PATCH] Remove #warnings for longstanding conditions.

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Jeff Garzik
Subject: [PATCH] Remove #warnings for longstanding conditions.
Date: Thursday, October 25, 2007 - 1:06 am

These two warnings...

drivers/isdn/capi/capidrv.c:2126:3: warning: #warning FIXME: maybe a
race condition the card should be removed here from global list /kkeil

drivers/scsi/advansys.c:71:2: warning: #warning this driver is still
not properly converted to the DMA API

...represent conditions that have existed for years, and are duly noted
in FIXMEs.  There does not seem to be much need to warn on every kernel
build for a driver bug or handicap that has existed for years.

Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
---
 drivers/isdn/capi/capidrv.c |    3 ++-
 drivers/scsi/advansys.c     |    1 -
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/isdn/capi/capidrv.c b/drivers/isdn/capi/capidrv.c
index 476012b..44f954d 100644
--- a/drivers/isdn/capi/capidrv.c
+++ b/drivers/isdn/capi/capidrv.c
@@ -2123,7 +2123,8 @@ static int capidrv_delcontr(u16 contr)
 		printk(KERN_ERR "capidrv: delcontr: no contr %u\n", contr);
 		return -1;
 	}
-	#warning FIXME: maybe a race condition the card should be removed here from global list /kkeil
+
+	/* FIXME: maybe a race condition the card should be removed here from global list /kkeil */
 	spin_unlock_irqrestore(&global_lock, flags);
 
 	del_timer(&card->listentimer);
diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c
index 9dd3952..e13e3a8 100644
--- a/drivers/scsi/advansys.c
+++ b/drivers/scsi/advansys.c
@@ -68,7 +68,6 @@
  *  7. advansys_info is not safe against multiple simultaneous callers
  *  8. Add module_param to override ISA/VLB ioport array
  */
-#warning this driver is still not properly converted to the DMA API
 
 /* Enable driver /proc statistics. */
 #define ADVANSYS_STATS
-- 
1.5.2.4

-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] sound/oss/sb_common.c: fix casting warning, Jeff Garzik, (Thu Oct 25, 1:06 am)
[PATCH] Permit silencing of __deprecated warnings., Jeff Garzik, (Thu Oct 25, 1:06 am)
[PATCH] Remove #warnings for longstanding conditions., Jeff Garzik, (Thu Oct 25, 1:06 am)
[PATCH] ISDN/capidrv: fix casting warning, Jeff Garzik, (Thu Oct 25, 1:06 am)
Re: [PATCH] Permit silencing of __deprecated warnings., Andrew Morton, (Thu Oct 25, 1:15 am)
Re: [PATCH] Permit silencing of __deprecated warnings., Jeff Garzik, (Thu Oct 25, 1:20 am)
Re: [PATCH] ISDN/capidrv: fix casting warning, Karsten Keil, (Thu Oct 25, 2:51 am)
Re: [PATCH] Remove #warnings for longstanding conditions., Karsten Keil, (Thu Oct 25, 2:52 am)
Re: [PATCH] Permit silencing of __deprecated warnings., Sam Ravnborg, (Thu Oct 25, 4:02 am)
Re: [PATCH] Remove #warnings for longstanding conditions., Matthew Wilcox, (Thu Oct 25, 4:22 am)
Re: [PATCH] Permit silencing of __deprecated warnings., Linus Torvalds, (Thu Oct 25, 8:34 am)
Re: [PATCH] ISDN/capidrv: fix casting warning, Jeff Garzik, (Thu Oct 25, 5:53 pm)
Re: [PATCH] Remove #warnings for longstanding conditions., Jeff Garzik, (Thu Oct 25, 7:07 pm)
Re: [PATCH] Remove #warnings for longstanding conditions., Matthew Wilcox, (Thu Oct 25, 7:14 pm)
Re: [PATCH] Remove #warnings for longstanding conditions., Jeff Garzik, (Thu Oct 25, 7:19 pm)
Re: [PATCH] Permit silencing of __deprecated warnings., Arjan van de Ven, (Thu Oct 25, 8:07 pm)