Re: [patch] kvm: fix !SMP build error

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Avi Kivity <avi@...>
Cc: Jeff Garzik <jeff@...>, Adrian Bunk <bunk@...>, LKML <linux-kernel@...>, <akpm@...>, Linus Torvalds <torvalds@...>
Date: Wednesday, October 24, 2007 - 2:11 pm

* Ingo Molnar <mingo@elte.hu> wrote:


plus the patch below is needed too in addition.

	Ingo

------------->
Subject: x86: fix build error in arch/x86/kernel/nmi_32.c
From: Ingo Molnar <mingo@elte.hu>

nmi_cpu_busy() must be available on !SMP too.

Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 arch/x86/kernel/nmi_32.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Index: linux/arch/x86/kernel/nmi_32.c
===================================================================
--- linux.orig/arch/x86/kernel/nmi_32.c
+++ linux/arch/x86/kernel/nmi_32.c
@@ -53,13 +53,13 @@ static int unknown_nmi_panic_callback(st
 
 static int endflag __initdata = 0;
 
-#ifdef CONFIG_SMP
 /* The performance counters used by NMI_LOCAL_APIC don't trigger when
  * the CPU is idle. To make sure the NMI watchdog really ticks on all
  * CPUs during the test make them busy.
  */
 static __init void nmi_cpu_busy(void *data)
 {
+#ifdef CONFIG_SMP
 	local_irq_enable_in_hardirq();
 	/* Intentionally don't use cpu_relax here. This is
 	   to make sure that the performance counter really ticks,
@@ -69,8 +69,8 @@ static __init void nmi_cpu_busy(void *da
 	   care if they get somewhat less cycles. */
 	while (endflag == 0)
 		mb();
-}
 #endif
+}
 
 static int __init check_nmi_watchdog(void)
 {
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 6/12] KVM: work around SMP requirement, Jeff Garzik, (Tue Oct 23, 6:36 pm)
Re: [PATCH 6/12] KVM: work around SMP requirement, Adrian Bunk, (Tue Oct 23, 6:44 pm)
Re: [PATCH 6/12] KVM: work around SMP requirement, Jeff Garzik, (Tue Oct 23, 6:46 pm)
Re: [PATCH 6/12] KVM: work around SMP requirement, Avi Kivity, (Wed Oct 24, 4:36 am)
[patch] kvm: fix !SMP build error, Ingo Molnar, (Wed Oct 24, 8:32 am)
Re: [patch] kvm: fix !SMP build error, Ingo Molnar, (Wed Oct 24, 8:36 am)
Re: [patch] kvm: fix !SMP build error, Ingo Molnar, (Wed Oct 24, 2:11 pm)
Re: [patch] kvm: fix !SMP build error, Randy Dunlap, (Wed Oct 31, 11:34 pm)
Re: [patch] kvm: fix !SMP build error, Ingo Molnar, (Thu Nov 1, 4:31 am)
Re: [patch] kvm: fix !SMP build error, Avi Kivity, (Thu Nov 1, 9:10 am)
Re: [patch] kvm: fix !SMP build error, Ingo Molnar, (Thu Nov 1, 10:59 am)
Re: [patch] kvm: fix !SMP build error, Avi Kivity, (Thu Nov 1, 5:16 pm)