Re: 2.6.24-rc1 fails with lockup and BUG:

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Romano Giannetti <romanol@...>
Cc: Linux Kernel Mailing List <linux-kernel@...>
Date: Wednesday, October 24, 2007 - 12:44 pm

On Wed, Oct 24, 2007 at 03:25:44PM +0200, Romano Giannetti wrote:


Denis V. Lunev wrote a patch for the NetworkManager thing a day or two
ago (which DaveM has queued).

Since netlink is involved in the traces you sent, this might do something
for the other too.

The patch I recieved follows:







diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c
index 98e313e..44a8b41 100644
--- a/net/netlink/af_netlink.c
+++ b/net/netlink/af_netlink.c
@@ -1565,7 +1565,10 @@ int netlink_dump_start(struct sock *ssk, struct sk_buff *skb,
 
 	netlink_dump(sk);
 	sock_put(sk);
-	return 0;
+
+	/* We successfully started a dump, by returning -EINTR we
+	 * signal not to send ACK even if it was requested */
+	return -EINTR;
 }
 
 void netlink_ack(struct sk_buff *in_skb, struct nlmsghdr *nlh, int err)
@@ -1619,17 +1622,21 @@ int netlink_rcv_skb(struct sk_buff *skb, int (*cb)(struct sk_buff *,
 
 		/* Only requests are handled by the kernel */
 		if (!(nlh->nlmsg_flags & NLM_F_REQUEST))
-			goto skip;
+			goto ack;
 
 		/* Skip control messages */
 		if (nlh->nlmsg_type < NLMSG_MIN_TYPE)
-			goto skip;
+			goto ack;
 
 		err = cb(skb, nlh);
-skip:
+		if (err == -EINTR)
+			goto skip;
+
+ack:
 		if (nlh->nlmsg_flags & NLM_F_ACK || err)
 			netlink_ack(skb, nlh, err);
 
+skip:
 	        msglen = NLMSG_ALIGN(nlh->nlmsg_len);
 		if (msglen > skb->len)
 			msglen = skb->len;





--
Joseph Fannin
jfannin@gmail.com
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Linux v2.6.24-rc1, Linus Torvalds, (Wed Oct 24, 12:19 am)
Re: Linux v2.6.24-rc1, , (Thu Oct 25, 8:45 am)
2.6.24-rc1 doesn't build..., Theodore Tso, (Thu Oct 25, 1:18 am)
Re: 2.6.24-rc1 doesn't build..., Kamalesh Babulal, (Thu Oct 25, 1:30 am)
[patch] portman2x4.c: fix boot hang, Ingo Molnar, (Wed Oct 24, 3:44 pm)
Re: [patch] portman2x4.c: fix boot hang, Takashi Iwai, (Thu Oct 25, 4:16 am)
Re: [patch] portman2x4.c: fix boot hang, Frans Pop, (Wed Oct 24, 4:12 pm)
Re: [patch] portman2x4.c: fix boot hang, Ingo Molnar, (Wed Oct 24, 5:29 pm)
Re: Linux v2.6.24-rc1, Giacomo Catenazzi, (Wed Oct 24, 2:19 pm)
Re: [Bug 9246] On 2.6.24-rc1-gc9927c2b BUG: unable to handle..., Giacomo A. Catenazzi, (Tue Dec 4, 12:47 pm)
Re: [Bug 9246] On 2.6.24-rc1-gc9927c2b BUG: unable to handle..., Giacomo A. Catenazzi, (Wed Dec 5, 5:26 am)
2.6.24-rc1 fails with lockup and BUG:, Romano Giannetti, (Wed Oct 24, 9:25 am)
Re: 2.6.24-rc1 fails with lockup and BUG:, Joseph Fannin, (Wed Oct 24, 12:44 pm)
Re: 2.6.24-rc1 fails with lockup and BUG:, Romano Giannetti, (Fri Oct 26, 1:59 am)
Re: 2.6.24-rc1 fails with lockup and BUG:, Ingo Molnar, (Wed Oct 24, 10:27 am)
Re: 2.6.24-rc1 fails with lockup and BUG:, Romano Giannetti, (Wed Oct 24, 11:53 am)
Re: 2.6.24-rc1 fails with lockup and BUG:, Ingo Molnar, (Wed Oct 24, 11:55 am)
Re: 2.6.24-rc1 fails with lockup and BUG:, Peter Zijlstra, (Wed Oct 24, 12:11 pm)
Re: 2.6.24-rc1 fails with lockup and BUG:, Romano Giannetti, (Fri Oct 26, 1:57 am)
Re: 2.6.24-rc1 fails with lockup - /sbin/ifconfig / inet_ioc..., Stephen Hemminger, (Fri Oct 26, 12:48 pm)
[PATCH] r8169: don't call napi_disable if not doing NAPI, Stephen Hemminger, (Fri Oct 26, 2:33 pm)
Re: [PATCH] r8169: don't call napi_disable if not doing NAPI, Romano Giannetti, (Mon Oct 29, 4:56 am)
Re: [PATCH] r8169: don't call napi_disable if not doing NAPI, Romano Giannetti, (Sun Oct 28, 6:18 pm)
Re: [PATCH] r8169: don't call napi_disable if not doing NAPI, Francois Romieu, (Fri Oct 26, 4:17 pm)
[git pull] x86 arch updates, Ingo Molnar, (Wed Oct 24, 7:30 am)
Re: [git pull] x86 arch updates, Jeff Garzik, (Wed Oct 24, 7:48 am)
Re: [git pull] x86 arch updates, Ingo Molnar, (Wed Oct 24, 8:03 am)
Re: Linux v2.6.24-rc1, Christoph Hellwig, (Wed Oct 24, 4:04 am)
Re: Linux v2.6.24-rc1, Sam Ravnborg, (Wed Oct 24, 7:07 am)
Re: Linux v2.6.24-rc1, Ingo Molnar, (Wed Oct 24, 8:12 am)
Re: Linux v2.6.24-rc1, Sam Ravnborg, (Wed Oct 24, 8:21 am)
Re: Linux v2.6.24-rc1, Ingo Molnar, (Wed Oct 24, 4:04 am)
Re: Linux v2.6.24-rc1, Dave Young, (Wed Oct 24, 1:22 am)
Re: Linux v2.6.24-rc1, Ingo Molnar, (Wed Oct 24, 3:23 am)
Re: Linux v2.6.24-rc1, Jens Axboe, (Wed Oct 24, 4:12 am)
Re: Linux v2.6.24-rc1, Dave Young, (Wed Oct 24, 3:33 am)
Re: Linux v2.6.24-rc1, Ohad Ben-Cohen, (Wed Oct 24, 3:32 am)
Re: Linux v2.6.24-rc1, Willy Tarreau, (Wed Oct 24, 12:49 am)