Re: 2.6.24-rc1 fails with lockup and BUG:

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Ingo Molnar <mingo@...>
Cc: Romano Giannetti <romanol@...>, Linux Kernel Mailing List <linux-kernel@...>
Date: Wednesday, October 24, 2007 - 12:11 pm

On Wed, 2007-10-24 at 17:55 +0200, Ingo Molnar wrote:

Does this help?

---
Subject: lockdep: invalid irq usage

this function can be called from hardirq context.

Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
---

Index: linux-2.6-2/kernel/sched_debug.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- linux-2.6-2.orig/kernel/sched_debug.c
+++ linux-2.6-2/kernel/sched_debug.c
@@ -80,6 +80,7 @@ print_task(struct seq_file *m, struct rq
 static void print_rq(struct seq_file *m, struct rq *rq, int rq_cpu)
 {
 	struct task_struct *g, *p;
+	unsigned long flags;
=20
 	SEQ_printf(m,
 	"\nrunnable tasks:\n"
@@ -88,7 +89,7 @@ static void print_rq(struct seq_file *m,
 	"------------------------------------------------------"
 	"----------------------------------------------------\n");
=20
-	read_lock_irq(&tasklist_lock);
+	read_lock_irqsave(&tasklist_lock, flags);
=20
 	do_each_thread(g, p) {
 		if (!p->se.on_rq || task_cpu(p) !=3D rq_cpu)
@@ -97,7 +98,7 @@ static void print_rq(struct seq_file *m,
 		print_task(m, rq, p);
 	} while_each_thread(g, p);
=20
-	read_unlock_irq(&tasklist_lock);
+	read_unlock_irqrestore(&tasklist_lock, flags);
 }
=20
 void print_cfs_rq(struct seq_file *m, int cpu, struct cfs_rq *cfs_rq)
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Linux v2.6.24-rc1, Linus Torvalds, (Wed Oct 24, 12:19 am)
Re: Linux v2.6.24-rc1, , (Thu Oct 25, 8:45 am)
2.6.24-rc1 doesn't build..., Theodore Tso, (Thu Oct 25, 1:18 am)
Re: 2.6.24-rc1 doesn't build..., Kamalesh Babulal, (Thu Oct 25, 1:30 am)
[patch] portman2x4.c: fix boot hang, Ingo Molnar, (Wed Oct 24, 3:44 pm)
Re: [patch] portman2x4.c: fix boot hang, Takashi Iwai, (Thu Oct 25, 4:16 am)
Re: [patch] portman2x4.c: fix boot hang, Frans Pop, (Wed Oct 24, 4:12 pm)
Re: [patch] portman2x4.c: fix boot hang, Ingo Molnar, (Wed Oct 24, 5:29 pm)
Re: Linux v2.6.24-rc1, Giacomo Catenazzi, (Wed Oct 24, 2:19 pm)
Re: [Bug 9246] On 2.6.24-rc1-gc9927c2b BUG: unable to handle..., Giacomo A. Catenazzi, (Tue Dec 4, 12:47 pm)
Re: [Bug 9246] On 2.6.24-rc1-gc9927c2b BUG: unable to handle..., Giacomo A. Catenazzi, (Wed Dec 5, 5:26 am)
2.6.24-rc1 fails with lockup and BUG:, Romano Giannetti, (Wed Oct 24, 9:25 am)
Re: 2.6.24-rc1 fails with lockup and BUG:, Joseph Fannin, (Wed Oct 24, 12:44 pm)
Re: 2.6.24-rc1 fails with lockup and BUG:, Romano Giannetti, (Fri Oct 26, 1:59 am)
Re: 2.6.24-rc1 fails with lockup and BUG:, Ingo Molnar, (Wed Oct 24, 10:27 am)
Re: 2.6.24-rc1 fails with lockup and BUG:, Romano Giannetti, (Wed Oct 24, 11:53 am)
Re: 2.6.24-rc1 fails with lockup and BUG:, Ingo Molnar, (Wed Oct 24, 11:55 am)
Re: 2.6.24-rc1 fails with lockup and BUG:, Peter Zijlstra, (Wed Oct 24, 12:11 pm)
Re: 2.6.24-rc1 fails with lockup and BUG:, Romano Giannetti, (Fri Oct 26, 1:57 am)
Re: 2.6.24-rc1 fails with lockup - /sbin/ifconfig / inet_ioc..., Stephen Hemminger, (Fri Oct 26, 12:48 pm)
[PATCH] r8169: don't call napi_disable if not doing NAPI, Stephen Hemminger, (Fri Oct 26, 2:33 pm)
Re: [PATCH] r8169: don't call napi_disable if not doing NAPI, Romano Giannetti, (Mon Oct 29, 4:56 am)
Re: [PATCH] r8169: don't call napi_disable if not doing NAPI, Romano Giannetti, (Sun Oct 28, 6:18 pm)
Re: [PATCH] r8169: don't call napi_disable if not doing NAPI, Francois Romieu, (Fri Oct 26, 4:17 pm)
[git pull] x86 arch updates, Ingo Molnar, (Wed Oct 24, 7:30 am)
Re: [git pull] x86 arch updates, Jeff Garzik, (Wed Oct 24, 7:48 am)
Re: [git pull] x86 arch updates, Ingo Molnar, (Wed Oct 24, 8:03 am)
Re: Linux v2.6.24-rc1, Christoph Hellwig, (Wed Oct 24, 4:04 am)
Re: Linux v2.6.24-rc1, Sam Ravnborg, (Wed Oct 24, 7:07 am)
Re: Linux v2.6.24-rc1, Ingo Molnar, (Wed Oct 24, 8:12 am)
Re: Linux v2.6.24-rc1, Sam Ravnborg, (Wed Oct 24, 8:21 am)
Re: Linux v2.6.24-rc1, Ingo Molnar, (Wed Oct 24, 4:04 am)
Re: Linux v2.6.24-rc1, Dave Young, (Wed Oct 24, 1:22 am)
Re: Linux v2.6.24-rc1, Ingo Molnar, (Wed Oct 24, 3:23 am)
Re: Linux v2.6.24-rc1, Jens Axboe, (Wed Oct 24, 4:12 am)
Re: Linux v2.6.24-rc1, Dave Young, (Wed Oct 24, 3:33 am)
Re: Linux v2.6.24-rc1, Ohad Ben-Cohen, (Wed Oct 24, 3:32 am)
Re: Linux v2.6.24-rc1, Willy Tarreau, (Wed Oct 24, 12:49 am)