Re: [patch] kvm: fix !SMP build error

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Avi Kivity <avi@...>
Cc: Jeff Garzik <jeff@...>, Adrian Bunk <bunk@...>, LKML <linux-kernel@...>, <akpm@...>, Linus Torvalds <torvalds@...>
Date: Wednesday, October 24, 2007 - 8:36 am

* Ingo Molnar <mingo@elte.hu> wrote:


and this followup patch is needed too if my patch is applied.

	Ingo

------------------->
Subject: x86: fix build error in arch/x86/kernel/cpu/mtrr/main.c
From: Ingo Molnar <mingo@elte.hu>

ipi_handler() must be available on !SMP too.

Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 arch/x86/kernel/cpu/mtrr/main.c |    6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

Index: linux/arch/x86/kernel/cpu/mtrr/main.c
===================================================================
--- linux.orig/arch/x86/kernel/cpu/mtrr/main.c
+++ linux/arch/x86/kernel/cpu/mtrr/main.c
@@ -139,13 +139,12 @@ struct set_mtrr_data {
 	mtrr_type	smp_type;
 };
 
-#ifdef CONFIG_SMP
-
 static void ipi_handler(void *info)
 /*  [SUMMARY] Synchronisation handler. Executed by "other" CPUs.
     [RETURNS] Nothing.
 */
 {
+#ifdef CONFIG_SMP
 	struct set_mtrr_data *data = info;
 	unsigned long flags;
 
@@ -168,9 +167,8 @@ static void ipi_handler(void *info)
 
 	atomic_dec(&data->count);
 	local_irq_restore(flags);
-}
-
 #endif
+}
 
 static inline int types_compatible(mtrr_type type1, mtrr_type type2) {
 	return type1 == MTRR_TYPE_UNCACHABLE ||
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 6/12] KVM: work around SMP requirement, Jeff Garzik, (Tue Oct 23, 6:36 pm)
Re: [PATCH 6/12] KVM: work around SMP requirement, Adrian Bunk, (Tue Oct 23, 6:44 pm)
Re: [PATCH 6/12] KVM: work around SMP requirement, Jeff Garzik, (Tue Oct 23, 6:46 pm)
Re: [PATCH 6/12] KVM: work around SMP requirement, Avi Kivity, (Wed Oct 24, 4:36 am)
[patch] kvm: fix !SMP build error, Ingo Molnar, (Wed Oct 24, 8:32 am)
Re: [patch] kvm: fix !SMP build error, Ingo Molnar, (Wed Oct 24, 8:36 am)
Re: [patch] kvm: fix !SMP build error, Ingo Molnar, (Wed Oct 24, 2:11 pm)
Re: [patch] kvm: fix !SMP build error, Randy Dunlap, (Wed Oct 31, 11:34 pm)
Re: [patch] kvm: fix !SMP build error, Ingo Molnar, (Thu Nov 1, 4:31 am)
Re: [patch] kvm: fix !SMP build error, Avi Kivity, (Thu Nov 1, 9:10 am)
Re: [patch] kvm: fix !SMP build error, Ingo Molnar, (Thu Nov 1, 10:59 am)
Re: [patch] kvm: fix !SMP build error, Avi Kivity, (Thu Nov 1, 5:16 pm)