[PATCH] Remove bogus default y for DMAR and NET_DMA

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <linux-kernel@...>
Cc: <akpm@...>, <shannon.nelson@...>, <anil.s.keshavamurthy@...>
Date: Wednesday, October 24, 2007 - 5:12 am

Andrew, please queue for next merge. Thanks.

----

No reason I can think of of making them default y
Most people don't have the hardware and with default y they
just pollute lots of configs during make oldconfig.

Signed-off-by: Andi Kleen <ak@suse.de>

Index: linux-2.6.24-rc1-hack/arch/x86_64/Kconfig
===================================================================
--- linux-2.6.24-rc1-hack.orig/arch/x86_64/Kconfig
+++ linux-2.6.24-rc1-hack/arch/x86_64/Kconfig
@@ -753,7 +753,6 @@ config PCI_DOMAINS
 config DMAR
 	bool "Support for DMA Remapping Devices (EXPERIMENTAL)"
 	depends on PCI_MSI && ACPI && EXPERIMENTAL
-	default y
 	help
 	  DMA remapping (DMAR) devices support enables independent address
 	  translations for Direct Memory Access (DMA) from devices.
Index: linux-2.6.24-rc1-hack/drivers/dma/Kconfig
===================================================================
--- linux-2.6.24-rc1-hack.orig/drivers/dma/Kconfig
+++ linux-2.6.24-rc1-hack/drivers/dma/Kconfig
@@ -43,7 +43,6 @@ comment "DMA Clients"
 config NET_DMA
 	bool "Network: TCP receive copy offload"
 	depends on DMA_ENGINE && NET
-	default y
 	help
 	  This enables the use of DMA engines in the network stack to
 	  offload receive copy-to-user operations, freeing CPU cycles.
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] Remove bogus default y for DMAR and NET_DMA, Andi Kleen, (Wed Oct 24, 5:12 am)
RE: [PATCH] Remove bogus default y for DMAR and NET_DMA, Nelson, Shannon, (Wed Oct 24, 11:28 am)