Re: [RFC PATCH 4/5] Remove CPU_DEAD/CPU_UP_CANCELLED handling from workqueue.c

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <ego@...>
Cc: Linus Torvalds <torvalds@...>, Andrew Morton <akpm@...>, <linux-kernel@...>, Srivatsa Vaddagiri <vatsa@...>, Dipankar Sarma <dipankar@...>, Ingo Molnar <mingo@...>, Oleg Nesterov <oleg@...>
Date: Wednesday, October 24, 2007 - 3:21 am

On Wednesday 24 October 2007 15:37:16 Gautham R Shenoy wrote:

Hi Gautham!

	This works, although the change is unnecessary.  If you're going to
do this I'd prefer "if (set_cpus_allowed(p, cpumask_of_cpu(cpu)) != 0) 
BUG();".

Cheers,
Rusty.
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[RFC PATCH 0/5] Refcount based Cpu Hotplug. V2, Gautham R Shenoy, (Wed Oct 24, 1:29 am)
Re: [RFC PATCH 0/5] Refcount based Cpu Hotplug. V2, Christoph Lameter, (Wed Oct 24, 1:04 pm)
Re: [RFC PATCH 0/5] Refcount based Cpu Hotplug. V2, Gautham R Shenoy, (Wed Oct 24, 2:00 pm)
Re: [RFC PATCH 0/5] Refcount based Cpu Hotplug. V2, Oleg Nesterov, (Wed Oct 24, 2:17 pm)
Re: [RFC PATCH 0/5] Refcount based Cpu Hotplug. V2, Gautham R Shenoy, (Wed Oct 24, 2:22 pm)
Re: [RFC PATCH 4/5] Remove CPU_DEAD/CPU_UP_CANCELLED handlin..., Rusty Russell, (Wed Oct 24, 3:21 am)
[RFC PATCH 1/5] Refcount Based Cpu Hotplug implementation, Gautham R Shenoy, (Wed Oct 24, 1:30 am)