Home » Mailing list archives » linux-kernel » 2007 » October » 24

Re: [PATCH] Fixing the warning in cgroup.c

Previous thread: [GIT-PULL Part #2] Blackfin arch fixing and updates for 2.6.24 merge windows by Bryan Wu on Sunday, October 21, 2007 - 12:53 pm. (2 messages)

Next thread: Re: kbuild: disable depmod in cross-compile kernel build by Geert Uytterhoeven on Sunday, October 21, 2007 - 1:53 pm. (3 messages)
[view original message]
From: Kamalesh Babulal <kamalesh@...>
To: <menage@...>
Cc: Andrew Morton <akpm@...>, Balbir Singh <balbir@...>, <vatsa@...>, Dhaval Giani <dhaval@...>, LKML <linux-kernel@...>
Subject: [PATCH] Fixing the warning in cgroup.c
Date: Sunday, October 21, 2007 - 1:30 pm

Hi,


Removing the unused variable root.


kernel/cgroup.c: In function ‘proc_cgroupstats_show’:

kernel/cgroup.c:2405: warning: unused variable ‘root’


Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>


Index: linux-git/kernel/cgroup.c

===================================================================

--- linux-git.orig/kernel/cgroup.c      2007-10-21 08:49:15.000000000 +0530

+++ linux-git/kernel/cgroup.c   2007-10-21 22:24:13.000000000 +0530

@@ -2402,7 +2402,6 @@ struct file_operations proc_cgroup_opera

 static int proc_cgroupstats_show(struct seq_file *m, void *v)

 {

        int i;

-       struct cgroupfs_root *root;


        seq_puts(m, "#subsys_name\thierarchy\tnum_cgroups\n");

        mutex_lock(&cgroup_mutex);


--

Thanks & Regards,

Kamalesh Babulal,

Linux Technology Center,

IBM, ISTL.


-
[view original message]
From: Andrew Morton <akpm@...>
To: Kamalesh Babulal <kamalesh@...>
Cc: <menage@...>, Balbir Singh <balbir@...>, <vatsa@...>, Dhaval Giani <dhaval@...>, LKML <linux-kernel@...>
Subject: Re: [PATCH] Fixing the warning in cgroup.c
Date: Wednesday, October 24, 2007 - 2:29 am

ERROR: Invalid UTF-8

#3:

kernel/cgroup.c: In function ‘proc_cgroupstats_show’:


ERROR: Invalid UTF-8

#4:

kernel/cgroup.c:2405: warning: unused variable ‘root’


total: 2 errors, 0 warnings, 7 lines checked

Your patch has style problems, please review.  If any of these errors

are false positives report them to the maintainer, see

CHECKPATCH in MAINTAINERS.


your email client is converting tabs to spaces.

-
[view original message]
From: Balbir Singh <balbir@...>
To: Kamalesh Babulal <kamalesh@...>
Cc: <menage@...>, Andrew Morton <akpm@...>, <vatsa@...>, Dhaval Giani <dhaval@...>, LKML <linux-kernel@...>
Subject: Re: [PATCH] Fixing the warning in cgroup.c
Date: Sunday, October 21, 2007 - 1:55 pm

Looks good to me!


Acked-by: Balbir Singh <balbir@linux.vnet.ibm.com>


--

	Warm Regards,

	Balbir Singh

	Linux Technology Center

	IBM, ISTL

-
Previous thread: [GIT-PULL Part #2] Blackfin arch fixing and updates for 2.6.24 merge windows by Bryan Wu on Sunday, October 21, 2007 - 12:53 pm. (2 messages)

Next thread: Re: kbuild: disable depmod in cross-compile kernel build by Geert Uytterhoeven on Sunday, October 21, 2007 - 1:53 pm. (3 messages)