login
Login
/
Register
Search
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2007
»
October
»
24
Re: [PATCH 1/12] X86: fix !CONFIG_SMP warning in processor.c
view
thread
!MAILaRCHIVE_VOTE_RePLACE
Previous message: [
thread
] [
date
] [
author
]
Next message: [thread] [
date
] [
author
]
[view in full thread]
From:
Jeremy Fitzhardinge <jeremy@...>
To: Jeff Garzik <jeff@...>
Cc: LKML <linux-kernel@...>, <akpm@...>, <tglx@...>
Subject:
Re: [PATCH 1/12] X86: fix !CONFIG_SMP warning in processor.c
Date: Wednesday, October 24, 2007 - 12:03 am
Jeff Garzik wrote:
quoted text
> Fix !CONFIG_SMP warning: > > arch/x86/kernel/acpi/processor.c: In function ‘arch_acpi_processor_init_pdc’: > arch/x86/kernel/acpi/processor.c:65: warning: unused variable ‘cpu’ > > Signed-off-by: Jeff Garzik <jgarzik@redhat.com> > --- > Ideally this warning should be hidden inside a wrapper or somesuch, to > camouflage the unneeded argument in !SMP case. > > diff --git a/arch/x86/kernel/acpi/processor.c b/arch/x86/kernel/acpi/processor.c > index 2ed0a4c..45e262a 100644 > --- a/arch/x86/kernel/acpi/processor.c > +++ b/arch/x86/kernel/acpi/processor.c > @@ -62,7 +62,9 @@ static void init_intel_pdc(struct acpi_processor *pr, struct cpuinfo_x86 *c) > /* Initialize _PDC data based on the CPU vendor */ > void arch_acpi_processor_init_pdc(struct acpi_processor *pr) > { > +#ifdef CONFIG_SMP > unsigned int cpu = pr->id; > +#endif > struct cpuinfo_x86 *c = &cpu_data(cpu); >
Surely just replace cpu with pr->id? That's the only use. J -
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [thread] [
date
] [
author
]
Messages in current thread:
[PATCH 1/12] X86: fix !CONFIG_SMP warning in processor.c
, Jeff Garzik
, (Tue Oct 23, 6:36 pm)
[2.6 patch] x86/kernel/acpi/processor.c: fix SMP=n warning
, Adrian Bunk
, (Wed Oct 24, 12:27 pm)
Re: [PATCH 1/12] X86: fix !CONFIG_SMP warning in processor.c
, Ingo Molnar
, (Wed Oct 24, 8:01 am)
Re: [PATCH 1/12] X86: fix !CONFIG_SMP warning in processor.c
, Jeremy Fitzhardinge
, (Wed Oct 24, 12:03 am)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Jon Smirl
463 kernel developers missing!
Nigel Cunningham
Re: [PATCH] Remove process freezer from suspend to RAM pathway
Greg KH
Re: [malware-list] [RFC 0/5] [TALPA] Intro to a linux interface for on access scan...
Jeff Garzik
Re: Linux 2.6.23-rc9 and a heads-up for the 2.6.24 series..
git
:
linux-netdev
:
Jarek Poplawski
[PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Gerrit Renker
[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
Linus Torvalds
Re: [GIT]: Networking
Evgeniy Polyakov
Re: [BUG] New Kernel Bugs
openbsd-misc
:
Colocation donated by:
Who's online
There are currently
2 users
and
933 guests
online.
Online users
Jeremy
dpetersonjr2321
Syndicate