On Wed, 24 Oct 2007 12:11:59 +1000 Gilles Gigan <gilles.gigan@gmail.com> wrote:

quoted text
> +	case WDIOC_SETOPTIONS:{
> +			int retval = -EINVAL;
> +
> +			if (arg & WDIOS_DISABLECARD) {
> +				wdt_disable();
> +				retval = 0;
> +			}
> +
> +			if (arg & WDIOS_ENABLECARD) {
> +				wdt_enable();
> +				retval = 0;
> +			}
> +
> +			return retval;

hrm.  So if userspace does ioctl(..., WDIOS_DISABLECARD|WDIOS_ENABLECARD,
that happens to be equivalent to WDIOS_ENABLECARD?

Do all watchdog drivers do it exactly the same way, or are we offering
inconsistent interfaces between different drivers?

An exceedingly minor point, but fun nonetheless.

(And hey, I had to say _something_)

(apart from directing your attention to scripts/checkpatch.pl)
-
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/