[PATCH] e1000, e1000e valid-addr fixes

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Jeff Garzik
Date: Tuesday, October 23, 2007 - 5:55 pm

Actually, looking over the code I see obvious bugs in the logic:

An invalid ethernet address should not cause device loading to fail, 
because the user is given the opportunity to supply a MAC address via 
userspace (ifconfig or whatever) before the interface goes up.

I just created the attached -bug fix- patch as illustration, though I 
have not committed it, waiting for comment.

This patch will make no difference for users hitting invalid-eep-csum 
rather than invalid-MAC-addr condition, but it's a problem I noticed 
while reviewing Adam's patch in detail.

	Jeff
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [PATCH] Add eeprom_bad_csum_allow module option to e1000., Stephen Hemminger, (Tue Oct 23, 4:53 pm)
[PATCH] e1000, e1000e valid-addr fixes, Jeff Garzik, (Tue Oct 23, 5:55 pm)
Re: [PATCH] e1000, e1000e valid-addr fixes, Jeff Garzik, (Tue Oct 23, 6:03 pm)
Re: [PATCH] e1000, e1000e valid-addr fixes, David Miller, (Tue Oct 23, 6:07 pm)
Re: [PATCH] e1000, e1000e valid-addr fixes, Adrian Bunk, (Tue Oct 23, 6:15 pm)
Re: [PATCH] e1000, e1000e valid-addr fixes, Jeff Garzik, (Tue Oct 23, 7:20 pm)
Re: [PATCH] e1000, e1000e valid-addr fixes, David Miller, (Tue Oct 23, 7:23 pm)
Re: [PATCH] e1000, e1000e valid-addr fixes, Kok, Auke, (Thu Nov 1, 11:04 am)
Re: [PATCH] e1000, e1000e valid-addr fixes, Stephen Hemminger, (Thu Nov 1, 11:11 am)
Re: [PATCH] e1000, e1000e valid-addr fixes, Jeff Garzik, (Thu Nov 1, 11:47 am)
Re: [PATCH] e1000, e1000e valid-addr fixes, Jeff Garzik, (Thu Nov 1, 12:31 pm)