Home » Mailing list archives » linux-kernel » 2007 » October » 23

Re: [PATCH 1/4] stringbuf: A string buffer implementation

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Linus Torvalds <torvalds@...>
To: Matthew Wilcox <matthew@...>
Cc: <akpm@...>, <linux-kernel@...>, Matthew Wilcox <willy@...>
Subject: Re: [PATCH 1/4] stringbuf: A string buffer implementation
Date: Tuesday, October 23, 2007 - 7:43 pm

On Tue, 23 Oct 2007, Matthew Wilcox wrote:

Hmm. Have you looked at the git "strbuf" code? 

And stuff like "sb_string()" are just evil. The string is there. Just call 
it something better than "s", and let people just use "sb->buf" or 
something. Why make the interface harder to use than necessary?

			Linus
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 1/4] stringbuf: A string buffer implementation, Matthew Wilcox, (Tue Oct 23, 5:12 pm)
Re: [PATCH 1/4] stringbuf: A string buffer implementation, Denys Vlasenko, (Tue Oct 30, 11:26 am)
Re: [PATCH 1/4] stringbuf: A string buffer implementation, Pavel Machek, (Sat Oct 27, 3:31 am)
Re: [PATCH 1/4] stringbuf: A string buffer implementation, Pekka Enberg, (Fri Oct 26, 8:05 am)
Re: [PATCH 1/4] stringbuf: A string buffer implementation, Florian Weimer, (Wed Oct 24, 9:21 am)
Re: [PATCH 1/4] stringbuf: A string buffer implementation, Matthew Wilcox, (Wed Oct 24, 10:02 am)
Re: [PATCH 1/4] stringbuf: A string buffer implementation, Matthew Wilcox, (Tue Oct 23, 10:35 pm)
Re: [PATCH 1/4] stringbuf: A string buffer implementation, Eric St-Laurent, (Tue Oct 23, 10:48 pm)
Re: [PATCH 1/4] stringbuf: A string buffer implementation, Linus Torvalds, (Tue Oct 23, 7:43 pm)
Re: [PATCH 1/4] stringbuf: A string buffer implementation, Matthew Wilcox, (Tue Oct 23, 10:30 pm)
Re: [PATCH 1/4] stringbuf: A string buffer implementation, Andrew Morton, (Tue Oct 23, 10:45 pm)
Re: [PATCH 1/4] stringbuf: A string buffer implementation, Eric St-Laurent, (Tue Oct 23, 10:19 pm)
Re: [PATCH 1/4] stringbuf: A string buffer implementation, Matt Mackall, (Tue Oct 23, 6:11 pm)
Re: [PATCH 1/4] stringbuf: A string buffer implementation, Matthew Wilcox, (Tue Oct 23, 9:49 pm)
Re: [PATCH 1/4] stringbuf: A string buffer implementation, Matt Mackall, (Wed Oct 24, 11:20 am)
Re: [PATCH 1/4] stringbuf: A string buffer implementation, Matthew Wilcox, (Wed Oct 24, 11:30 am)
[PATCH 2/4] isdn: Use stringbuf, Matthew Wilcox, (Tue Oct 23, 5:12 pm)
[PATCH 3/4] sound: Use stringbuf, Matthew Wilcox, (Tue Oct 23, 5:12 pm)
Re: [PATCH 3/4] sound: Use stringbuf, Takashi Iwai, (Wed Oct 24, 10:18 am)
Re: [PATCH 3/4] sound: Use stringbuf, Matthew Wilcox, (Wed Oct 24, 12:01 pm)
Re: [PATCH 3/4] sound: Use stringbuf, Takashi Iwai, (Wed Oct 24, 10:50 am)
[PATCH 4/4] partitions: Fix non-atomic printk, Matthew Wilcox, (Tue Oct 23, 5:12 pm)