Re: [BUG] 2.6.23-git18 Kernel oops in sg helpers

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: FUJITA Tomonori
Date: Tuesday, October 23, 2007 - 3:42 pm

On Tue, 23 Oct 2007 20:49:40 +0530
Kamalesh Babulal <kamalesh@linux.vnet.ibm.com> wrote:


Does this work?


diff --git a/arch/x86/kernel/pci-gart_64.c b/arch/x86/kernel/pci-gart_64.c
index c56e9ee..ae7e016 100644
--- a/arch/x86/kernel/pci-gart_64.c
+++ b/arch/x86/kernel/pci-gart_64.c
@@ -338,7 +338,6 @@ static int __dma_map_cont(struct scatterlist *start, int nelems,
 		
 		BUG_ON(s != start && s->offset);
 		if (s == start) {
-			*sout = *s; 
 			sout->dma_address = iommu_bus_base;
 			sout->dma_address += iommu_page*PAGE_SIZE + s->offset;
 			sout->dma_length = s->length;
@@ -365,7 +364,7 @@ static inline int dma_map_cont(struct scatterlist *start, int nelems,
 {
 	if (!need) {
 		BUG_ON(nelems != 1);
-		*sout = *start;
+		sout->dma_address = start->dma_address;
 		sout->dma_length = start->length;
 		return 0;
 	}
-- 
1.5.2.4

-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[BUG] 2.6.23-git18 Kernel oops in sg helpers, Kamalesh Babulal, (Tue Oct 23, 8:19 am)
Re: [BUG] 2.6.23-git18 Kernel oops in sg helpers, Jens Axboe, (Tue Oct 23, 11:44 am)
Re: [BUG] 2.6.23-git18 Kernel oops in sg helpers, FUJITA Tomonori, (Tue Oct 23, 3:42 pm)
Re: [BUG] 2.6.23-git18 Kernel oops in sg helpers, Jens Axboe, (Wed Oct 24, 1:32 am)
Re: [BUG] 2.6.23-git18 Kernel oops in sg helpers, Benny Halevy, (Wed Oct 24, 1:50 am)
Re: [BUG] 2.6.23-git18 Kernel oops in sg helpers, Andy Whitcroft, (Wed Oct 24, 4:54 am)
Re: [BUG] 2.6.23-git18 Kernel oops in sg helpers, Jens Axboe, (Wed Oct 24, 5:25 am)
Re: [BUG] 2.6.23-git18 Kernel oops in sg helpers, FUJITA Tomonori, (Wed Oct 24, 5:40 am)
Re: [BUG] 2.6.23-git18 Kernel oops in sg helpers, Kamalesh Babulal, (Wed Oct 24, 9:08 am)
Re: [BUG] 2.6.23-git18 Kernel oops in sg helpers, Jens Axboe, (Wed Oct 24, 11:06 am)
Re: [BUG] 2.6.23-git18 Kernel oops in sg helpers, FUJITA Tomonori, (Wed Oct 24, 3:09 pm)
Re: [BUG] 2.6.23-git18 Kernel oops in sg helpers, Jens Axboe, (Wed Oct 24, 10:34 pm)
Re: [BUG] 2.6.23-git18 Kernel oops in sg helpers, Benny Halevy, (Thu Oct 25, 1:53 am)