Home » Mailing list archives » linux-kernel » 2007 » October » 23

Re: [PATCH] Add eeprom_bad_csum_allow module option to e1000.

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Dave Jones <davej@...>
To: Jeff Garzik <jeff@...>
Cc: Kok, Auke <auke-jan.h.kok@...>, Adam Jackson <ajax@...>, <linux-kernel@...>, David Miller <davem@...>, netdev <netdev@...>
Subject: Re: [PATCH] Add eeprom_bad_csum_allow module option to e1000.
Date: Tuesday, October 23, 2007 - 5:20 pm

On Tue, Oct 23, 2007 at 04:40:01PM -0400, Jeff Garzik wrote:

 > > In any case, this patch should not be merged. We often send it around to users to
 > > debug their issue in case it involves eeproms, but merging it will just conceal
 > > the real issue and all of a sudden a flood of people stop reporting *real* issues
 > > to us.
 > 
 > Sorry, I disagree.  Just as with e100, if there is a clear way the user 
 > can recover their setup -- and Adam says his was effective -- I don't 
 > see why we should be denying users the ability to use their own hardware.
 
Indeed. This is a common enough problem that not including it causes more pain
than its worth.  I have two affected boxes myself that I actually thought
the hardware was dead before I tried ajax's patch.

People aren't going to report this as a bug. They aren't going to try out patches,
they're going to do what I did and stick another network card in the box and
go on with life.

Our users deserve better than this.

	Dave

-- 
http://www.codemonkey.org.uk
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] Add eeprom_bad_csum_allow module option to e1000., Adam Jackson, (Tue Oct 23, 10:58 am)
Re: [PATCH] Add eeprom_bad_csum_allow module option to e1000., Kok, Auke, (Tue Oct 23, 12:18 pm)
Re: [PATCH] Add eeprom_bad_csum_allow module option to e1000., Adam Jackson, (Tue Oct 23, 12:21 pm)
Re: [PATCH] Add eeprom_bad_csum_allow module option to e1000., Kok, Auke, (Tue Oct 23, 1:09 pm)
Re: [PATCH] Add eeprom_bad_csum_allow module option to e1000., Jeff Garzik, (Tue Oct 23, 4:40 pm)
Re: [PATCH] Add eeprom_bad_csum_allow module option to e1000., David Miller, (Tue Oct 23, 5:48 pm)
Re: [PATCH] Add eeprom_bad_csum_allow module option to e1000., Dave Jones, (Tue Oct 23, 5:20 pm)
Re: [PATCH] Add eeprom_bad_csum_allow module option to e1000., Kok, Auke, (Tue Oct 23, 7:03 pm)
Re: [PATCH] Add eeprom_bad_csum_allow module option to e1000., Dave Jones, (Wed Oct 24, 1:38 am)
Re: [PATCH] Add eeprom_bad_csum_allow module option to e1000., Stephen Hemminger, (Tue Oct 23, 7:53 pm)
Re: [PATCH] Add eeprom_bad_csum_allow module option to e1000., David Miller, (Tue Oct 23, 5:53 pm)
[PATCH] e1000, e1000e valid-addr fixes, Jeff Garzik, (Tue Oct 23, 8:55 pm)
Re: [PATCH] e1000, e1000e valid-addr fixes, Adrian Bunk, (Tue Oct 23, 9:15 pm)
Re: [PATCH] e1000, e1000e valid-addr fixes, Jeff Garzik, (Tue Oct 23, 9:03 pm)
Re: [PATCH] e1000, e1000e valid-addr fixes, David Miller, (Tue Oct 23, 9:07 pm)
Re: [PATCH] e1000, e1000e valid-addr fixes, Jeff Garzik, (Tue Oct 23, 10:20 pm)
Re: [PATCH] e1000, e1000e valid-addr fixes, Stephen Hemminger, (Thu Nov 1, 2:11 pm)
Re: [PATCH] e1000, e1000e valid-addr fixes, Jeff Garzik, (Thu Nov 1, 3:31 pm)
Re: [PATCH] e1000, e1000e valid-addr fixes, David Miller, (Tue Oct 23, 10:23 pm)
Re: [PATCH] e1000, e1000e valid-addr fixes, Kok, Auke, (Thu Nov 1, 2:04 pm)
Re: [PATCH] e1000, e1000e valid-addr fixes, Jeff Garzik, (Thu Nov 1, 2:47 pm)
Re: [PATCH] Add eeprom_bad_csum_allow module option to e1000., Kok, Auke, (Tue Oct 23, 7:19 pm)
Re: [PATCH] Add eeprom_bad_csum_allow module option to e1000., Alan Cox, (Tue Oct 23, 5:38 pm)
Re: [PATCH] Add eeprom_bad_csum_allow module option to e1000., Kok, Auke, (Tue Oct 23, 5:01 pm)
Re: [PATCH] Add eeprom_bad_csum_allow module option to e1000., David Miller, (Tue Oct 23, 5:51 pm)