On Tue, Oct 23, 2007 at 04:17:50PM -0400, Dave Jones wrote:Here the ./scripts/checkpatch.pl output: $ ./scripts/checkpatch.pl patch WARNING: do not add new typedefs #522: FILE: Documentation/pps/timepps.h:59: +typedef int pps_handle_t; /* represents a PPS source */ WARNING: do not add new typedefs #523: FILE: Documentation/pps/timepps.h:60: +typedef unsigned long pps_seq_t; /* sequence number */ WARNING: do not add new typedefs #524: FILE: Documentation/pps/timepps.h:61: +typedef struct ntp_fp ntp_fp_t; /* NTP-compatible time stamp */ WARNING: do not add new typedefs #525: FILE: Documentation/pps/timepps.h:62: +typedef union pps_timeu pps_timeu_t; /* generic data type for time stamps */ WARNING: do not add new typedefs #526: FILE: Documentation/pps/timepps.h:63: +typedef struct pps_info pps_info_t; WARNING: do not add new typedefs #527: FILE: Documentation/pps/timepps.h:64: +typedef struct pps_params pps_params_t; These refere to an userland include file. WARNING: line over 80 characters #1882: FILE: drivers/serial/serial_core.c:871: + if (((old_flags ^ port->flags) & (UPF_SPD_MASK|UPF_HARDPPS_CD)) || ERROR: need consistent spacing around '|' (ctx:WxV) #2191: FILE: include/linux/serial_core.h:288: + |UPF_HARDPPS_CD)) ^ These refere to previous code. ERROR: Missing Signed-off-by: line(s) Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Attached the new patch. Ciao, Rodolfo -- GNU/Linux Solutions e-mail: giometti@enneenne.com Linux Device Driver giometti@gnudd.com Embedded Systems giometti@linux.it UNIX programming phone: +39 349 2432127
| Andy Whitcroft | Re: 2.6.23-rc6-mm1 |
| Greg KH | [GIT PATCH] driver core patches against 2.6.24 |
| James Bottomley | Re: Integration of SCST in the mainstream Linux kernel |
| Alan | Re: [RFC] Heads up on sys_fallocate() |
git: | |
| Natalie Protasevich | [BUG] New Kernel Bugs |
| Gerrit Renker | [PATCH 0/37] dccp: Feature negotiation - last call for comments |
| Jarek Poplawski | [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock(). |
| Winkler, Tomas | RE: iwlwifi: fix build bug in "iwlwifi: fix LED stall" |
