On Tue, Oct 23, 2007 at 04:17:50PM -0400, Dave Jones wrote:
quoted text
> 
> On the whole, asides from these (very) minor nits, quite a clean
> submission compared to a lot of new driver submissions to lkml.
> Might want to run it through scripts/checkpatch.pl too to see
> if that picks up any more minor fluff.

Here the ./scripts/checkpatch.pl output:

   $ ./scripts/checkpatch.pl patch 
   WARNING: do not add new typedefs
   #522: FILE: Documentation/pps/timepps.h:59:
   +typedef int pps_handle_t;		/* represents a PPS source */

   WARNING: do not add new typedefs
   #523: FILE: Documentation/pps/timepps.h:60:
   +typedef unsigned long pps_seq_t;	/* sequence number */

   WARNING: do not add new typedefs
   #524: FILE: Documentation/pps/timepps.h:61:
   +typedef struct ntp_fp ntp_fp_t;		/* NTP-compatible time stamp */

   WARNING: do not add new typedefs
   #525: FILE: Documentation/pps/timepps.h:62:
   +typedef union pps_timeu pps_timeu_t;	/* generic data type for time stamps */

   WARNING: do not add new typedefs
   #526: FILE: Documentation/pps/timepps.h:63:
   +typedef struct pps_info pps_info_t;

   WARNING: do not add new typedefs
   #527: FILE: Documentation/pps/timepps.h:64:
   +typedef struct pps_params pps_params_t;

These refere to an userland include file.

   WARNING: line over 80 characters
   #1882: FILE: drivers/serial/serial_core.c:871:
   +		if (((old_flags ^ port->flags) & (UPF_SPD_MASK|UPF_HARDPPS_CD)) ||

   ERROR: need consistent spacing around '|' (ctx:WxV)
   #2191: FILE: include/linux/serial_core.h:288:
   +							|UPF_HARDPPS_CD))
                                                        ^
These refere to previous code.

   ERROR: Missing Signed-off-by: line(s)

   Your patch has style problems, please review.  If any of these errors
   are false positives report them to the maintainer, see
   CHECKPATCH in MAINTAINERS.

Attached the new patch.

Ciao,

Rodolfo

-- 

GNU/Linux Solutions                  e-mail:    giometti@enneenne.com
Linux Device Driver                             giometti@gnudd.com
Embedded Systems                     		giometti@linux.it
UNIX programming                     phone:     +39 349 2432127