[PATCH] Add eeprom_bad_csum_allow module option to e1000.

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Adam Jackson
Date: Tuesday, October 23, 2007 - 7:58 am

When the EEPROM gets corrupted, you can fix it with ethtool, but only if
the module loads and creates a network device.  But, without this option,
if the EEPROM is corrupted, the driver will not create a network device.

Signed-off-by: Adam Jackson <ajax@redhat.com>
---
 drivers/net/e1000/e1000_main.c |   10 ++++++++--
 1 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/drivers/net/e1000/e1000_main.c b/drivers/net/e1000/e1000_main.c
index f1ce348..b308c32 100644
--- a/drivers/net/e1000/e1000_main.c
+++ b/drivers/net/e1000/e1000_main.c
@@ -255,6 +255,10 @@ static int debug = NETIF_MSG_DRV | NETIF_MSG_PROBE;
 module_param(debug, int, 0);
 MODULE_PARM_DESC(debug, "Debug level (0=none,...,16=all)");
 
+static int eeprom_bad_csum_allow = 0;
+module_param(eeprom_bad_csum_allow, int, 0);
+MODULE_PARM_DESC(eeprom_bad_csum_allow, "Allow bad eeprom checksums");
+
 /**
  * e1000_init_module - Driver Registration Routine
  *
@@ -1012,7 +1016,8 @@ e1000_probe(struct pci_dev *pdev,
 
 	if (e1000_validate_eeprom_checksum(&adapter->hw) < 0) {
 		DPRINTK(PROBE, ERR, "The EEPROM Checksum Is Not Valid\n");
-		goto err_eeprom;
+		if (!eeprom_bad_csum_allow)
+			goto err_eeprom;
 	}
 
 	/* copy the MAC address out of the EEPROM */
@@ -1024,7 +1029,8 @@ e1000_probe(struct pci_dev *pdev,
 
 	if (!is_valid_ether_addr(netdev->perm_addr)) {
 		DPRINTK(PROBE, ERR, "Invalid MAC Address\n");
-		goto err_eeprom;
+		if (!eeprom_bad_csum_allow)
+			goto err_eeprom;
 	}
 
 	e1000_get_bus_info(&adapter->hw);
-- 
1.5.2.4

-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] Add eeprom_bad_csum_allow module option to e1000., Adam Jackson, (Tue Oct 23, 7:58 am)
Re: [PATCH] Add eeprom_bad_csum_allow module option to e1000., Stephen Hemminger, (Tue Oct 23, 4:53 pm)
[PATCH] e1000, e1000e valid-addr fixes, Jeff Garzik, (Tue Oct 23, 5:55 pm)
Re: [PATCH] e1000, e1000e valid-addr fixes, Jeff Garzik, (Tue Oct 23, 6:03 pm)
Re: [PATCH] e1000, e1000e valid-addr fixes, David Miller, (Tue Oct 23, 6:07 pm)
Re: [PATCH] e1000, e1000e valid-addr fixes, Adrian Bunk, (Tue Oct 23, 6:15 pm)
Re: [PATCH] e1000, e1000e valid-addr fixes, Jeff Garzik, (Tue Oct 23, 7:20 pm)
Re: [PATCH] e1000, e1000e valid-addr fixes, David Miller, (Tue Oct 23, 7:23 pm)
Re: [PATCH] e1000, e1000e valid-addr fixes, Kok, Auke, (Thu Nov 1, 11:04 am)
Re: [PATCH] e1000, e1000e valid-addr fixes, Stephen Hemminger, (Thu Nov 1, 11:11 am)
Re: [PATCH] e1000, e1000e valid-addr fixes, Jeff Garzik, (Thu Nov 1, 11:47 am)
Re: [PATCH] e1000, e1000e valid-addr fixes, Jeff Garzik, (Thu Nov 1, 12:31 pm)