Home » Mailing list archives » linux-kernel » 2007 » October » 23

[PATCH] Fix warning in mm/slub.c

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Olof Johansson
Subject: [PATCH] Fix warning in mm/slub.c
Date: Monday, October 22, 2007 - 9:21 pm

Hi,

"Make kmem_cache_node for SLUB on memory online to avoid panic" introduced
the following:

mm/slub.c:2737: warning: passing argument 1 of 'atomic_read' from
incompatible pointer type


Signed-off-by: Olof Johansson <olof@lixom.net>


diff --git a/mm/slub.c b/mm/slub.c
index aac1dd3..bcdb2c8 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -2734,7 +2734,7 @@ static void slab_mem_offline_callback(void *arg)
 			 * and offline_pages() function shoudn't call this
 			 * callback. So, we must fail.
 			 */
-			BUG_ON(atomic_read(&n->nr_slabs));
+			BUG_ON(atomic_long_read(&n->nr_slabs));
 
 			s->node[offline_node] = NULL;
 			kmem_cache_free(kmalloc_caches, n);
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[Patch](memory hotplug) Make kmem_cache_node for SLUB on m ..., Yasunori Goto, (Wed Oct 17, 8:25 pm)
Re: [Patch](memory hotplug) Make kmem_cache_node for SLUB ..., Andrew Morton, (Wed Oct 17, 8:46 pm)
Re: [Patch](memory hotplug) Make kmem_cache_node for SLUB ..., Christoph Lameter, (Wed Oct 17, 11:25 pm)
Re: [Patch](memory hotplug) Make kmem_cache_node for SLUB ..., Andrew Morton, (Thu Oct 18, 12:00 am)
Re: [Patch](memory hotplug) Make kmem_cache_node for SLUB ..., Yasunori Goto, (Thu Oct 18, 1:33 am)
Re: [Patch](memory hotplug) Make kmem_cache_node for SLUB ..., Christoph Lameter, (Thu Oct 18, 2:13 am)
Re: [Patch](memory hotplug) Make kmem_cache_node for SLUB ..., Yasunori Goto, (Thu Oct 18, 2:20 am)
[PATCH] Fix warning in mm/slub.c, Olof Johansson, (Mon Oct 22, 9:21 pm)
Re: [PATCH] Fix warning in mm/slub.c, Yasunori Goto, (Mon Oct 22, 10:35 pm)
Re: [PATCH] Fix warning in mm/slub.c, Pekka Enberg, (Tue Oct 23, 12:52 am)
Re: [PATCH] Fix warning in mm/slub.c, Christoph Lameter, (Tue Oct 23, 9:21 am)