[RFC] what the hell is going on with /proc/self?

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Al Viro
Date: Monday, October 22, 2007 - 7:03 pm

What is the proc_base_stuff[] nonsense about?  AFAICS, that
went in with no reason whatsoever in
commit 801199ce805a2412bbcd9bfe213092ec656013dd
Author: Eric W. Biederman <ebiederm@xmission.com>
Date:   Mon Oct 2 02:18:48 2006 -0700

	Rationale is very weak and patch adds considerable complexity
for no good reason.  Besides, it's obfuscated just for the hell of it:
	if (!IS_ERR(result) || PTR_ERR(result) != -ENOENT)
instead of
	if (result != ERR_PTR(-ENOENT))
etc.

	Unless there are _real_ plans that would justify that animal,
I'm going to get rid of it in the pending patch series (/proc/self
cleanups, saner dentry retention for non-process parts, etc.).
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[RFC] what the hell is going on with /proc/self?, Al Viro, (Mon Oct 22, 7:03 pm)
Re: [RFC] what the hell is going on with /proc/self?, Matt Mackall, (Tue Oct 23, 1:20 pm)
Re: [RFC] what the hell is going on with /proc/self?, Eric W. Biederman, (Tue Oct 23, 7:57 pm)