linux-kernel mailing list

FromSubjectsort iconDate
Brett Pemberton
kernel BUG at mm/slab.c for 2.6.22.10
--=-Lqx9UpH7n02e1Bu12Rn7 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, Details below, please CC me on replies, as am not subscribed. thanks. Linux tango043.vpac.org 2.6.22.10 #2 SMP Mon Oct 15 10:14:36 EST 2007 x86_64 x86_64 x86_64 GNU/Linux Gnu C 4.1.1 Gnu make 3.81 binutils 2.17.50.0.6-2.el5 util-linux 2.13-pre7 mount 2.13-pre7 module-init-tools 3.3-pre2 e2fsprogs ...
Oct 22, 7:26 pm 2007
thomas.mingarelli
[HP ProLiant WatchDog driver] hpwdt HP WatchDog Patch <resend>
Hp is providing a Hardware WatchDog Timer driver that will only work with the specific HW Timer located in the HP ProLiant iLO 2 ASIC. The iLO 2 HW Timer will generate a Non-maskable Interrupt (NMI) 9 seconds before physically resetting the server, by removing power, so that the event can be logged to the HP Integrated Management Log (IML), a Non-Volatile Random Access Memory (NVRAM). The logging of the event is performed using the HP ProLiant ROM via an Industry Standard access known as a BIOS Servic...
Oct 22, 7:09 pm 2007
Grant Likely
[PATCH] Bugfix to commit 4f9a58d75bfe82ab2b8ba5b8506dfb190a2...
From: Grant Likely &lt;grant.likely@secretlab.ca&gt; Commit 4f9a58d75bfe82ab2b8ba5b8506dfb190a267834 changes the size of AT_VECTOR_SIZE from hard coded '44' to a calculation based on the value of AT_VECTOR_SIZE_ARCH and AT_VECTOR_SIZE_BASE. The change works for arch/powerpc, but it breaks arch/ppc because the needed AT_VECTOR_SIZE_ARCH is not present in include/asm-ppc/system.h and a default value of 0 is used instead. This results in AT_VECTOR_SIZE being too small and it causes a kernel crash on...
Oct 22, 6:38 pm 2007
Dave Hansen
[PATCH] fix up cgroup warning
I just noticed this in mainline: kernel/cgroup.c: In function `proc_cgroupstats_show': kernel/cgroup.c:2405: warning: unused variable `root' --- linux-2.6.git-dave/kernel/cgroup.c | 1 - 1 file changed, 1 deletion(-) diff -puN kernel/cgroup.c~cgroup-warning kernel/cgroup.c --- linux-2.6.git/kernel/cgroup.c~cgroup-warning 2007-10-22 15:10:20.000000000 -0700 +++ linux-2.6.git-dave/kernel/cgroup.c 2007-10-22 15:10:20.000000000 -0700 @@ -2402,7 +2402,6 @@ struct file_operations proc_cgr...
Oct 22, 6:11 pm 2007
Paul Menage
Re: [PATCH] fix up cgroup warning
Thanks - this has already been sent to akpm. Paul -
Oct 22, 6:15 pm 2007
Mauro Carvalho Chehab
[GIT PATCHES] V4L/DVB fixes [RESEND]
Linus, Please pull from: ssh://master.kernel.org/pub/scm/linux/kernel/git/mchehab/v4l-dvb.git master For the following: - removal of the unused .hardware field, that were causing compilation troubles when V4L1 compat were not selected; - misc fixes at several parts of V4L/DVB: tuner-core, cinergyT2, saa7134, cx23885, ivtv, cx88, pvrusb2, dib0700, ir-kdb-i2c, dvb_ca_en50221 and em28xx; Additionally, there are two pending patches for: - Two cx88-a...
Oct 22, 1:57 pm 2007
Mikael Pettersson
[PATCH 2.6.23] uninitialised variable in ARM/ixp4xx clockeve...
Compiling kernel 2.6.23 for an ARM/ixp4xx machine results in: arch/arm/mach-ixp4xx/common.c: In function 'ixp4xx_set_mode': arch/arm/mach-ixp4xx/common.c:445: warning: 'opts' may be used uninitialized in this function The warning is valid: if ixp4xx_set_mode() is called with mode CLOCK_EVT_MODE_RESUME, then 'opts' will be uninitialised at the '*IXP4XX_OSRT1 = osrt | opts;' statement. Initialising opts to zero in this case may not be correct, but at least it's better than writing random junk to ...
Oct 22, 3:44 pm 2007
Syd Alsobrook
Problem: OOPS in khubd on disconnect of Labtec USB Headset
OOPS in khubd on disconnect of Labtec USB Headset Linux version 2.6.23.1 (alsobrsp@karma) (gcc version 4.1.3 20070831 (prerelease) (Debian 4.1.2-16)) #5 SMP PREEMPT Sat Oct 20 11:53:38 EDT 2007 BUG: unable to handle kernel paging request at virtual address 00100100 printing eip: f89b5faa *pde = 00000000 Oops: 0000 [#1] PREEMPT SMP Modules linked in: snd_rtctimer dv1394 raw1394 nfsd exportfs auth_rpcgss ppdev lp fan ac battery autofs4 nfs lockd nfs_acl sunrpc ipv6 fuse dm_snapshot dm_mirro...
Oct 22, 3:03 pm 2007
Dave Jones
CodingStyle nits in sbf.c
misplaced brackets, 80 columns, whitespace. Signed-off-by: Dave Jones &lt;davej@redhat.com&gt; diff --git a/arch/x86/kernel/bootflag.c b/arch/x86/kernel/bootflag.c index 0b98605..85fc177 100644 --- a/arch/x86/kernel/bootflag.c +++ b/arch/x86/kernel/bootflag.c @@ -30,10 +30,9 @@ static int __init parity(u8 v) int x = 0; int i; - for(i=0;i&lt;8;i++) - { - x^=(v&amp;1); - v&gt;&gt;=1; + for (i=0; i&lt;8; i++) { + x ^= (v &amp; 1); + v &gt;&gt;= 1; } return x; } @@ -41,13...
Oct 22, 3:12 pm 2007
Andres Salomon
[PATCH] kconfig: use getopt() in conf.c for handling command...
First, rename ac/av to argc/argv; those are pretty conventional names. Second, switch from doing our own parsing of command line arguments to using getopt(3) to do it. Aside from simplifying things, this allows us to specify multiple arguments; the old code could only accept two arguments (input_mode and kconfig name). Note some subtle changes: - The argument '-?' is no longer supported. - '-h' is not treated as an error, so output goes to stdout, and we exit with '0'. - There is no comp...
Oct 22, 3:12 pm 2007
Jiri Slaby
[PATCH 1/1] Char: cyclades, fix potential NULL dereference
cyclades, fix potential NULL dereference to ztxdone is jumped even if tty is NULL and tty_wakeup placed after this label doesn't expect NULLed parameter, so this will cause an oops in some situations (why they scheduled a wakeup there before remove bottom half processing patch?). wakeup only in the case when we have non-null tty struct. Spotted by Adrian Bunk. Signed-off-by: Jiri Slaby &lt;jirislaby@gmail.com&gt; Cc: Adrian Bunk &lt;bunk@kernel.org&gt; --- commit d5e700a2247a9dc66cda09e6d89d...
Oct 22, 3:04 pm 2007
Sam Ravnborg
[GIT PULL] 3 kbuild fixes
A few kbuild related fixes. Please pull from: ssh://master.kernel.org/pub/scm/linux/kernel/git/sam/kbuild.git Full diff below. I had originally postponed any pull until after -rc1 but the module_install thing will annoy too much. Sam Documentation/kbuild/makefiles.txt | 10 +++++----- Makefile | 7 ++++--- 2 files changed, 9 insertions(+), 8 deletions(-) Geert Uytterhoeven (1): kbuild: cc-cross-prefix spelling Sam Ravnborg (2): kb...
Oct 22, 2:59 pm 2007
Denis Cheng
[PATCH] [net/ipv4]: fib_seq_show function adjustment to get ...
the temporary bf[127] char array is redundant, and the specified width 127 make the output of /proc/net/route include many trailing spaces; since most terminal's cols are less than 127, this made every fib entry occupy two lines, after applied this patch, the output of /proc/net/route is more sensable like this: Iface Destination Gateway Flags RefCnt Use Metric Mask MTU Window IRTT eth0 0001A8C0 00000000 0001 0 0 0 00FFFFFF 0 0 0 lo 0000007F 00000000 0001 0 0 0 000000FF 0 0 0 eth0 00000000 0101A...
Oct 22, 2:26 pm 2007
Eric Dumazet
Re: [PATCH] [net/ipv4]: fib_seq_show function adjustment to ...
Hum... did you test your patch with many routes declared ? (more than 32 on i386/x86_64) 127 is not a random value, but chosen as a power of two minus 1. PAGE_SIZE is garanted to be a multiple of 128 (127 chars + line_feed) on all arches. So each read() on /proc/net/route delivers PAGE_SIZE/128 lines. With your patch, some lines might be truncated (one every 32 on i386) -
Oct 22, 3:31 pm 2007
Stefan Richter
[GIT PULL] FireWire updates
Linus, please pull from the for-linus branch at git://git.kernel.org/pub/scm/linux/kernel/git/ieee1394/linux1394-2.6.git for-linus to receive the following FireWire subsystem updates. They have not been in -mm but they are trivial. drivers/firewire/fw-ohci.c | 13 +++++++++---- 1 files changed, 9 insertions(+), 4 deletions(-) Stefan Richter (2): firewire: fw-ohci: log a note about unsupported features firewire: fw-ohci: shut up a superfluous compiler warning Full log ...
Oct 22, 2:25 pm 2007
Hugh Dickins
[PATCH] fix mprotect vma_wants_writenotify prot
Fix mprotect bug in recent commit 3ed75eb8f1cd89565966599c4f77d2edb086d5b0 (setup vma-&gt;vm_page_prot by vm_get_page_prot()): the vma_wants_writenotify case was setting the same prot as when not. Nothing wrong with the use of protection_map[] in mmap_region(), but use vm_get_page_prot() there too in the same ~VM_SHARED way. Signed-off-by: Hugh Dickins &lt;hugh@veritas.com&gt; --- mm/mmap.c | 3 +-- mm/mprotect.c | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) --- 2.6.2...
Oct 22, 2:12 pm 2007
Jens Axboe
[PATCH 00/10] SG updates
Hi, I split the patch up into a few pieces, so it can be applied safely. It builds with allyesconfig on i386 and x86-64, and it's been booted and tested on both those archs and ppc64 as well. The same patch series can also be applied by pulling git://git.kernel.dk/linux-2.6-block.git sg -
Oct 22, 2:10 pm 2007
Jens Axboe
[PATCH 08/10] [SG] Update arch/ to use sg helpers
Signed-off-by: Jens Axboe &lt;jens.axboe@oracle.com&gt; --- arch/alpha/kernel/pci_iommu.c | 2 +- arch/arm/common/dmabounce.c | 2 +- arch/blackfin/kernel/dma-mapping.c | 3 +-- arch/ia64/hp/common/sba_iommu.c | 2 +- arch/ia64/hp/sim/simscsi.c | 4 ++-- arch/ia64/sn/pci/pci_dma.c | 2 +- arch/m68k/kernel/dma.c | 2 +- arch/mips/mm/dma-default.c | 16 +++++++--------- arch/powerpc/ker...
Oct 22, 2:11 pm 2007
Benny Halevy
Re: [PATCH 08/10] [SG] Update arch/ to use sg helpers
It looks like it could be nice to define and use a helper for page_address(sg_page(sg)) (although 11 call sites could use it after this patch) #define sg_pgaddr(sg) page_address(sg_page(sg)) Note that mips sg_{un,}map_sg checked for page_address(sg-&gt;page) != 0 before calling __dma_sync(addr + sg-&gt;offset, sg-&gt;length, direction) and you changed it to addr = (unsigned long) sg_virt(sg) which takes sg-&gt;offset into account. That said I'm not sure if the original code was correct for the ...
Oct 22, 5:10 pm 2007
Jens Axboe
[PATCH 07/10] [SG] Update swiotlb to use sg helpers
Signed-off-by: Jens Axboe &lt;jens.axboe@oracle.com&gt; --- lib/swiotlb.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lib/swiotlb.c b/lib/swiotlb.c index 752fd95..1a8050a 100644 --- a/lib/swiotlb.c +++ b/lib/swiotlb.c @@ -35,7 +35,7 @@ #define OFFSET(val,align) ((unsigned long) \ ( (val) &amp; ( (align) - 1))) -#define SG_ENT_VIRT_ADDRESS(sg) (page_address((sg)-&gt;page) + (sg)-&gt;offset) +#define SG_ENT_VIRT_ADDRESS(sg) (sg_virt((sg))) ...
Oct 22, 2:11 pm 2007
Jens Axboe Oct 22, 2:11 pm 2007
Jens Axboe
[PATCH 05/10] [SG] Update fs/ to use sg helpers
Signed-off-by: Jens Axboe &lt;jens.axboe@oracle.com&gt; --- fs/ecryptfs/crypto.c | 16 +++++++++++----- fs/ecryptfs/keystore.c | 3 +++ fs/nfsd/nfs4recover.c | 8 +++----- 3 files changed, 17 insertions(+), 10 deletions(-) diff --git a/fs/ecryptfs/crypto.c b/fs/ecryptfs/crypto.c index 1ae90ef..0a9882e 100644 --- a/fs/ecryptfs/crypto.c +++ b/fs/ecryptfs/crypto.c @@ -283,7 +283,7 @@ int virt_to_scatterlist(const void *addr, int size, struct scatterlist *sg, pg = virt_to_page(addr);...
Oct 22, 2:10 pm 2007
Jens Axboe
[PATCH 04/10] [SG] Update drivers to use sg helpers
Signed-off-by: Jens Axboe &lt;jens.axboe@oracle.com&gt; --- arch/um/drivers/ubd_kern.c | 2 +- drivers/ata/libata-core.c | 10 ++++---- drivers/ata/libata-scsi.c | 2 +- drivers/block/DAC960.c | 2 + drivers/block/cciss.c | 4 +- drivers/block/cpqarray.c | 3 +- drivers/block/cryptoloop.c | 12 ++++++--- drivers/block/sunvdc.c |...
Oct 22, 2:10 pm 2007
Jens Axboe
[PATCH 03/10] [SG] Update crypto/ to sg helpers
Signed-off-by: Jens Axboe &lt;jens.axboe@oracle.com&gt; --- crypto/digest.c | 2 +- crypto/hmac.c | 3 ++- crypto/scatterwalk.c | 2 +- crypto/scatterwalk.h | 6 +++--- crypto/tcrypt.c | 4 ++-- crypto/xcbc.c | 2 +- 6 files changed, 10 insertions(+), 9 deletions(-) diff --git a/crypto/digest.c b/crypto/digest.c index e56de67..8871dec 100644 --- a/crypto/digest.c +++ b/crypto/digest.c @@ -41,7 +41,7 @@ static int update2(struct hash_desc *desc, r...
Oct 22, 2:10 pm 2007
Jens Axboe
[PATCH 02/10] [SG] Update block layer to use sg helpers
Signed-off-by: Jens Axboe &lt;jens.axboe@oracle.com&gt; --- block/ll_rw_blk.c | 8 ++++++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/block/ll_rw_blk.c b/block/ll_rw_blk.c index 8025d64..61c2e39 100644 --- a/block/ll_rw_blk.c +++ b/block/ll_rw_blk.c @@ -1354,8 +1354,9 @@ new_segment: else sg = sg_next(sg); - memset(sg, 0, sizeof(*sg)); - sg-&gt;page = bvec-&gt;bv_page; + sg_dma_len(sg) = 0; + sg_dma_address(sg) = 0; + sg_set_page(sg, bvec-&gt;bv...
Oct 22, 2:10 pm 2007
Jens Axboe
[PATCH 01/10] [SG] Add helpers for manipulating SG entries
We can then transition drivers without changing the generated code. Signed-off-by: Jens Axboe &lt;jens.axboe@oracle.com&gt; --- include/linux/scatterlist.h | 112 +++++++++++++++++++++++++++++++++++++++--- 1 files changed, 104 insertions(+), 8 deletions(-) diff --git a/include/linux/scatterlist.h b/include/linux/scatterlist.h index 2dc7464..1645795 100644 --- a/include/linux/scatterlist.h +++ b/include/linux/scatterlist.h @@ -2,24 +2,37 @@ #define _LINUX_SCATTERLIST_H #include &lt;asm/...
Oct 22, 2:10 pm 2007
Jens Axboe
[PATCH 10/10] Add CONFIG_DEBUG_SG sg validation
Add a Kconfig entry which will toggle some sanity checks on the sg entry and tables. Signed-off-by: Jens Axboe &lt;jens.axboe@oracle.com&gt; --- include/asm-alpha/scatterlist.h | 3 +++ include/asm-arm/scatterlist.h | 3 +++ include/asm-avr32/scatterlist.h | 3 +++ include/asm-blackfin/scatterlist.h | 3 +++ include/asm-cris/scatterlist.h | 3 +++ include/asm-frv/scatterlist.h | 3 +++ include/asm-h8300/scatterlist.h | 3 +++ include/asm-ia64/...
Oct 22, 2:11 pm 2007
Jens Axboe
[PATCH 09/10] Change table chaining layout
Change the page member of the scatterlist structure to be an unsigned long, and encode more stuff in the lower bits: - Bits 0 and 1 zero: this is a normal sg entry. Next sg entry is located at sg + 1. - Bit 0 set: this is a chain entry, the next real entry is at -&gt;page_link with the two low bits masked off. - Bit 1 set: this is the final entry in the sg entry. sg_next() will return NULL when passed such an entry. It's thus important that sg table users use the proper accessors to get a...
Oct 22, 2:11 pm 2007
Geert Uytterhoeven
Re: [PATCH 09/10] Change table chaining layout
Better safe than sorry... Is it possible that a chain entry pointer has bit 1 set on architectures (e.g. m68k) where the natural alignment of 32-bit quantities is _2_ bytes, not 4? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -
Oct 22, 3:39 pm 2007
Linus Torvalds
Re: [PATCH 09/10] Change table chaining layout
Better make sure that such alignment never happens... But no, I don't think it will, since these things would generally always have to be allocated with an allocator, and the *allocator* won't return 2-byte aligned data structures. Linus -
Oct 22, 3:49 pm 2007
Alan Cox
Re: [PATCH 09/10] Change table chaining layout
On Mon, 22 Oct 2007 12:49:40 -0700 (PDT) No - but a structure which has other objects in it before the object being written out may well be 2 byte aligned on M68K and some of the other externally 16bit platforms - ditto local dynamic objects. Why can't we just make the list one item longer than the entry count and stick a NULL on the end of it like normal people ? Then you need one bit which ought to be safe for everyone (and if the bit is a macro any CPU warped enough to have byte alignment is s...
Oct 22, 4:16 pm 2007
Linus Torvalds
Re: [PATCH 09/10] Change table chaining layout
Well, quite frankly, equally easy is to just add a __attribute__((aligned(4))) or whatever the gcc syntax for that is today.. That guarantees that gcc lays things out properly. Linus -
Oct 22, 4:44 pm 2007
Alan Cox
Re: [PATCH 09/10] Change table chaining layout
On Mon, 22 Oct 2007 13:44:43 -0700 (PDT) For structures, not array elements or stack objects. Does gcc now get aligned correct as an attribute on a stack object ? Still doesn't answer the rather more important question - why not just stick a NULL on the end instead of all the nutty hacks ? -
Oct 22, 5:43 pm 2007
Linus Torvalds
Re: [PATCH 09/10] Change table chaining layout
You still do need one bit for the discontiguous case, so it's not like you can avoid the hacks anyway (unless you just blow up the structure entirely) and make it a separate member). So once you have that bit+pointer, using a separate NULL entry isn't exactly prettier. Especially as we actally want to see the difference between "end-of-allocation" and "not yet filled in", so you shouldn't use NULL anyway, you should probably use something like "all-ones". Linus -
Oct 22, 5:47 pm 2007
Jeff Garzik
Re: [PATCH 09/10] Change table chaining layout
Certainly seems safer than the current "let's run off the end of the list if anything bad happens" setup... And I do not think allocating n+1 scatterlist entries will have much of a negative impact. Jeff -
Oct 22, 5:21 pm 2007
Matt Mackall
Re: [PATCH 09/10] Change table chaining layout
It'll mean m-1 scatterlists fit on a slab. -- Mathematics is the supreme nostalgia of our time. -
Oct 22, 5:47 pm 2007
Alan Cox
Re: [PATCH 09/10] Change table chaining layout
On Mon, 22 Oct 2007 16:47:07 -0500 Is that really a credible space issue ? -
Oct 22, 6:52 pm 2007
Matt Mackall
Re: [PATCH 09/10] Change table chaining layout
Yes. Especially if m is 2 or 1. A scatterlist on 64-bit x86 looks like it takes 32 bytes, which means 128 elements fit on a page. One more spills - ouch! But maybe chaining means this doesn't matter any more. Maybe we can even pick a nice moderate sg size and reduce the number of mempools we need for these things. -- Mathematics is the supreme nostalgia of our time. -
Oct 22, 7:46 pm 2007
Benny Halevy
Re: [PATCH 09/10] Change table chaining layout
Alternatively, I proposed to check for end of list in sg_next by calling it with the next iterator value and number of list elements. We tried that patch here and it seems like a reasonable alternative. -
Oct 22, 5:16 pm 2007
Matt Mackall
Re: [PATCH 09/10] Change table chaining layout
Also, the current version of SLOB will return objects aligned at 2 bytes if the I'm guessing the extra entry makes slab-like allocators unhappy. -- Mathematics is the supreme nostalgia of our time. -
Oct 22, 4:38 pm 2007
Jens Axboe
Re: [PATCH 09/10] Change table chaining layout
How about stack allocations? -- Jens Axboe -
Oct 22, 3:52 pm 2007
Andi Kleen
ata_exec_internal crash at boot in -git22
One of the systems tested in autoboot crashes at boot with with -git22. This is a AMD 2 socket Opteron NUMA system. The tester was a little flakey and happened to hit the x86-merge-broke- compilation window, so the last good data point I have is 2.6.23-rc9. -Andi megasas: 00.00.03.05 Mon Oct 02 11:21:32 PDT 2006 ACPI: PCI Interrupt 0000:03:05.0[A] -&gt; GSI 17 (level, low) -&gt; IRQ 17 ata1: SATA max UDMA/100 cmd 0xFFFFC20000006C80 ctl 0xFFFFC20000006C8A bmdma 0xFFFFC20000006C00 irq 17 ata2:...
Oct 22, 2:08 pm 2007
Jens Axboe
Re: ata_exec_internal crash at boot in -git22
Andi, can you test with this patch applied? http://brick.kernel.dk/sg-git.patch -- Jens Axboe -
Oct 22, 2:26 pm 2007
Andi Kleen
Re: ata_exec_internal crash at boot in -git22
Sorry was a mistake (cue: there is no 2.6.23-git22 yet). It turned out to be an old broken kernel. Current -git seems to boot. Sorry for the noise. -Andi -
Oct 22, 3:17 pm 2007
Jens Axboe
Re: ata_exec_internal crash at boot in -git22
OK, all for the better :-) -- Jens Axboe -
Oct 22, 3:21 pm 2007
Parag Warudkar
Re: 2.6.23 - MacMini - snd-hda-intel stopped working
Right. As was pointed in previous email the bug was introduced in post 2.6.23 updates (I was running git but Makefile version was still 2.6.23). Looks like we have a fix that'll go to Linus shortly. I'll go back to released Same model I have, BTW. Thanks Parag -
Oct 22, 2:07 pm 2007
Roel Kluin
[PATCH retry] return hidden bug and unlock bugs
This patches shouldn't alter behavior when CONFIG_BUG is disabled. It is meant as a replacement for the previous patches. Concerning the patch changing fs/buffer.c, I am still wondering whether "page_cache_release(page)" should be placed before or after the BUG(). -- Unlock before BUG(), but don't change behavior in the case when CONFIG_BUG is disabled Signed-off-by: Roel Kluin &lt;12o3l@tiscali.nl&gt; --- diff --git a/arch/alpha/kernel/pci_iommu.c b/arch/alpha/kernel/pci_iommu....
Oct 22, 1:51 pm 2007
Roel Kluin
Re: [PATCH retry] return hidden bug and unlock bugs
As suggested by Ray Lee, BUG() is changed into WARN_ON(1) -- Unlock before BUG(), but don't change behavior in the case when CONFIG_BUG is disabled. Also changes a return-hidden BUG() in a WARN_ON(1) Signed-off-by: Roel Kluin &lt;12o3l@tiscali.nl&gt; diff --git a/arch/alpha/kernel/pci_iommu.c b/arch/alpha/kernel/pci_iommu.c index e1c4707..d04f151 100644 --- a/arch/alpha/kernel/pci_iommu.c +++ b/arch/alpha/kernel/pci_iommu.c @@ -365,8 +365,8 @@ pci_unmap_single(struct ...
Oct 22, 3:12 pm 2007
Maciej W. Rozycki
[PATCH] defxx.c: dfx_bus_init() is __devexit not __devinit
The dfx_bus_uninit() call is called from dfx_unregister() which is __devexit and which is ultimately the -&gt;remove call for the device. Signed-off-by: Maciej W. Rozycki &lt;macro@linux-mips.org&gt; --- It should be obvious. Please apply. Maciej patch-mips-2.6.23-rc5-20070904-defxx-devexit-0 diff -up --recursive --new-file linux-mips-2.6.23-rc5-20070904.macro/drivers/net/defxx.c linux-mips-2.6.23-rc5-20070904/drivers/net/defxx.c --- linux-mips-2.6.23-rc5-20070904.macro/drivers/net/defxx...
Oct 22, 1:13 pm 2007
Miklos Szeredi
futex strangeness in 2.6.23-mm1/UML
I'm getting a process stuck in pthread_rwlock_wrlock(), even though it looks like the lock is not held by anybody. I think the last -mm was OK. Any ideas? If not, I'll go searching for the offending patch. Thanks, Miklos -
Oct 22, 1:29 pm 2007
previous daytodaynext day
October 21, 2007October 22, 2007October 23, 2007